of: unittest: Add of_node_put() before return
PATCH 1/1 of: unittest: Add of_node_put() before return
The local variable np in function of_unittest_platform_populate takes the return value of of_find_node_by_path, which gets a node but does not put it. If np is not put before return it may cause a memory leak. Hence put np before a return statement.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/of/unittest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/of/unittest.c +3 -1
@@ -1044,8 +1044,10 @@ static void __init of_unittest_platform_populate(void) test_bus =platform_device_register_full (&test_bus_info); rc =PTR_ERR_OR_ZERO (test_bus);unittest (!rc,"testbus registration failed; rc=%i\n" , rc); -if (rc) +if (rc) { +of_node_put (np);return ; + } test_bus->dev.of_node = np;/*
Signature · 1 line
2.19.1
Quoted 11 lines · Nishka Dasgupta
The local variable np in function
of_unittest_platform_populatetakes the return value ofof_find_node_by_path, which gets a node but does not put it. If np is not put before return it may cause a memory leak. Hence put np before a return statement.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/of/unittest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Rob