selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue
Subsystems (3)
PATCH v2 1/1 selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue
When running tcp_fastopen_backup_key.sh the following issue was seen in a busybox environment.
./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected
Shellcheck showed the following issue.
$ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh
In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33:
if [ $val -ne 0 ]; then
^-- SC2086: Double quote to prevent globbing and word splitting.
Rework to do a string comparison instead.
--- tools/testing/selftests/net/tcp_fastopen_backup_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/tcp_fastopen_backup_key.sh +1 -1
@@ -30,7 +30,7 @@ do_test() { ip netns exec "${NETNS}" ./tcp_fastopen_backup_key "$1" val=$(ip netns exec "${NETNS}" nstat -az | \ grep TcpExtTCPFastOpenPassiveFail | awk '{print $2}') - if [ $val -ne 0 ]; then + if [ "$val" != 0 ]; then echo "FAIL: TcpExtTCPFastOpenPassiveFail non-zero" return 1 fi
Signature · 1 line
2.20.1
From: Anders Roxell <[email protected]>
Date: Thu, 15 Aug 2019 09:58:26 +0200
Quoted 7 lines
When running
tcp_fastopen_backup_key.shthe following issue was seen in a busybox environment.
./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expectedShellcheck showed the following issue.
$ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh
Quoted 7 lines
In
tools/testing/selftests/net/tcp_fastopen_backup_key.shline 33:
if [ $val -ne 0 ]; then
^-- SC2086: Double quote to prevent globbing and word splitting.Rework to do a string comparison instead.
Signed-off-by Anders Roxell <[email protected]>
Applied.