Skip to contentSkip to conversation

mm-usercopy-use-memory-range-to-be-accessed-for-wraparound-check.patch removed from -mm tree

merged [email protected] 1 participant 1 message Aug 15, 2019 Stable branch

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: mm/usercopy: use memory range to be accessed for wraparound check
has been removed from the -mm tree. Its filename was
mm-usercopy-use-memory-range-to-be-accessed-for-wraparound-check.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: "Isaac J. Manjarres" <[email protected]>
Subject: mm/usercopy: use memory range to be accessed for wraparound check

Currently, when checking to see if accessing n bytes starting at address "ptr" will cause a wraparound in the memory addresses, the check in check_bogus_address() adds an extra byte, which is incorrect, as the range of addresses that will be accessed is [ptr, ptr + (n - 1)].

This can lead to incorrectly detecting a wraparound in the memory address, when trying to read 4 KB from memory that is mapped to the the last possible page in the virtual address space, when in fact, accessing that range of memory would not cause a wraparound to occur.

Use the memory range that will actually be accessed when considering if accessing a certain amount of bytes will cause the memory address to wrap around.

---

 mm/usercopy.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/usercopy.c renamed from mm/usercopy.c~mm-usercopy-use-memory-range-to-be-accessed-for-wraparound-check +1 -1
@@ -147,7 +147,7 @@ static inline void check_bogus_address(c
 				       bool to_user)
 {
 	/* Reject if object wraps past end of memory. */
-	if (ptr + n < ptr)
+	if (ptr + (n - 1) < ptr)
 		usercopy_abort("wrapped address", NULL, to_user, 0, ptr + n);
 
 	/* Reject if NULL or ZERO-allocation. */

_

Patches currently in -mm which might be from [email protected] are