runqueue: Add a progress meter for checking the task stamps
PATCH v2 1/1 runqueue: Add a progress meter for checking the task stamps
Signed-off-by Peter Kjellerstedt <[email protected]>
--- bitbake/lib/bb/runqueue.py | 8 ++++++++ 1 file changed, 8 insertions(+)
bitbake/lib/bb/runqueue.py +8 -0
@@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): stamppresent = [] tocheck = set() + msg = "Checking task stamps" + bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data) + + checked = 0 for tid in sorted(sqdata.sq_revdeps): (mc, fn, taskname, taskfn) = split_tid_mcfn(tid) + checked = checked + 1 + bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data) + taskdep = rqdata.dataCaches[mc].task_deps[taskfn] if 'noexec' in taskdep and taskname in taskdep['noexec']:
@@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): continue tocheck.add(tid) + bb.event.fire(bb.event.ProcessFinished(msg), cooker.data) valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
Signature · 1 line
2.21.0
Quoted 27 lines · Peter Kjellerstedt
Signed-off-by Peter Kjellerstedt <[email protected]>--- bitbake/lib/bb/runqueue.py | 8 ++++++++ 1 file changed, 8 insertions(+)bitbake/lib/bb/runqueue.py +7
-0@@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): stamppresent = [] tocheck = set() + msg = "Checking task stamps" + bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data) + + checked = 0 for tid in sorted(sqdata.sq_revdeps): (mc, fn, taskname, taskfn) = split_tid_mcfn(tid) + checked = checked + 1 + bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data) + taskdep = rqdata.dataCaches[mc].task_deps[taskfn] if 'noexec' in taskdep and taskname in taskdep['noexec']:
bitbake/lib/bb/runqueue.py def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): · line 2708
Quoted 6 lines
bitbake/lib/bb/runqueue.py +1
-0@@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): continue tocheck.add(tid) + bb.event.fire(bb.event.ProcessFinished(msg), cooker.data) valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
This was discussed on irc. The performance patches which I've posted should remove the need for a progress bar on this section of code. We really shouldn't be taking a long time here...
Cheers,
Richard