mfd: intel-lpss: Consistently use GENMASK()
Andy Shevchenko
reviewerPATCH v2 1/1 mfd: intel-lpss: Consistently use GENMASK()
Since we already are using BIT() macro, use GENMASK() as well for sake of consistency.
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: drop extra shift, move line closer to other bit definitions
drivers/mfd/intel-lpss.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mfd/intel-lpss.c +5 -5
@@ -47,10 +47,10 @@#define LPSS_PRIV_IDLELTR 0x14#define LPSS_PRIV_LTR_REQ BIT(15) -#define LPSS_PRIV_LTR_SCALE_MASK 0xc00 -#define LPSS_PRIV_LTR_SCALE_1US 0x800 -#define LPSS_PRIV_LTR_SCALE_32US 0xc00 -#define LPSS_PRIV_LTR_VALUE_MASK 0x3ff +#define LPSS_PRIV_LTR_SCALE_MASK GENMASK(11, 10) +#define LPSS_PRIV_LTR_SCALE_1US (2 << 10) +#define LPSS_PRIV_LTR_SCALE_32US (3 << 10) +#define LPSS_PRIV_LTR_VALUE_MASK GENMASK(9, 0)#define LPSS_PRIV_SSP_REG 0x20#define LPSS_PRIV_SSP_REG_DIS_DMA_FIN BIT(0)
@@ -59,8 +59,8 @@#define LPSS_PRIV_CAPS 0xfc#define LPSS_PRIV_CAPS_NO_IDMA BIT(8) +#define LPSS_PRIV_CAPS_TYPE_MASK GENMASK(7, 4)#define LPSS_PRIV_CAPS_TYPE_SHIFT 4 -#define LPSS_PRIV_CAPS_TYPE_MASK (0xf << LPSS_PRIV_CAPS_TYPE_SHIFT)/* This matches the type field in CAPS register */ enum intel_lpss_dev_type {
Signature · 1 line
2.23.0.rc1
Lee Jones
AppliedQuoted 8 lines · Andy Shevchenko
Since we already are using
BIT()macro, useGENMASK()as well for sake of consistency.Signed-off-by Andy Shevchenko <[email protected]>---
v2: drop extra shift, move line closer to other bit definitionsdrivers/mfd/intel-lpss.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog