Skip to contentSkip to conversation

ufs-tool: Do not force static linking

PATCH New Khem Raj 1 participant 1 message Aug 17, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 ufs-tool: Do not force static linking

build forced static linking if it detect cross-compilation, static linking with glibc does not work in all circumstances, e.g. when using clang, glibc expects libgcc to be linked in to provide unwinding, which may not be the case, ideally the symbols should be looked up independent of libraries linked in but thats not the case

fixes

| /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/ufs-tool/1.3+gitAUTOINC+8b00e33003-r0/recipe-sysroot-native/usr/bin/arm-yoe-linux-gnueabi/arm-yoe-linux-gnueabi-ld: /mnt/a/yoe/build/tmp/work/cortexa7t2hf-neon-vfpv4-yoe-linux-gnueabi/ufs-tool/1.3+gitAUTOINC+8b00e33003-r0/recipe-sysroot/usr/lib//arm-yoe-linux-gnueabi/9.2.0/../../../lib/libpthread.a(unwind.o): in function `__pthread_unwind':
| /usr/src/debug/glibc/2.30-r0/git/nptl/unwind.c:121: undefined reference to `_Unwind_ForcedUnwind'
| clang-9: error: linker command failed with exit code 1 (use -v to see invocation)
| make: *** [Makefile:40: ufs-tool] Error 1
Cc Denys Dmytriyenko <[email protected]>
---
 meta-filesystems/recipes-utils/ufs-tool/ufs-tool_git.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta-filesystems/recipes-utils/ufs-tool/ufs-tool_git.bb +4 -1
index e074b51971..208ac3c58b 100644
@@ -12,8 +12,11 @@ SRC_URI = "git://github.com/westerndigitalcorporation/ufs-tool.git;protocol=git;
 
 S = "${WORKDIR}/git"
 
-EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}""
+EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} CC="${CC}" CFLAGS="${CFLAGS}""
 
+do_configure() {
+	sed -i -e "s|-static$||g" ${S}/Makefile
+}
 do_install() {
 	install -d ${D}${bindir}/
 	install -c -m 755 ${S}/ufs-tool ${D}${bindir}/
Signature · 1 line
2.22.1