Skip to contentSkip to conversation

staging: android: Remove ion device tree bindings from the TODO

PATCH Superseded Donald Yandt 2 participants 4 messages Aug 17, 2019 – Aug 18, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: android: Remove ion device tree bindings from the TODO

This patch removes the todo for the ion chunk and
carveout device tree bindings.

---
 drivers/staging/android/TODO | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/android/TODO +0 -2
index fbf015cc6..767dd98fd 100644
@@ -6,8 +6,6 @@ TODO:
 
 
 ion/
- - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
-   involve putting appropriate bindings in a memory node for Ion to find.
  - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
  - Better test framework (integration with VGEM was suggested)
 
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 13 lines · Donald Yandt

This patch removes the todo for the ion chunk and
carveout device tree bindings.

---
 drivers/staging/android/TODO | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/android/TODO +0 -0
index fbf015cc6..767dd98fd 100644

drivers/staging/android/TODO TODO: · line 11

Quoted 8 lines
drivers/staging/android/TODO +0 -2
@@ -6,8 +6,6 @@ TODO:
 
 
 ion/
- - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
-   involve putting appropriate bindings in a memory node for Ion to find.
  - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
  - Better test framework (integration with VGEM was suggested)
 

This is already done? Do you have a pointer to the git commit id(s) that did it?

thanks,

greg k-h

#2 lore raw
Quoted 27 lines · Greg KH
Quoted 13 lines · Donald Yandt

This patch removes the todo for the ion chunk and
carveout device tree bindings.

---
 drivers/staging/android/TODO | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/android/TODO +0 -0
index fbf015cc6..767dd98fd 100644

drivers/staging/android/TODO TODO: · line 11

Quoted 8 lines
drivers/staging/android/TODO +0 -2
@@ -6,8 +6,6 @@ TODO:
 
 
 ion/
- - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
-   involve putting appropriate bindings in a memory node for Ion to find.
  - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
  - Better test framework (integration with VGEM was suggested)
 

This is already done? Do you have a pointer to the git commit id(s) that did it?

Quoted 3 lines

thanks,

greg k-h

Hi Greg,

Both the chunk and carveout heaps were removed from ion, so unless I'm mistaken there's no need to implement the device tree bindings for them.

Commits that removed both heaps:
- 23a4388f2 staging: android: ion: Remove file ion_chunk_heap.c
- eadbf7a34 staging: android: ion: Remove file ion_carveout_heap.c

thanks,

Donald

maintainer
#3 lore raw
Quoted 34 lines · Donald Yandt
Quoted 27 lines · Greg KH
Quoted 13 lines · Donald Yandt

This patch removes the todo for the ion chunk and
carveout device tree bindings.

---
 drivers/staging/android/TODO | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/android/TODO +0 -0
index fbf015cc6..767dd98fd 100644

drivers/staging/android/TODO TODO: · line 11

Quoted 8 lines
drivers/staging/android/TODO +0 -2
@@ -6,8 +6,6 @@ TODO:
 
 
 ion/
- - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
-   involve putting appropriate bindings in a memory node for Ion to find.
  - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
  - Better test framework (integration with VGEM was suggested)
 

This is already done? Do you have a pointer to the git commit id(s) that did it?

Quoted 3 lines

thanks,

greg k-h

Hi Greg,

Quoted 7 lines

Both the chunk and carveout heaps were removed from ion, so unless I'm mistaken there's no need to implement the device tree bindings for them.

Commits that removed both heaps:
- 23a4388f2 staging: android: ion: Remove file ion_chunk_heap.c
- eadbf7a34 staging: android: ion: Remove file ion_carveout_heap.c

Great, can you resend this patch with that information in the changelog? As you wrote it, it could be implied that these tasks were actually completed :)

thanks,

greg k-h