udlfb: Make dlfb_ops constant
PATCH 1/1 udlfb: Make dlfb_ops constant
Static structure dlfb_ops, of type fb_ops, is not used except to be copied into another variable. Hence make dlfb_ops constant to protect it from unintended modification.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/video/fbdev/udlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/udlfb.c +1 -1
@@ -1183,7 +1183,7 @@ static int dlfb_ops_blank(int blank_mode, struct fb_info *info)return 0 ; } -static struct fb_ops dlfb_ops = { +static const struct fb_ops dlfb_ops = { .owner =THIS_MODULE , .fb_read = fb_sys_read, .fb_write = dlfb_ops_write,
Signature · 6 lines
2.19.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Nishka Dasgupta
Static structure
dlfb_ops, of typefb_ops, is not used except to be copied into another variable. Hence makedlfb_opsconstant to protect it from unintended modification.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics