pinctrl: rk805: Make structures constant
Subsystems (2)
PATCH 1/1 pinctrl: rk805: Make structures constant
Static structures rk805_pinctrl_desc and rk805_gpio_chip, of types gpio_chip and pinctrl_desc respectively, are not used except to be copied into the fields of a different variable. Hence make rk805_pinctrl_desc and rk805_gpio_chip both constant to protect them from unintended modification.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/pinctrl-rk805.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/pinctrl-rk805.c +2 -2
@@ -197,7 +197,7 @@ static int rk805_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)return !(val & pci->pin_cfg[offset].dir_msk); } -static struct gpio_chip rk805_gpio_chip = { +static const struct gpio_chip rk805_gpio_chip = { .label ="rk805-gpio" , .request = gpiochip_generic_request, .free = gpiochip_generic_free,
@@ -404,7 +404,7 @@ static const struct pinconf_ops rk805_pinconf_ops = { .pin_config_set = rk805_pinconf_set, }; -static struct pinctrl_desc rk805_pinctrl_desc = { +static const struct pinctrl_desc rk805_pinctrl_desc = { .name ="rk805-pinctrl" , .pctlops = &rk805_pinctrl_ops, .pmxops = &rk805_pinmux_ops,
Signature · 1 line
2.19.1
Quoted 8 lines · Nishka Dasgupta
Static structures
rk805_pinctrl_descandrk805_gpio_chip, of typesgpio_chipandpinctrl_descrespectively, are not used except to be copied into the fields of a different variable. Hence makerk805_pinctrl_descandrk805_gpio_chipboth constant to protect them from unintended modification.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied!
Thanks
Linus Walleij