Skip to contentSkip to conversation

soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST

PATCH In review Geert Uytterhoeven 2 participants 3 messages Aug 19, 2019 – Aug 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST

The move of the IXP4xx SoC drivers exposed their config options on all platforms.

Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.

Fixes fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")

---
v2:
- Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX license identifier - Makefile/Kconfig").

---
 drivers/soc/ixp4xx/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
drivers/soc/ixp4xx/Kconfig +4 -0
index de2e62c3310a37d0..e3eb19b85fa4b358 100644
@@ -1,4 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
+if ARCH_IXP4XX || COMPILE_TEST
+
 menu "IXP4xx SoC drivers"
 
 config IXP4XX_QMGR
@@ -15,3 +17,5 @@ config IXP4XX_NPE
 	  and is automatically selected by Ethernet and HSS drivers.
 
 endmenu
+
+endif
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Geert Uytterhoeven

The move of the IXP4xx SoC drivers exposed their config options on all platforms.

Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.

Fixes fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")

---
v2:
- Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX license identifier - Makefile/Kconfig").

Do you want me to also take care of sending this into the ARM SoC tree?

Yours,
Linus Walleij

#2 lore raw

Hi Linus,

Quoted 14 lines · Linus Walleij
Quoted 11 lines · Geert Uytterhoeven

The move of the IXP4xx SoC drivers exposed their config options on all platforms.

Fix this by wrapping them inside an ARCH_IXP4XX or COMPILE_TEST block.

Fixes fcf2d8978cd538a5 ("ARM: ixp4xx: Move NPE and QMGR to drivers/soc")

---
v2:
- Rebased on top of commit ec8f24b7faaf3d47 ("treewide: Add SPDX license identifier - Makefile/Kconfig").

Quoted 3 lines

Do you want me to also take care of sending this into the ARM SoC tree?

Given you're listed as (one of) the maintainer(s), I think that would make perfect sense.

Thanks!

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds