Skip to contentSkip to conversation

x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

PATCH New Andy Shevchenko 2 participants 5 messages Aug 19, 2019 – Aug 26, 2019 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

Using ACPI predefined macros, such as Zero or One, will reduce a binary size of resulting ACPI tables.

---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/include/asm/arch-tangier/acpi/platform.asl +1 -1
index bd1aa9ce88..39bcaf3801 100644
@@ -18,7 +18,7 @@ Method(_PTS, 1)
 /* The _WAK method is called on system wakeup */
 Method(_WAK, 1)
 {
-    Return (Package() {0, 0})
+    Return (Package() { Zero, Zero })
 }
 
 Scope (\_SB)
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +2 -2
index bb2a59dbc2..aedc62cc0c 100644
@@ -10,8 +10,8 @@ Device (PCI0)
     Name (_HID, EISAID("PNP0A08"))    /* PCIe */
     Name (_CID, EISAID("PNP0A03"))    /* PCI */
 
-    Name (_ADR, 0)
-    Name (_BBN, 0)
+    Name (_ADR, Zero)
+    Name (_BBN, Zero)
 
     Name (MCRS, ResourceTemplate()
     {
Signature · 1 line
2.23.0.rc1
#1 lore raw

PATCH 1/1 x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

Quoted 10 lines · Andy Shevchenko

Using ACPI predefined macros, such as Zero or One, will reduce a binary size of resulting ACPI tables.

---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
#2 lore raw

PATCH 1/1 x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

Hi Andy,

Quoted 7 lines · Bin Meng
Quoted 4 lines · Andy Shevchenko

Using ACPI predefined macros, such as Zero or One, will reduce a binary size of resulting ACPI tables.

Quoted 8 lines
Quoted 6 lines
---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Somehow this patch does not apply cleanly on top of latest u-boot/master, so I manually fixed the issue and

applied to u-boot-x86, thanks!

Regards,
Bin

#3 lore raw

PATCH 1/1 x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

Quoted 17 lines · Bin Meng

Hi Andy,

Quoted 14 lines · Bin Meng
Quoted 10 lines · Andy Shevchenko

Using ACPI predefined macros, such as Zero or One, will reduce a binary size of resulting ACPI tables.

---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Quoted 6 lines
Quoted 1 line

Somehow this patch does not apply cleanly on top of latest u-boot/master, so I manually fixed the issue and

applied to u-boot-x86, thanks!

Thanks!

P.S. It seems the subject missed. If you can rebase, it might be worth to fix.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

PATCH 1/1 x86: acpi: Slightly reduce binary size of ACPI tables for Tangier

Hi Andy,

Quoted 21 lines · Andy Shevchenko
Quoted 19 lines · Bin Meng

Hi Andy,

Quoted 15 lines · Bin Meng
Quoted 10 lines · Andy Shevchenko

Using ACPI predefined macros, such as Zero or One, will reduce a binary size of resulting ACPI tables.

---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl     | 2 +-
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Quoted 9 lines
Quoted 4 lines

Somehow this patch does not apply cleanly on top of latest u-boot/master, so I manually fixed the issue and

applied to u-boot-x86, thanks!

Thanks!

P.S. It seems the subject missed. If you can rebase, it might be worth to fix.

Ah, yes! Thanks for catching this. I added the commit subject.

Regards,
Bin