Skip to contentSkip to conversation

reset: Remove copy'n'paste redundancy in the comments

PATCH In review Andy Shevchenko 2 participants 3 messages Aug 19, 2019 – Sep 2, 2019 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: Remove copy'n'paste redundancy in the comments

It seems the commit bb475230b8e5
("reset: make optional functions really optional") brought couple of redundant lines in the comments.

Drop them here.

---
 drivers/reset/core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/reset/core.c +0 -2
index 213ff40dda11..2badff33a0db 100644
@@ -334,7 +334,6 @@ EXPORT_SYMBOL_GPL(reset_control_reset);
  * internal state to be reset, but must be prepared for this to happen.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
@@ -393,7 +392,6 @@ EXPORT_SYMBOL_GPL(reset_control_assert);
  * After calling this function, the reset is guaranteed to be deasserted.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
Signature · 1 line
2.23.0.rc1
#1 lore raw
Quoted 5 lines · Andy Shevchenko

It seems the commit bb475230b8e5
("reset: make optional functions really optional") brought couple of redundant lines in the comments.

Drop them here.

Any comment on this?

Quoted 30 lines
---
 drivers/reset/core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/reset/core.c +0 -2
index 213ff40dda11..2badff33a0db 100644
@@ -334,7 +334,6 @@ EXPORT_SYMBOL_GPL(reset_control_reset);
  * internal state to be reset, but must be prepared for this to happen.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
@@ -393,7 +392,6 @@ EXPORT_SYMBOL_GPL(reset_control_assert);
  * After calling this function, the reset is guaranteed to be deasserted.
  * Consumers must not use reset_control_reset on shared reset lines when
  * reset_control_(de)assert has been used.
- * return 0.
  *
  * If rstc is NULL it is an optional reset and the function will just
  * return 0.
Signature · 1 line
2.23.0.rc1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw

Hi Andy,

Quoted 8 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

It seems the commit bb475230b8e5
("reset: make optional functions really optional") brought couple of redundant lines in the comments.

Drop them here.

Any comment on this?

No, this looks correct to me. Thank for the patch! Applied to reset/next.

regards
Philipp