Tools: hv: kvp: eliminate 'may be used uninitialized' warning
Subsystems (2)
PATCH 1/1 Tools: hv: kvp: eliminate 'may be used uninitialized' warning
When building hv_kvp_daemon GCC-8.3 complains:
hv_kvp_daemon.c: In function ‘kvp_get_ip_info.constprop’:
hv_kvp_daemon.c:812:30: warning: ‘ip_buffer’ may be used uninitialized in this function [-Wmaybe-uninitialized]
struct hv_kvp_ipaddr_value *ip_buffer;
this seems to be a false positive: we only use ip_buffer when op == KVP_OP_GET_IP_INFO and it is only unset when op == KVP_OP_ENUMERATE.
Silence the warning by initializing ip_buffer to NULL.
--- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/hv/hv_kvp_daemon.c +1 -1
@@ -809,7 +809,7 @@ kvp_get_ip_info(int family, char *if_name, int op,int sn_offset =0 ;int error =0 ;char *buffer; -struct hv_kvp_ipaddr_value *ip_buffer; +struct hv_kvp_ipaddr_value *ip_buffer =NULL ;char cidr_mask[5 ];/* /xyz */ int weight;int i;
Signature · 1 line
2.20.1
Sasha Levin
AppliedQuoted 6 lines · Vitaly Kuznetsov
When building
hv_kvp_daemonGCC-8.3 complains:
hv_kvp_daemon.c: In function ‘kvp_get_ip_info.constprop’:
hv_kvp_daemon.c:812:30: warning: ‘ip_buffer’ may be used uninitialized in this function [-Wmaybe-uninitialized]
structhv_kvp_ipaddr_value*ip_buffer;
Quoted 6 lines
this seems to be a false positive: we only use
ip_bufferwhen op ==KVP_OP_GET_IP_INFOand it is only unset when op ==KVP_OP_ENUMERATE.Silence the warning by initializing
ip_bufferto NULL.Signed-off-by Vitaly Kuznetsov <[email protected]>
Queued up for hyperv-fixes, thank you.
--
Thanks,
Sasha