Skip to contentSkip to conversation

package/evtest: fix build with musl libc

PATCH New Baruch Siach 3 participants 5 messages Aug 18, 2019 – Sep 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/evtest: fix build with musl libc

Add a patch adding missing limits.h header include.

Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/

---
 .../0001-Add-missing-limits.h-include.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
package/evtest/0001-Add-missing-limits.h-include.patch new file +38 -0
new file mode 100644
index 000000000000..6c7fc90482bb
@@ -0,0 +1,38 @@
+From 7d7c5a81b0e2f3321d269b7acc450d1eec7a910b Mon Sep 17 00:00:00 2001
+From: Baruch Siach <[email protected]>
+Date: Sun, 18 Aug 2019 09:57:23 +0300
+Subject: [PATCH] Add missing limits.h include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes build with musl libc that does not include limits.h indirectly via
+other headers.
+
+evtest.c: In function ?scan_devices?:
+evtest.c:886:14: error: ?PATH_MAX? undeclared (first use in this function); did you mean  INT8_MAX??
+   char fname[PATH_MAX];
+              ^~~~~~~~
+
+Signed-off-by: Baruch Siach <[email protected]>
+---
+Upstream status: sent to input-tools at lists.freedesktop.org (moderated)
+
+ evtest.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/evtest.c b/evtest.c
+index 37d4f8540333..548c203564d3 100644
+--- a/evtest.c
++++ b/evtest.c
+@@ -56,6 +56,7 @@
+ #include <getopt.h>
+ #include <ctype.h>
+ #include <signal.h>
++#include <limits.h>
+ #include <sys/time.h>
+ #include <sys/types.h>
+ #include <unistd.h>
+-- 
+2.23.0.rc1
+
Signature · 1 line
2.23.0.rc1
#1 lore raw

PATCH 1/1 package/evtest: fix build with musl libc

Quoted 7 lines · On Sun, 18 Aug 2019 10:23:10 +0300 Baruch Siach <[email protected]> wrote:

Add a patch adding missing limits.h header include.

Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/

Quoted 5 lines
---
 .../0001-Add-missing-limits.h-include.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/evtest: fix build with musl libc

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 7 lines · On Sun, 18 Aug 2019 10:23:10 +0300 Baruch Siach <[email protected]> wrote:

Add a patch adding missing limits.h header include.

Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/

Quoted 7 lines
Quoted 5 lines
---
 .../0001-Add-missing-limits.h-include.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch

Applied to master, thanks.

This fixes an issue in next after the last evtest version bump. Sorry for not mentioning that in subject.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 package/evtest: fix build with musl libc

Hello Baruch,

Quoted 19 lines · On Mon, 19 Aug 2019 16:46:15 +0300 Baruch Siach <[email protected]> wrote:

Hi Thomas,

Quoted 16 lines · Thomas Petazzoni
Quoted 12 lines · On Sun, 18 Aug 2019 10:23:10 +0300 Baruch Siach <[email protected]> wrote:

Add a patch adding missing limits.h header include.

Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/

---
 .../0001-Add-missing-limits.h-include.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch  
Quoted 4 lines
Quoted 1 line

Applied to master, thanks.

This fixes an issue in next after the last evtest version bump. Sorry for not mentioning that in subject.

Ah indeed, I didn't realize that, and didn't check the autobuilder references. The patch applies fine to master though, and will cause no harm. So I just cherry-picked it in next. I don't think it's worth the effort reverting on master (unless you see a reason to do so ?).

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/evtest: fix build with musl libc

Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello Baruch,

Quoted 21 lines · On Mon, 19 Aug 2019 16:46:15 +0300 Baruch Siach <[email protected]> wrote:

Hi Thomas,

Quoted 17 lines · Thomas Petazzoni
Quoted 7 lines · On Sun, 18 Aug 2019 10:23:10 +0300 Baruch Siach <[email protected]> wrote:

Add a patch adding missing limits.h header include.

Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/

Quoted 5 lines
---
 .../0001-Add-missing-limits.h-include.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch  

Applied to master, thanks.

Quoted 7 lines
Quoted 2 lines

This fixes an issue in next after the last evtest version bump. Sorry for not mentioning that in subject.

Ah indeed, I didn't realize that, and didn't check the autobuilder references. The patch applies fine to master though, and will cause no harm. So I just cherry-picked it in next. I don't think it's worth the effort reverting on master (unless you see a reason to do so ?).

I missed that as well, so I've applied to 2019.02.x and 2019.05.x.

Oh well, shouldn't cause any harm.

Signature · 1 line
Bye, Peter Korsgaard