Skip to contentSkip to conversation

ima-evm-utils: Enable large-file support

PATCH In review Vitaly Chikunov 2 participants 4 messages Aug 19, 2019 – Aug 21, 2019 Keys-trusted

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ima-evm-utils: Enable large-file support

Some architectures require special measures to access large files (LFS). Add AC_SYS_LARGEFILE' to configure.ac' to handle this.

It seems that ABI is not changed with this.

---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +1 -0
index 3f21ba4..02bd6f8 100644
@@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4])
 
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+AC_SYS_LARGEFILE
 
 # Checks for programs.
 AC_PROG_CC
Signature · 1 line
2.11.0
#1 lore raw

Hi Vitaly,

Quoted 15 lines · Vitaly Chikunov

Some architectures require special measures to access large files (LFS). Add AC_SYS_LARGEFILE' to configure.ac' to handle this.

It seems that ABI is not changed with this.

---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +0 -0
index 3f21ba4..02bd6f8 100644

configure.ac AC_CONFIG_MACRO_DIR([m4]) · line 12

Quoted 5 lines
configure.ac +1 -0
@@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4])
 
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+AC_SYS_LARGEFILE
 

Should we also add AC_FUNC_FSEEKO?

I can't see any use of fseek or ftell in the code, but if we are enabling AC_SYS_LARGEFILE by default we also should check for AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever needed.

Quoted 5 lines
configure.ac +0 -0
 # Checks for programs.
 AC_PROG_CC
Signature · 1 line
2.11.0
#2 lore raw

Bruno,

Quoted 24 lines · Bruno Meneguele
Quoted 15 lines · Vitaly Chikunov

Some architectures require special measures to access large files (LFS). Add AC_SYS_LARGEFILE' to configure.ac' to handle this.

It seems that ABI is not changed with this.

---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +0 -0
index 3f21ba4..02bd6f8 100644

configure.ac AC_CONFIG_MACRO_DIR([m4]) · line 12

Quoted 5 lines
configure.ac +1 -0
@@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4])
 
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+AC_SYS_LARGEFILE
 

Should we also add AC_FUNC_FSEEKO?

Quoted 4 lines

I can't see any use of fseek or ftell in the code, but if we are enabling AC_SYS_LARGEFILE by default we also should check for AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever needed.

I thought about AC_FUNC_FSEEKO, but we don't use fseeko/ftello, so it didn't look useful.

Thanks,

Quoted 6 lines
Quoted 6 lines
configure.ac +0 -0
 # Checks for programs.
 AC_PROG_CC
Signature · 1 line
2.11.0
Reviewed-by
#3 lore raw
Quoted 32 lines · Vitaly Chikunov

Bruno,

Quoted 24 lines · Bruno Meneguele
Quoted 15 lines · Vitaly Chikunov

Some architectures require special measures to access large files (LFS). Add AC_SYS_LARGEFILE' to configure.ac' to handle this.

It seems that ABI is not changed with this.

---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
configure.ac +0 -0
index 3f21ba4..02bd6f8 100644

configure.ac AC_CONFIG_MACRO_DIR([m4]) · line 12

Quoted 5 lines
configure.ac +1 -0
@@ -8,6 +8,7 @@ AC_CONFIG_MACRO_DIR([m4])
 
 AC_CANONICAL_HOST
 AC_USE_SYSTEM_EXTENSIONS
+AC_SYS_LARGEFILE
 

Should we also add AC_FUNC_FSEEKO?

Quoted 4 lines

I can't see any use of fseek or ftell in the code, but if we are enabling AC_SYS_LARGEFILE by default we also should check for AC_FUNC_FSEEKO in order to allow the use of fseeko/ftello whenever needed.

Quoted 5 lines

I thought about AC_FUNC_FSEEKO, but we don't use fseeko/ftello, so it didn't look useful.

Thanks,

That's fine by me :)

Just was wondering if we should consider now that for possible use in future. But indeed, that'll be useful only if we would use fseeko/ftello.

Thanks.

Quoted 9 lines
Quoted 7 lines
Quoted 7 lines
configure.ac +0 -0
 # Checks for programs.
 AC_PROG_CC
Signature · 1 line
2.11.0