Skip to contentSkip to conversation

dt-bindings for lima support on HiKey

PATCH In review John Stultz 2 participants 5 messages Aug 19, 2019 – Aug 20, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover dt-bindings for lima support on HiKey

Peter sent a patchset out back in April to enable Lima support on HiKey, but there's not been much action on it since since.

I've been carrying the patchset in my tree, and figured I'd send out just these three dt-bindings changes just so hopefully they can go in and the dependent driver changes can be more easily pushed later on.

thanks
-john

Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Philipp Zabel <[email protected]>
Cc Peter Griffin <[email protected]>

Peter Griffin (3):
dt-bindings: gpu: mali-utgard: add hisilicon,hi6220-mali compatible
dt-bindings: reset: hisilicon: Update compatible documentation
dt-bindings: reset: hisilicon: Add ao reset controller

 Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt  | 5 +++++
 .../devicetree/bindings/reset/hisilicon,hi6220-reset.txt   | 1 +
 include/dt-bindings/reset/hisi,hi6220-resets.h             | 7 +++++++
 3 files changed, 13 insertions(+)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 dt-bindings: gpu: mali-utgard: add hisilicon,hi6220-mali compatible

From: Peter Griffin <[email protected]>

The Hisilicon hi6220 uses a Mali-450MP4 with 4 PPs, so add a compatible for it.

---
 Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt +5 -0
index b352a6851a06..ba895efe3039 100644
@@ -24,6 +24,7 @@ Required properties:
       + rockchip,rk3228-mali
       + rockchip,rk3328-mali
       + stericsson,db8500-mali
+      + hisilicon,hi6220-mali
 
   - reg: Physical base address and length of the GPU registers
 
@@ -98,6 +99,10 @@ to specify one more vendor-specific compatible, among:
       * interrupt-names and interrupts:
         + combined: combined interrupt of all of the above lines
 
+  - hisilicon,hi6220-mali
+    Required properties:
+      * resets: phandles to the reset lines for the GPU
+
 Example:
 
 mali: gpu@1c40000 {
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/3 dt-bindings: reset: hisilicon: Update compatible documentation

In reply to John Stultz

From: Peter Griffin <[email protected]>

The reset driver now supports the ao reset controller, so update the documentation to match.

---
 .../devicetree/bindings/reset/hisilicon,hi6220-reset.txt         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt +1 -0
index c25da39df707..ea0a6a9734c1 100644
@@ -11,6 +11,7 @@ Required properties:
 - compatible: should be one of the following:
   - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
   - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
+  - "hisilicon,hi6220-aoctrl", "syscon" : For ao reset controller.
 - reg: should be register base and length as documented in the
   datasheet
 - #reset-cells: 1, see below
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

PATCH 3/3 dt-bindings: reset: hisilicon: Add ao reset controller

In reply to John Stultz

From: Peter Griffin <[email protected]>

This is required to bring Mali450 gpu out of reset.

---
 include/dt-bindings/reset/hisi,hi6220-resets.h | 7 +++++++
 1 file changed, 7 insertions(+)
include/dt-bindings/reset/hisi,hi6220-resets.h +7 -0
index e7c362a81a97..63aff7d8aa45 100644
@@ -73,4 +73,11 @@
 #define MEDIA_MMU                       6
 #define MEDIA_XG2RAM1                   7
 
+#define AO_G3D                          1
+#define AO_CODECISP                     2
+#define AO_MCPU                         4
+#define AO_BBPHARQMEM                   5
+#define AO_HIFI                         8
+#define AO_ACPUSCUL2C                   12
+
 #endif /*_DT_BINDINGS_RESET_CONTROLLER_HI6220*/
Signature · 1 line
2.17.1
#4 lore raw
In reply to John Stultz
Quoted 8 lines · John Stultz

Peter sent a patchset out back in April to enable Lima support on HiKey, but there's not been much action on it since since.

I've been carrying the patchset in my tree, and figured I'd send out just these three dt-bindings changes just so hopefully they can go in and the dependent driver changes can be more easily pushed later on.

As it's all binding changes, I've applied them to the DT tree.

Rob