Skip to contentSkip to conversation

regression in ath10k dma allocation

DISCUSSION Hillf Danton 1 participant 1 message Aug 20, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · On Tue, 20 Aug 2019 10:15:01 +0800 Christoph Hellwig wrote:
Quoted 8 lines · Nicolin Chen

Right...the condition was in-between. However, not every caller of dma_alloc_contiguous() is supposed to have a coherent check. So we either add a 'bool coherent_ok' to the API or revert the dma-direct part back to the original. Probably former option is better?

Thank you for the debugging. I have been a bit distracted, may not be able to submit a fix very soon. Would you like to help?

Quoted 7 lines

Yeah, it turns out that while the idea for the dma_alloc_contiguous helper was neat it didn't work out at all, and me pushing Nicolin down that route was not a very smart idea. Sorry for causing this mess.

I think we'll just need to open code it for dma-direct for 5.3. Hillf do you want to cook up a patch or should I do it?

Feel free to do that, Sir.

Thanks
Hillf

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu