Prepare i.MX8MM clk
Subsystems (3)
Peng Fan
reviewerv4 cover Prepare i.MX8MM clk
V4:
1/4: Expose CCF for all
2/4: Improve commit log
3/4: Typo fix
4/4: Drop unneeded initialization
V3:
2/4: Fix RST/BYPASS seq issue to avoid glitch
4/4: ARM clk not use 24M for switch, use pll2_500m Add R-b/A-b tag
Fix pll gate shift bit.
V2:
2/4: fix MASK/SHIFT usage
This is to support i.MX8MM clk driver.
i.MX8MM use similar clock design as i.MX7D, but it has use different PLL, so we need to add pll14xx driver. And to simplify the clock usage, import the composite clk driver from Linux Kernel, then we could have simple clk tree.
Peng Fan (4):
clk: imx: expose CCF entry for all
clk: imx: add pll14xx driver
clk: imx: add i.MX8M composite clk support
clk: imx: add i.MX8MM clk driver
drivers/clk/Kconfig | 2 - drivers/clk/imx/Kconfig | 16 ++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-composite-8m.c | 170 +++++++++++++++ drivers/clk/imx/clk-imx8mm.c | 415 +++++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pll14xx.c | 381 ++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h | 25 +++ 7 files changed, 1009 insertions(+), 2 deletions(-) create mode 100644 drivers/clk/imx/clk-composite-8m.c create mode 100644 drivers/clk/imx/clk-imx8mm.c create mode 100644 drivers/clk/imx/clk-pll14xx.c
Signature · 1 line
2.16.4
Peng Fan
reviewerPATCH v4 1/4 clk: imx: expose CCF entry for all
Expose CCF entry, then we could avoid expand the SoC support list
--- drivers/clk/Kconfig | 2 -- drivers/clk/imx/Kconfig | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-)
drivers/clk/Kconfig +0 -2
@@ -48,7 +48,6 @@ config CLK_BOSTON config SPL_CLK_CCF bool "SPL Common Clock Framework [CCF] support " - depends on SPL_CLK_IMX6Q help Enable this option if you want to (re-)use the Linux kernel's Common Clock Framework [CCF] code in U-Boot's SPL.
@@ -62,7 +61,6 @@ config SPL_CLK_COMPOSITE_CCF config CLK_CCF bool "Common Clock Framework [CCF] support " - depends on CLK_IMX6Q || SANDBOX_CLK_CCF help Enable this option if you want to (re-)use the Linux kernel's Common Clock Framework [CCF] code in U-Boot's clock driver.
drivers/clk/imx/Kconfig +16 -0
@@ -20,3 +20,19 @@ config CLK_IMX8 select CLK help This enables support clock driver for i.MX8 platforms. + +config SPL_CLK_IMX8MM + bool "SPL clock support for i.MX8MM" + depends on ARCH_IMX8M && SPL + select SPL_CLK + select SPL_CLK_CCF + help + This enables SPL DM/DTS support for clock driver in i.MX8MM + +config CLK_IMX8MM + bool "Clock support for i.MX8MM" + depends on ARCH_IMX8M + select CLK + select CLK_CCF + help + This enables support clock driver for i.MX8MM platforms.
Signature · 1 line
2.16.4
Peng Fan
reviewerPATCH v4 2/4 clk: imx: add pll14xx driver
In reply to Peng FanAdd pll14xx driver for i.MX8MM usage, modifed
from Linux Kernel 5.3.0-rc1
--- drivers/clk/imx/clk-pll14xx.c | 381 ++++++++++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h | 25 +++ 2 files changed, 406 insertions(+) create mode 100644 drivers/clk/imx/clk-pll14xx.c
drivers/clk/imx/clk-pll14xx.c new file +381 -0
@@ -0,0 +1,381 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright 2017-2019 NXP. +* +* Peng Fan <[email protected]> +*/ + +#include <common.h> +#include <asm/io.h> +#include <malloc.h> +#include <clk-uclass.h> +#include <dm/device.h> +#include <linux/clk-provider.h> +#include <linux/iopoll.h> +#include <clk.h> +#include <div64.h> + +#include "clk.h" + +#define UBOOT_DM_CLK_IMX_PLL1443X "imx_clk_pll1443x" +#define UBOOT_DM_CLK_IMX_PLL1416X "imx_clk_pll1416x" + +#define GNRL_CTL 0x0 +#define DIV_CTL 0x4 +#define LOCK_STATUS BIT(31) +#define LOCK_SEL_MASK BIT(29) +#define CLKE_MASK BIT(11) +#define RST_MASK BIT(9) +#define BYPASS_MASK BIT(4) +#define MDIV_SHIFT 12 +#define MDIV_MASK GENMASK(21, 12) +#define PDIV_SHIFT 4 +#define PDIV_MASK GENMASK(9, 4) +#define SDIV_SHIFT 0 +#define SDIV_MASK GENMASK(2, 0) +#define KDIV_SHIFT 0 +#define KDIV_MASK GENMASK(15, 0) + +#define LOCK_TIMEOUT_US 10000 + +struct clk_pll14xx { +struct clk clk; +void __iomem *base; +enum imx_pll14xx_type type; +const struct imx_pll14xx_rate_table *rate_table; +int rate_count; +}; + +#define to_clk_pll14xx (_clk) container_of(_clk, struct clk_pll14xx, clk) + +static const struct imx_pll14xx_rate_table *imx_get_pll_settings ( +struct clk_pll14xx *pll,unsigned long rate) +{ +const struct imx_pll14xx_rate_table *rate_table = pll->rate_table; +int i; + +for (i =0 ; i < pll->rate_count; i++) +if (rate == rate_table[i].rate) +return &rate_table[i]; + +return NULL ; +} + +static unsigned long clk_pll1416x_recalc_rate (struct clk *clk) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +u64 fvco =clk_get_parent_rate (clk); +u32 mdiv, pdiv, sdiv, pll_div; + + pll_div =readl (pll->base +4 ); + mdiv = (pll_div &MDIV_MASK ) >>MDIV_SHIFT ; + pdiv = (pll_div &PDIV_MASK ) >>PDIV_SHIFT ; + sdiv = (pll_div &SDIV_MASK ) >>SDIV_SHIFT ; + + fvco *= mdiv; +do_div (fvco, pdiv << sdiv); + +return fvco; +} + +static unsigned long clk_pll1443x_recalc_rate (struct clk *clk) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +u64 fvco =clk_get_parent_rate (clk); +u32 mdiv, pdiv, sdiv, pll_div_ctl0, pll_div_ctl1; +short int kdiv; + + pll_div_ctl0 =readl (pll->base +4 ); + pll_div_ctl1 =readl (pll->base +8 ); + mdiv = (pll_div_ctl0 &MDIV_MASK ) >>MDIV_SHIFT ; + pdiv = (pll_div_ctl0 &PDIV_MASK ) >>PDIV_SHIFT ; + sdiv = (pll_div_ctl0 &SDIV_MASK ) >>SDIV_SHIFT ; + kdiv = pll_div_ctl1 &KDIV_MASK ; + +/* fvco = (m * 65536 + k) * Fin / (p * 65536) */ + fvco *= (mdiv *65536 + kdiv); + pdiv *=65536 ; + +do_div (fvco, pdiv << sdiv); + +return fvco; +} + +static inline bool clk_pll1416x_mp_change (const struct imx_pll14xx_rate_table *rate, +u32 pll_div) +{ +u32 old_mdiv, old_pdiv; + + old_mdiv = (pll_div &MDIV_MASK ) >>MDIV_SHIFT ; + old_pdiv = (pll_div &PDIV_MASK ) >>PDIV_SHIFT ; + +return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv; +} + +static inline bool clk_pll1443x_mpk_change (const struct imx_pll14xx_rate_table *rate, +u32 pll_div_ctl0,u32 pll_div_ctl1) +{ +u32 old_mdiv, old_pdiv, old_kdiv; + + old_mdiv = (pll_div_ctl0 &MDIV_MASK ) >>MDIV_SHIFT ; + old_pdiv = (pll_div_ctl0 &PDIV_MASK ) >>PDIV_SHIFT ; + old_kdiv = (pll_div_ctl1 &KDIV_MASK ) >>KDIV_SHIFT ; + +return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv || + rate->kdiv != old_kdiv; +} + +static inline bool clk_pll1443x_mp_change (const struct imx_pll14xx_rate_table *rate, +u32 pll_div_ctl0,u32 pll_div_ctl1) +{ +u32 old_mdiv, old_pdiv, old_kdiv; + + old_mdiv = (pll_div_ctl0 &MDIV_MASK ) >>MDIV_SHIFT ; + old_pdiv = (pll_div_ctl0 &PDIV_MASK ) >>PDIV_SHIFT ; + old_kdiv = (pll_div_ctl1 &KDIV_MASK ) >>KDIV_SHIFT ; + +return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv || + rate->kdiv != old_kdiv; +} + +static int clk_pll14xx_wait_lock (struct clk_pll14xx *pll) +{ +u32 val; + +return readl_poll_timeout (pll->base, val, val &LOCK_TIMEOUT_US , +LOCK_TIMEOUT_US ); +} + +static ulong clk_pll1416x_set_rate (struct clk *clk,unsigned long drate) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +const struct imx_pll14xx_rate_table *rate; +u32 tmp, div_val; +int ret; + + rate =imx_get_pll_settings (pll, drate); +if (!rate) { +pr_err ("%s: Invalid rate : %lu for pll clk %s\n" , __func__, + drate,"xxxx" ); +return -EINVAL ; + } + + tmp =readl (pll->base +4 ); + +if (!clk_pll1416x_mp_change (rate, tmp)) { + tmp &= ~(SDIV_MASK ) <<SDIV_SHIFT ; + tmp |= rate->sdiv <<SDIV_SHIFT ; +writel (tmp, pll->base +4 ); + +return clk_pll1416x_recalc_rate (clk); + } + +/* Bypass clock and set lock to pll output lock */ + tmp =readl (pll->base); + tmp |=LOCK_SEL_MASK ; +writel (tmp, pll->base); + +/* Enable RST */ + tmp &= ~RST_MASK ; +writel (tmp, pll->base); + +/* Enable BYPASS */ + tmp |=BYPASS_MASK ; +writel (tmp, pll->base); + + + div_val = (rate->mdiv <<MDIV_SHIFT ) | (rate->pdiv <<PDIV_SHIFT ) | + (rate->sdiv <<SDIV_SHIFT ); +writel (div_val, pll->base +0x4 ); + +/* +* According to SPEC, t3 - t2 need to be greater than +* 1us and 1/FREF, respectively. +* FREF is FIN / Prediv, the prediv is [1, 63], so choose +* 3us. +*/ +udelay (3 ); + +/* Disable RST */ + tmp |=RST_MASK ; +writel (tmp, pll->base); + +/* Wait Lock */ + ret =clk_pll14xx_wait_lock (pll); +if (ret) +return ret; + +/* Bypass */ + tmp &= ~BYPASS_MASK ; +writel (tmp, pll->base); + +return clk_pll1416x_recalc_rate (clk); +} + +static ulong clk_pll1443x_set_rate (struct clk *clk,unsigned long drate) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +const struct imx_pll14xx_rate_table *rate; +u32 tmp, div_val; +int ret; + + rate =imx_get_pll_settings (pll, drate); +if (!rate) { +pr_err ("%s: Invalid rate : %lu for pll clk %s\n" , __func__, + drate,"===" ); +return -EINVAL ; + } + + tmp =readl (pll->base +4 ); + div_val =readl (pll->base +8 ); + +if (!clk_pll1443x_mpk_change (rate, tmp, div_val)) { + tmp &= ~(SDIV_MASK ) <<SDIV_SHIFT ; + tmp |= rate->sdiv <<SDIV_SHIFT ; +writel (tmp, pll->base +4 ); + +return clk_pll1443x_recalc_rate (clk); + } + + tmp =readl (pll->base); + +/* Enable RST */ + tmp &= ~RST_MASK ; +writel (tmp, pll->base); + +/* Enable BYPASS */ + tmp |=BYPASS_MASK ; +writel (tmp, pll->base); + + div_val = (rate->mdiv <<MDIV_SHIFT ) | (rate->pdiv <<PDIV_SHIFT ) | + (rate->sdiv <<SDIV_SHIFT ); +writel (div_val, pll->base +0x4 ); +writel (rate->kdiv <<KDIV_SHIFT , pll->base +0x8 ); + +/* +* According to SPEC, t3 - t2 need to be greater than +* 1us and 1/FREF, respectively. +* FREF is FIN / Prediv, the prediv is [1, 63], so choose +* 3us. +*/ +udelay (3 ); + +/* Disable RST */ + tmp |=RST_MASK ; +writel (tmp, pll->base); + +/* Wait Lock*/ + ret =clk_pll14xx_wait_lock (pll); +if (ret) +return ret; + +/* Bypass */ + tmp &= ~BYPASS_MASK ; +writel (tmp, pll->base); + +return clk_pll1443x_recalc_rate (clk); +} + +static int clk_pll14xx_prepare (struct clk *clk) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +u32 val; + +/* +* RESETB = 1 from 0, PLL starts its normal +* operation after lock time +*/ + val =readl (pll->base +GNRL_CTL ); + val |=RST_MASK ; +writel (val, pll->base +GNRL_CTL ); + +return clk_pll14xx_wait_lock (pll); +} + +static int clk_pll14xx_unprepare (struct clk *clk) +{ +struct clk_pll14xx *pll =to_clk_pll14xx (dev_get_clk_ptr (clk->dev)); +u32 val; + +/* +* Set RST to 0, power down mode is enabled and +* every digital block is reset +*/ + val =readl (pll->base +GNRL_CTL ); + val &= ~RST_MASK ; +writel (val, pll->base +GNRL_CTL ); + +return 0 ; +} + +static const struct clk_ops clk_pll1416x_ops = { + .enable = clk_pll14xx_prepare, + .disable = clk_pll14xx_unprepare, + .set_rate = clk_pll1416x_set_rate, + .get_rate = clk_pll1416x_recalc_rate, +}; + +static const struct clk_ops clk_pll1443x_ops = { + .enable = clk_pll14xx_prepare, + .disable = clk_pll14xx_unprepare, + .set_rate = clk_pll1443x_set_rate, + .get_rate = clk_pll1443x_recalc_rate, +}; + +struct clk *imx_clk_pll14xx (const char *name,const char *parent_name, +void __iomem *base, +const struct imx_pll14xx_clk *pll_clk) +{ +struct clk_pll14xx *pll; +struct clk *clk; +char *type_name; +int ret; + + pll =kzalloc (sizeof (*pll),GFP_KERNEL ); +if (!pll) +return ERR_PTR (-ENOMEM ); + +switch (pll_clk->type) { +case PLL_1416X : + type_name =UBOOT_DM_CLK_IMX_PLL1416X ; +break ; +case PLL_1443X : + type_name =UBOOT_DM_CLK_IMX_PLL1443X ; +break ; +default : +pr_err ("%s: Unknown pll type for pll clk %s\n" , + __func__, name); +return ERR_PTR (-EINVAL ); + }; + + pll->base = base; + pll->type = pll_clk->type; + pll->rate_table = pll_clk->rate_table; + pll->rate_count = pll_clk->rate_count; + + clk = &pll->clk; + + ret =clk_register (clk, type_name, name, parent_name); +if (ret) { +pr_err ("%s: failed to register pll %s %d\n" , + __func__, name, ret); +kfree (pll); +return ERR_PTR (ret); + } + +return clk; +} + +U_BOOT_DRIVER (clk_pll1443x) = { + .name =UBOOT_DM_CLK_IMX_PLL1443X , + .id =UCLASS_CLK , + .ops = &clk_pll1443x_ops, + .flags =DM_FLAG_PRE_RELOC , +}; + +U_BOOT_DRIVER (clk_pll1416x) = { + .name =UBOOT_DM_CLK_IMX_PLL1416X , + .id =UCLASS_CLK , + .ops = &clk_pll1416x_ops, + .flags =DM_FLAG_PRE_RELOC , +};
drivers/clk/imx/clk.h +25 -0
@@ -20,6 +20,31 @@ enum imx_pllv3_type { IMX_PLLV3_DDR_IMX7, }; +enum imx_pll14xx_type { +PLL_1416X , +PLL_1443X , +}; + +/* NOTE: Rate table should be kept sorted in descending order. */ +struct imx_pll14xx_rate_table { +unsigned int rate; +unsigned int pdiv; +unsigned int mdiv; +unsigned int sdiv; +unsigned int kdiv; +}; + +struct imx_pll14xx_clk { +enum imx_pll14xx_type type; +const struct imx_pll14xx_rate_table *rate_table; +int rate_count; +int flags; +}; + +struct clk *imx_clk_pll14xx (const char *name,const char *parent_name, +void __iomem *base, +const struct imx_pll14xx_clk *pll_clk); + struct clk *clk_register_gate2(struct device *dev, const char *name, const char *parent_name, unsigned long flags, void __iomem *reg, u8 bit_idx, u8 cgr_val,
Signature · 1 line
2.16.4
Peng Fan
reviewerPATCH v4 3/4 clk: imx: add i.MX8M composite clk support
In reply to Peng FanImport i.MX8M composite clk from Linux Kernel 5.3.0-rc2
--- drivers/clk/imx/clk-composite-8m.c | 170 +++++++++++++++++++++++++++++++++++++ 1 file changed, 170 insertions(+) create mode 100644 drivers/clk/imx/clk-composite-8m.c
drivers/clk/imx/clk-composite-8m.c new file +170 -0
@@ -0,0 +1,170 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright 2019 NXP +*/ + +#include <common.h> +#include <asm/io.h> +#include <malloc.h> +#include <clk-uclass.h> +#include <dm/device.h> +#include <linux/clk-provider.h> +#include <clk.h> +#include "clk.h" + +#define UBOOT_DM_CLK_IMX_COMPOSITE "imx_clk_composite" + +#define PCG_PREDIV_SHIFT 16 +#define PCG_PREDIV_WIDTH 3 +#define PCG_PREDIV_MAX 8 + +#define PCG_DIV_SHIFT 0 +#define PCG_DIV_WIDTH 6 +#define PCG_DIV_MAX 64 + +#define PCG_PCS_SHIFT 24 +#define PCG_PCS_MASK 0x7 + +#define PCG_CGC_SHIFT 28 + +static unsigned long imx8m_clk_composite_divider_recalc_rate (struct clk *clk) +{ +struct clk_divider *divider = (struct clk_divider *)to_clk_divider (clk); +struct clk_composite *composite = (struct clk_composite *)clk->data; +ulong parent_rate =clk_get_parent_rate (&composite->clk); +unsigned long prediv_rate; +unsigned int prediv_value; +unsigned int div_value; + +debug ("%s: name %s prate: %lu reg: %p\n" , __func__, + (&composite->clk)->dev->name, parent_rate, divider->reg); + prediv_value =readl (divider->reg) >> divider->shift; + prediv_value &=clk_div_mask (divider->width); + + prediv_rate =divider_recalc_rate (clk, parent_rate, prediv_value, +NULL , divider->flags, + divider->width); + + div_value =readl (divider->reg) >>PCG_DIV_SHIFT ; + div_value &=clk_div_mask (PCG_DIV_WIDTH ); + +return divider_recalc_rate (clk, prediv_rate, div_value,NULL , + divider->flags,PCG_DIV_WIDTH ); +} + +static int imx8m_clk_composite_compute_dividers (unsigned long rate, +unsigned long parent_rate, +int *prediv,int *postdiv) +{ +int div1, div2; +int error =INT_MAX ; +int ret = -EINVAL ; + + *prediv =1 ; + *postdiv =1 ; + +for (div1 =1 ; div1 <=PCG_PREDIV_MAX ; div1++) { +for (div2 =1 ; div2 <=PCG_DIV_MAX ; div2++) { +int new_error = ((parent_rate / div1) / div2) - rate; + +if (abs (new_error) <abs (error)) { + *prediv = div1; + *postdiv = div2; + error = new_error; + ret =0 ; + } + } + } +return ret; +} + +/* +* The clk are bound to a dev, because it is part of composite clk +* use composite clk to get dev +*/ +static ulong imx8m_clk_composite_divider_set_rate (struct clk *clk, +unsigned long rate) +{ +struct clk_divider *divider = (struct clk_divider *)to_clk_divider (clk); +struct clk_composite *composite = (struct clk_composite *)clk->data; +ulong parent_rate =clk_get_parent_rate (&composite->clk); +int prediv_value; +int div_value; +int ret; +u32 val; + + ret =imx8m_clk_composite_compute_dividers (rate, parent_rate, + &prediv_value, &div_value); +if (ret) +return ret; + + val =readl (divider->reg); + val &= ~((clk_div_mask (divider->width) << divider->shift) | + (clk_div_mask (PCG_DIV_WIDTH ) <<PCG_DIV_SHIFT )); + + val |= (u32)(prediv_value -1 ) << divider->shift; + val |= (u32)(div_value -1 ) <<PCG_DIV_SHIFT ; +writel (val, divider->reg); + +return clk_get_rate (&composite->clk); +} + +static const struct clk_ops imx8m_clk_composite_divider_ops = { + .get_rate = imx8m_clk_composite_divider_recalc_rate, + .set_rate = imx8m_clk_composite_divider_set_rate, +}; + +struct clk *imx8m_clk_composite_flags (const char *name, +const char *const *parent_names, +int num_parents,void __iomem *reg, +unsigned long flags) +{ +struct clk *clk =ERR_PTR (-ENOMEM ); +struct clk_divider *div =NULL ; +struct clk_gate *gate =NULL ; +struct clk_mux *mux =NULL ; + + mux =kzalloc (sizeof (*mux),GFP_KERNEL ); +if (!mux) + goto fail; + + mux->reg = reg; + mux->shift =PCG_PCS_SHIFT ; + mux->mask =PCG_PCS_MASK ; + mux->num_parents = num_parents; + mux->flags = flags; + mux->parent_names = parent_names; + + div =kzalloc (sizeof (*div),GFP_KERNEL ); +if (!div) + goto fail; + + div->reg = reg; + div->shift =PCG_PREDIV_SHIFT ; + div->width =PCG_PREDIV_WIDTH ; + div->flags =CLK_DIVIDER_ROUND_CLOSEST | flags; + + gate =kzalloc (sizeof (*gate),GFP_KERNEL ); +if (!gate) + goto fail; + + gate->reg = reg; + gate->bit_idx =PCG_CGC_SHIFT ; + gate->flags = flags; + + clk =clk_register_composite (NULL , name, + parent_names, num_parents, + &mux->clk, &clk_mux_ops, &div->clk, + &imx8m_clk_composite_divider_ops, + &gate->clk, &clk_gate_ops, flags); +if (IS_ERR (clk)) + goto fail; + +return clk; + +fail: +kfree (gate); +kfree (div); +kfree (mux); +return ERR_CAST (clk); +}
Signature · 1 line
2.16.4
Peng Fan
reviewerPATCH v4 4/4 clk: imx: add i.MX8MM clk driver
In reply to Peng FanAdd i.MX8MM clk driver support.
--- drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-imx8mm.c | 415 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 417 insertions(+) create mode 100644 drivers/clk/imx/clk-imx8mm.c
drivers/clk/imx/Makefile +2 -0
@@ -10,3 +10,5 @@ ifdef CONFIG_CLK_IMX8 obj-$(CONFIG_IMX8QXP) += clk-imx8qxp.o obj-$(CONFIG_IMX8QM) += clk-imx8qm.o endif +obj-$(CONFIG_$(SPL_TPL_)CLK_IMX8MM) += clk-imx8mm.o clk-pll14xx.o \ + clk-composite-8m.o
drivers/clk/imx/clk-imx8mm.c new file +415 -0
415 lines not on this page · raw message
Signature · 1 line
2.16.4
v4 cover Prepare i.MX8MM clk
In reply to Peng FanHi Peng,
Quoted 5 lines
V4:
1/4: Expose CCF for all
2/4: Improve commit log
3/4: Typo fix
4/4: Drop unneeded initialization
Your patches cause some build breaks on sandbox:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198639
and TI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198655
The branch which I've used for testing (with your commits):
https://github.com/lmajewski/u-boot-dfu/commits/testing
Please fix above errors and resend your patches.
Quoted 22 lines
V3:
2/4: Fix RST/BYPASS seq issue to avoid glitch
4/4: ARM clk not use 24M for switch, usepll2_500mAdd R-b/A-b tag
Fix pll gate shift bit.V2:
2/4: fix MASK/SHIFT usageThis is to support i.MX8MM clk driver.
i.MX8MM use similar clock design as i.MX7D, but it has use different PLL, so we need to add pll14xx driver. And to simplify the clock usage, import the composite clk driver from Linux Kernel, then we could have simple clk tree.Peng Fan (4):
clk: imx: expose CCF entry for all
clk: imx: add pll14xx driver
clk: imx: add i.MX8M composite clk support
clk: imx: add i.MX8MM clk driver
Quoted 12 lines
drivers/clk/Kconfig | 2 -
drivers/clk/imx/Kconfig | 16 ++
drivers/clk/imx/Makefile | 2 +
drivers/clk/imx/clk-composite-8m.c | 170 +++++++++++++++
drivers/clk/imx/clk-imx8mm.c | 415
+++++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pll14xx.c
| 381 ++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h
| 25 +++ 7 files changed, 1009 insertions(+), 2 deletions(-)
create mode 100644 drivers/clk/imx/clk-composite-8m.c
create mode 100644 drivers/clk/imx/clk-imx8mm.c
create mode 100644 drivers/clk/imx/clk-pll14xx.cBest regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190820/f9b1a620/attachment.sig>
Peng Fan
reviewerv4 cover Prepare i.MX8MM clk
Quoted 13 lines
Subject: Re: [PATCH V4 0/4] Prepare i.MX8MM clk
Hi Peng,
Quoted 5 lines
V4:
1/4: Expose CCF for all
2/4: Improve commit log
3/4: Typo fix
4/4: Drop unneeded initializationYour patches cause some build breaks on sandbox:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198639
Quoted 7 lines
and TI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198655The branch which I've used for testing (with your commits):
https://github.com/lmajewski/u-boot-dfu/commits/testingPlease fix above errors and resend your patches.
Sorry, I should run CI before posting patches. Will fix and send new version patches.
Thanks,
Peng.
Quoted 50 lines
Quoted 24 lines
V3:
2/4: Fix RST/BYPASS seq issue to avoid glitch
4/4: ARM clk not use 24M for switch, usepll2_500mAdd R-b/A-b tag
Fix pll gate shift bit.V2:
2/4: fix MASK/SHIFT usageThis is to support i.MX8MM clk driver.
i.MX8MM use similar clock design as i.MX7D, but it has use different PLL, so we need to add pll14xx driver. And to simplify the clock usage, import the composite clk driver from Linux Kernel, then we could have simple clk tree.Peng Fan (4):
clk: imx: expose CCF entry for all
clk: imx: add pll14xx driver
clk: imx: add i.MX8M composite clk support
clk: imx: add i.MX8MM clk driverQuoted 10 lines
drivers/clk/Kconfig | 2 - drivers/clk/imx/Kconfig | 16 ++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-composite-8m.c | 170 +++++++++++++++ drivers/clk/imx/clk-imx8mm.c | 415 +++++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk-pll14xx.c | 381 ++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h | 25 +++ 7 files changed, 1009 insertions(+), 2 deletions(-) create mode 100644 drivers/clk/imx/clk-composite-8m.c create mode 100644 drivers/clk/imx/clk-imx8mm.c create mode100644
Quoted 2 lines
drivers/clk/imx/clk-pll14xx.cBest regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
Peng Fan
reviewerv4 cover Prepare i.MX8MM clk
Hi Lukasz
Quoted 22 lines
Subject: RE: [PATCH V4 0/4] Prepare i.MX8MM clk
Quoted 20 lines
Subject: Re: [PATCH V4 0/4] Prepare i.MX8MM clk
Hi Peng,
Quoted 5 lines
V4:
1/4: Expose CCF for all
2/4: Improve commit log
3/4: Typo fix
4/4: Drop unneeded initializationYour patches cause some build breaks on sandbox:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198639and TI:
https://travis-ci.org/lmajewski/u-boot-dfu/jobs/574198655The branch which I've used for testing (with your commits):
https://github.com/lmajewski/u-boot-dfu/commits/testingPlease fix above errors and resend your patches.
I just sent out new version patchset for enable_count
https://patchwork.ozlabs.org/patch/1150848/
This patchset is not changed.
CI: https://travis-ci.org/MrVan/u-boot/builds/574753709
Github: https://github.com/MrVan/u-boot/tree/ccf-8-24
Thanks,
Peng.
Quoted 59 lines
Sorry, I should run CI before posting patches. Will fix and send new version patches.
Thanks,
Peng.Quoted 24 lines
Quoted 24 lines
V3:
2/4: Fix RST/BYPASS seq issue to avoid glitch
4/4: ARM clk not use 24M for switch, usepll2_500mAdd R-b/A-b tag
Fix pll gate shift bit.V2:
2/4: fix MASK/SHIFT usageThis is to support i.MX8MM clk driver.
i.MX8MM use similar clock design as i.MX7D, but it has use different PLL, so we need to add pll14xx driver. And to simplify the clock usage, import the composite clk driver from Linux Kernel, then we could have simple clk tree.Peng Fan (4):
clk: imx: expose CCF entry for all
clk: imx: add pll14xx driver
clk: imx: add i.MX8M composite clk support
clk: imx: add i.MX8MM clk driverQuoted 6 lines
Quoted 6 lines
drivers/clk/Kconfig | 2 - drivers/clk/imx/Kconfig | 16 ++ drivers/clk/imx/Makefile | 2 + drivers/clk/imx/clk-composite-8m.c | 170 +++++++++++++++ drivers/clk/imx/clk-imx8mm.c | 415+++++++++++++++++++++++++++++++++++++
drivers/clk/imx/clk-pll14xx.cQuoted 10 lines
Quoted 4 lines
| 381 ++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h | 25 +++ 7 files changed, 1009 insertions(+), 2 deletions(-) create mode 100644 drivers/clk/imx/clk-composite-8m.c create mode 100644 drivers/clk/imx/clk-imx8mm.c create mode100644
Quoted 2 lines
drivers/clk/imx/clk-pll14xx.cQuoted 7 lines
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk
Quoted 3 lines
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de