Skip to contentSkip to conversation

CCIX Protocol error reporting.

PATCH Superseded Jonathan Cameron 2 participants 8 messages Aug 20, 2019 – Aug 27, 2019

Subsystems (6)
ACPI EFI EDAC-core ACPI APEI +2 more subsystems

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover CCIX Protocol error reporting.

Note this will clash with:
[PATCH RFC 0/4] ACPI: APEI: Add support to notify the vendor specific HW errors so a rebase will be needed.

Changes since V1:

Addressed comments from James Morse
- Dropped kernel logging of vendor data. We just push it to the tracepoints.
- Tidied up this cover letter and added information to address questions raised. Includes removing questions where James and I agreed ;)

Note, this initial series attempts no 'handling' of errors. That will follow later.

EFI 2.8 defines a new CPER record Appendix N for CCIX Protocol Error Records (PER). www.uefi.org

These include Protocol Error Record logs which are defined in the CCIX 1.0 Base Specification www.ccixconsortium.com. A public evaluation version is now available.

Handling of coherency protocol errors is complex and how Linux does this will take some time to evolve. For now, fatal errors are handled via the usual means and everything else is reported.

There are 6 types of error defined, covering:
* Memory errors
* Cache errors
* Address translation unit errors
* CCIX port errors
* CCIX link errors
* Agent internal errors.

These errors are concerned (mostly) wth things happening in the CCIX protocol layer. They are parallel to AER errors which should be only concerned with the PCIe layer (which is underneath CCIX). The ATS errors break this rule slightly. You may get an error occurring that results in problems at both layers of the protocol stack and hence have to handle AER and PER errors simultaneously.

Some of these errors can 'almost' be mapped onto standard existing error types but only at the loss of information specific to CCIX such as where in the topology they occurred.

The set includes tracepoints to report the errors to RAS Daemon and a patch set for RAS Daemon will follow shortly.

Several design decisions that people may disagree with.
1. Reporting of vendor data. We have little choice but to do this via a dynamic array as these blocks can take arbitrary size. I had hoped no one would actually use these given the odd mismatch between a standard error structure and non standard element, but there are already designs out there that do use it. James suggested that it made sense to put these in the tracepoints, but we shouldn't spam the kernel log with them (done in V2).
2. The trade off between explicit tracepoint fields, on which we might want to filter in kernel, and the simplicity of a blob.
I have gone for having the whole of the block specific to the PER error type in an opaque blob.
The key elements that may be filtered on are the physical address and the source and component fields which allow you to identify faulty devices. Note that you have to know how the devices were enumerated to be able to do so.
3. Defined 6 new tracepoints rather than cramming everything into one.
* They are all defined by the CCIX specification as independent error classes.
* Many of them can only be generated by particular types of agent.
* The handling required will vary widely depending on types. In the kernel some map cleanly onto existing handling. Keeping the whole flow separate will aide this. They vary by a similar amount in scope to the RAS errors found on an existing system which have independent tracepoints.
* Separating them out allows for filtering on the tracepoints by elements that are not shared between them.
* Muxing the lot into one record type can lead to ugly code both in kernel and in userspace.

Rasdaemon patches posted.
https://www.spinics.net/lists/linux-edac/msg10616.html

The following boilerplate is granting rights to the kernel. Note that I haven't applied the CCIX copyright notice anywhere in this series because we aren't quoting from the specification. That is much more likely to happen in documentation patches than in code.

Like anything else in this series it is open to comment.

This patch is being distributed by the CCIX Consortium, Inc. (CCIX) to you and other parties that are participating (the "participants") in the Linux kernel with the understanding that the participants will use CCIX's name and trademark only when this patch is used in association with the Linux kernel and associated user space.

CCIX is also distributing this patch to these participants with the understanding that if any portion of the CCIX specification will be used or referenced in the Linux kernel, the participants will not modify the cited portion of the CCIX specification and will give CCIX proper copyright attribution by including the following copyright notice with the cited part of the CCIX specification:
"© 2019 CCIX CONSORTIUM, INC. ALL RIGHTS RESERVED."

Jonathan Cameron (6):
efi / ras: CCIX Memory error reporting
efi / ras: CCIX Cache error reporting
efi / ras: CCIX Address Translation Cache error reporting efi / ras: CCIX Port error reporting
efi / ras: CCIX Link error reporting
efi / ras: CCIX Agent internal error reporting

 drivers/acpi/apei/Kconfig        |   8 +
 drivers/acpi/apei/ghes.c         |  59 +++
 drivers/firmware/efi/Kconfig     |   5 +
 drivers/firmware/efi/Makefile    |   1 +
 drivers/firmware/efi/cper-ccix.c | 817 +++++++++++++++++++++++++++++++
 drivers/firmware/efi/cper.c      |   6 +
 include/linux/cper.h             | 333 +++++++++++++
 include/ras/ras_event.h          | 405 +++++++++++++++
 8 files changed, 1634 insertions(+)
 create mode 100644 drivers/firmware/efi/cper-ccix.c
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/6 efi / ras: CCIX Memory error reporting

CCIX defines a number of different error types
(See CCIX spec 1.0) and UEFI 2.8 defines a CPER record to allow for them to be reported when firmware first handling is in use. The last part of that record is a copy of the CCIX protocol error record which can provide very detailed information.

This patch introduces infrastructure and support for one of those error types, CCIX Memory Errors. Later patches will supply equivalent support for the other error types.

The variable length and content of the different messages makes a single tracepoint impractical. As such the current RAS tracepoint only covers the memory error. Additional trace points will be introduced for other error types along with their cper handling in a follow up series.

RAS daemon posted. qemu injection patches also available but not currently planing to upstream those.

---
Changes since v1.
Drop printing of vendor data to kernel log.

 drivers/acpi/apei/Kconfig        |   8 +
 drivers/acpi/apei/ghes.c         |  39 ++++
 drivers/firmware/efi/Kconfig     |   5 +
 drivers/firmware/efi/Makefile    |   1 +
 drivers/firmware/efi/cper-ccix.c | 342 +++++++++++++++++++++++++++++++
 drivers/firmware/efi/cper.c      |   6 +
 include/linux/cper.h             | 118 +++++++++++
 include/ras/ras_event.h          |  77 +++++++
 8 files changed, 596 insertions(+)
drivers/acpi/apei/Kconfig +8 -0
index 6b18f8bc7be3..e687b18dee34 100644
@@ -68,3 +68,11 @@ config ACPI_APEI_ERST_DEBUG
 	  error information to and from a persistent store. Enable this
 	  if you want to debugging and testing the ERST kernel support
 	  and firmware implementation.
+
+config ACPI_APEI_CCIX
+       bool "APEI CCIX error recovery support"
+       depends on ACPI_APEI && MEMORY_FAILURE
+       help
+	 CCIX has a number of defined error types. This option enables
+	 the handling of CPER records generated by a firmware performing
+	 firmware first error handling of these CCIX errors.
drivers/acpi/apei/ghes.c +39 -0
index a66e00fe31fe..1ae36d836a77 100644
@@ -477,6 +477,42 @@ static void ghes_handle_aer(struct acpi_hest_generic_data *gdata)
 #endif
 }
 
+static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
+{
+#ifdef CONFIG_ACPI_APEI_CCIX
+	struct cper_sec_ccix_header *header = acpi_hest_get_payload(gdata);
+	__u32 *dw;
+	enum ccix_per_type per_type;
+	static u32 err_seq;
+	void *payload;
+
+	/* Check if space for CCIX CPER header and 8 DW of a PER log header */
+	if (gdata->error_data_length <
+	    sizeof(*header) + CCIX_PER_LOG_HEADER_DWS * sizeof(__u32))
+		return;
+
+	if ((header->validation_bits & CPER_CCIX_VALID_PER_LOG) == 0)
+		return;
+
+	dw = (__u32 *)(header + 1);
+
+	per_type = FIELD_GET(CCIX_PER_LOG_DW1_PER_TYPE_M, dw[1]);
+	payload = acpi_hest_get_payload(gdata);
+
+	switch (per_type) {
+	case CCIX_MEMORY_ERROR:
+		trace_ccix_memory_error_event(payload, err_seq, sev,
+					      ccix_mem_err_ven_len_get(payload));
+		break;
+	default:
+		/* Unknown error type */
+		pr_info("CCIX error of unknown or vendor defined type\n");
+		break;
+	}
+	err_seq++;
+#endif
+}
+
 static void ghes_do_proc(struct ghes *ghes,
 			 const struct acpi_hest_generic_status *estatus)
 {
@@ -507,6 +543,9 @@ static void ghes_do_proc(struct ghes *ghes,
 		else if (guid_equal(sec_type, &CPER_SEC_PCIE)) {
 			ghes_handle_aer(gdata);
 		}
+		else if (guid_equal(sec_type, &CPER_SEC_CCIX)) {
+			ghes_handle_ccix_per(gdata, estatus->error_severity);
+		}
 		else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
 			struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata);
 
drivers/firmware/efi/Kconfig +5 -0
index d4ea929e8b34..9ea161f68da8 100644
@@ -195,6 +195,11 @@ config UEFI_CPER_X86
 	depends on UEFI_CPER && X86
 	default y
 
+config UEFI_CPER_CCIX
+       bool
+       depends on UEFI_CPER
+       default y
+
 config EFI_DEV_PATH_PARSER
 	bool
 	depends on ACPI
drivers/firmware/efi/Makefile +1 -0
index d2d0d2030620..69287da9664b 100644
@@ -33,3 +33,4 @@ obj-$(CONFIG_EFI_CAPSULE_LOADER)	+= capsule-loader.o
 obj-$(CONFIG_EFI_EARLYCON)		+= earlycon.o
 obj-$(CONFIG_UEFI_CPER_ARM)		+= cper-arm.o
 obj-$(CONFIG_UEFI_CPER_X86)		+= cper-x86.o
+obj-$(CONFIG_UEFI_CPER_CCIX)		+= cper-ccix.o
drivers/firmware/efi/cper-ccix.c new file +342 -0

342 lines not on this page · raw message

drivers/firmware/efi/cper.c +6 -0
index 8fa977c7861f..52f0954a4577 100644
@@ -459,6 +459,12 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
 			cper_print_pcie(newpfx, pcie, gdata);
 		else
 			goto err_section_too_small;
+	} else if (guid_equal(sec_type, &CPER_SEC_CCIX)) {
+		int ret;
+		/* CCIX CPER entries are variable length */
+		ret = cper_print_ccix_per(newpfx, gdata);
+		if (ret)
+			goto err_section_too_small;
 #if defined(CONFIG_ARM64) || defined(CONFIG_ARM)
 	} else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
 		struct cper_sec_proc_arm *arm_err = acpi_hest_get_payload(gdata);
include/linux/cper.h +118 -0

142 lines not on this page · raw message

include/ras/ras_event.h +77 -0

89 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 2/6 efi / ras: CCIX Cache error reporting

In reply to Jonathan Cameron

As CCIX Request Agents have fully cache coherent caches, the CCIX 1.0 Base Specification defines detailed error reporting for these caches.

A CCIX cache error is reported via a CPER record as defined in the UEFI 2.8 specification. The PER log section is defined in the CCIX 1.0 Base Specification.

---
Changes since v1.
Drop printing of vendor data to kernel log.

 drivers/acpi/apei/ghes.c         |   4 +
 drivers/firmware/efi/cper-ccix.c | 156 +++++++++++++++++++++++++++++++
 include/linux/cper.h             |  57 +++++++++++
 include/ras/ras_event.h          |  66 +++++++++++++
 4 files changed, 283 insertions(+)
drivers/acpi/apei/ghes.c +4 -0
index 1ae36d836a77..5bda94e48b1b 100644
@@ -504,6 +504,10 @@ static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
 		trace_ccix_memory_error_event(payload, err_seq, sev,
 					      ccix_mem_err_ven_len_get(payload));
 		break;
+	case CCIX_CACHE_ERROR:
+		trace_ccix_cache_error_event(payload, err_seq, sev,
+					     ccix_cache_err_ven_len_get(payload));
+		break;
 	default:
 		/* Unknown error type */
 		pr_info("CCIX error of unknown or vendor defined type\n");
drivers/firmware/efi/cper-ccix.c +156 -0

171 lines not on this page · raw message

include/linux/cper.h +57 -0

69 lines not on this page · raw message

include/ras/ras_event.h +66 -0

72 lines not on this page · raw message

Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 3/6 efi / ras: CCIX Address Translation Cache error reporting

In reply to Jonathan Cameron

CCIX devices tend to make heavy use of ATCs. The CCIX base specification defines a protocol error message (PER) that describes errors reported by such caches. The UEFI 2.8 specification includes a CCIX CPER record for firmware first handling to report these errors to the operating system.

This patch is very similar to the support previously added for CCIX Memory Errors and provides both logging and RAS tracepoint for this error class.

---
Changes since v1.
Drop printing of vendor data to kernel log.

 drivers/acpi/apei/ghes.c         |  4 ++
 drivers/firmware/efi/cper-ccix.c | 72 ++++++++++++++++++++++++++++++++
 include/linux/cper.h             | 39 +++++++++++++++++
 include/ras/ras_event.h          | 67 +++++++++++++++++++++++++++++
 4 files changed, 182 insertions(+)
drivers/acpi/apei/ghes.c +4 -0
index 5bda94e48b1b..a2ae9311ffee 100644
@@ -508,6 +508,10 @@ static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
 		trace_ccix_cache_error_event(payload, err_seq, sev,
 					     ccix_cache_err_ven_len_get(payload));
 		break;
+	case CCIX_ATC_ERROR:
+		trace_ccix_atc_error_event(payload, err_seq, sev,
+					   ccix_atc_err_ven_len_get(payload));
+		break;
 	default:
 		/* Unknown error type */
 		pr_info("CCIX error of unknown or vendor defined type\n");
drivers/firmware/efi/cper-ccix.c +72 -0

87 lines not on this page · raw message

include/linux/cper.h +39 -0
index eef254b8b8b7..6bb603e9a97a 100644
@@ -675,6 +675,38 @@ struct cper_ccix_cache_err_compact {
 	__u8	instance;
 };
 
+struct cper_sec_ccix_atc_error {
+	__u32	validation_bits;
+#define CCIX_ATC_ERR_OP_VALID			BIT(0)
+#define CCIX_ATC_ERR_INSTANCE_ID_VALID		BIT(1)
+#define CCIX_ATC_ERR_VENDOR_DATA_VALID		BIT(2)
+	__u16	length; /* Includes vendor specific log info */
+	__u8	op_type;
+	__u8	instance;
+	__u32	reserved;
+	__u32	vendor_data[];
+};
+
+struct cper_ccix_atc_error {
+	struct cper_sec_ccix_header header;
+	__u32 ccix_header[CCIX_PER_LOG_HEADER_DWS];
+	struct cper_sec_ccix_atc_error atc_record;
+};
+
+static inline u16 ccix_atc_err_ven_len_get(struct cper_ccix_atc_error *atc_err)
+{
+	if (atc_err->atc_record.validation_bits & CCIX_ATC_ERR_VENDOR_DATA_VALID)
+		return atc_err->atc_record.vendor_data[0] & 0xFFFF;
+	else
+		return 0;
+}
+
+struct cper_ccix_atc_err_compact {
+	__u32	validation_bits;
+	__u8	op_type;
+	__u8	instance;
+};
+
 /* Reset to default packing */
 #pragma pack()
 
@@ -706,6 +738,13 @@ const char *cper_ccix_cache_err_unpack(struct trace_seq *p,
 				       struct cper_ccix_cache_err_compact *ccache_err);
 const char *cper_ccix_cache_err_type_str(__u8 error_type);
 
+void cper_ccix_atc_err_pack(const struct cper_sec_ccix_atc_error *atc_record,
+			    struct cper_ccix_atc_err_compact *catc_err,
+			    const u16 vendor_data_len,
+			    u8 *vendor_data);
+const char *cper_ccix_atc_err_unpack(struct trace_seq *p,
+				     struct cper_ccix_atc_err_compact *catc_err);
+
 struct acpi_hest_generic_data;
 int cper_print_ccix_per(const char *pfx,
 			struct acpi_hest_generic_data *gdata);
include/ras/ras_event.h +67 -0

73 lines not on this page · raw message

Signature · 1 line
2.20.1
#4 lore raw

PATCH v2 4/6 efi / ras: CCIX Port error reporting

In reply to Jonathan Cameron

The CCIX 1.0 base specification defines a CCIX protocol layer port. The specification provides a mechanism for detailed error logging for these ports. The UEFI 2.8 specification includes a CCIX CPER record for firmware first handling to report these errors to the operating system.

This patch is very similar to the support previously added for for CCIX Memory Errors and provides both logging and RAS tracepoint for this error class.

---
Changes since v1.
Drop printing of vendor data to kernel log.

drivers/acpi/apei/ghes.c | 4 ++

 drivers/firmware/efi/cper-ccix.c | 110 +++++++++++++++++++++++++++++++
 include/linux/cper.h             |  42 ++++++++++++
 include/ras/ras_event.h          |  66 +++++++++++++++++++
 4 files changed, 222 insertions(+)
drivers/acpi/apei/ghes.c +4 -0
index a2ae9311ffee..42b7d47c3454 100644
@@ -512,6 +512,10 @@ static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
 		trace_ccix_atc_error_event(payload, err_seq, sev,
 					   ccix_atc_err_ven_len_get(payload));
 		break;
+	case CCIX_PORT_ERROR:
+		trace_ccix_port_error_event(payload, err_seq, sev,
+					    ccix_port_err_ven_len_get(payload));
+		break;
 	default:
 		/* Unknown error type */
 		pr_info("CCIX error of unknown or vendor defined type\n");
drivers/firmware/efi/cper-ccix.c +110 -0

125 lines not on this page · raw message

include/linux/cper.h +42 -0

54 lines not on this page · raw message

include/ras/ras_event.h +66 -0

72 lines not on this page · raw message

Signature · 1 line
2.20.1
#5 lore raw

PATCH v2 5/6 efi / ras: CCIX Link error reporting

In reply to Jonathan Cameron

The CCIX 1.0 Base Specification defines a protocol layer CCIX link and related error reporting mechanism. The UEFI 2.8 specification includes a CCIX CPER record for firmware first handling to report these errors to the operating system.

This patch is very similar to the support previously added for CCIX Memory Errors and provides both logging and RAS tracepoint for this error class.

---
Changes since v1.
Drop printing of vendor data to kernel log.

 drivers/acpi/apei/ghes.c         |   4 +
 drivers/firmware/efi/cper-ccix.c | 125 +++++++++++++++++++++++++++++++
 include/linux/cper.h             |  48 ++++++++++++
 include/ras/ras_event.h          |  65 ++++++++++++++++
 4 files changed, 242 insertions(+)
drivers/acpi/apei/ghes.c +4 -0
index 42b7d47c3454..3cdca0c0f4ae 100644
@@ -516,6 +516,10 @@ static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
 		trace_ccix_port_error_event(payload, err_seq, sev,
 					    ccix_port_err_ven_len_get(payload));
 		break;
+	case CCIX_LINK_ERROR:
+		trace_ccix_link_error_event(payload, err_seq, sev,
+					    ccix_link_err_ven_len_get(payload));
+		break;
 	default:
 		/* Unknown error type */
 		pr_info("CCIX error of unknown or vendor defined type\n");
drivers/firmware/efi/cper-ccix.c +125 -0

140 lines not on this page · raw message

include/linux/cper.h +48 -0

60 lines not on this page · raw message

include/ras/ras_event.h +65 -0

71 lines not on this page · raw message

Signature · 1 line
2.20.1
#6 lore raw

PATCH v2 6/6 efi / ras: CCIX Agent internal error reporting

In reply to Jonathan Cameron

The CCIX 1.0 Base specification defines an internal agent error, for which the specific data present afte the header is vendor defined.

---
Changes since v1.
Drop printing of vendor data to kernel log.

 drivers/acpi/apei/ghes.c         |  4 ++
 drivers/firmware/efi/cper-ccix.c | 12 ++++++
 include/linux/cper.h             | 29 +++++++++++++++
 include/ras/ras_event.h          | 64 ++++++++++++++++++++++++++++++++
 4 files changed, 109 insertions(+)
drivers/acpi/apei/ghes.c +4 -0
index 3cdca0c0f4ae..f7b3c4777df3 100644
@@ -520,6 +520,10 @@ static void ghes_handle_ccix_per(struct acpi_hest_generic_data *gdata, int sev)
 		trace_ccix_link_error_event(payload, err_seq, sev,
 					    ccix_link_err_ven_len_get(payload));
 		break;
+	case CCIX_AGENT_INTERNAL_ERROR:
+		trace_ccix_agent_error_event(payload, err_seq, sev,
+					     ccix_agent_err_ven_len_get(payload));
+		break;
 	default:
 		/* Unknown error type */
 		pr_info("CCIX error of unknown or vendor defined type\n");
drivers/firmware/efi/cper-ccix.c +12 -0
index 5820a58ec382..b2ad55291dc4 100644
@@ -584,6 +584,9 @@ int cper_print_ccix_per(const char *pfx, struct acpi_hest_generic_data *gdata)
 		return cper_ccix_port_err_details(pfx, gdata);
 	case CCIX_LINK_ERROR:
 		return cper_ccix_link_err_details(pfx, gdata);
+	case CCIX_AGENT_INTERNAL_ERROR:
+		/* Agent errors contain only vendor data, so nothing to do here */
+		return 0;
 	default:
 		/* Vendor defined so no formatting be done */
 		break;
@@ -803,3 +806,12 @@ const char *cper_ccix_link_err_unpack(struct trace_seq *p,
 
 	return ret;
 }
+
+void cper_ccix_agent_err_pack(const struct cper_sec_ccix_agent_err *agent_record,
+			      struct cper_ccix_agent_err_compact *cagent_err,
+			      const u16 vendor_data_len,
+			      u8 *vendor_data)
+{
+	cagent_err->validation_bits = agent_record->validation_bits;
+	memcpy(vendor_data, &agent_record->vendor_data[1], vendor_data_len);
+}
include/linux/cper.h +29 -0
index d35be55351e3..373c1d387a70 100644
@@ -783,6 +783,30 @@ struct cper_ccix_link_err_compact {
 	__u8	credit_type;
 };
 
+struct cper_sec_ccix_agent_err {
+	__u32	validation_bits;
+#define CCIX_AGENT_INTERNAL_ERR_VENDOR_DATA_VALID	BIT(0)
+	__u32	vendor_data[];
+};
+
+struct cper_ccix_agent_err {
+	struct cper_sec_ccix_header header;
+	__u32 ccix_header[CCIX_PER_LOG_HEADER_DWS];
+	struct cper_sec_ccix_agent_err agent_record;
+};
+
+static inline u16 ccix_agent_err_ven_len_get(struct cper_ccix_agent_err *agent_err)
+{
+	if (agent_err->agent_record.validation_bits & CCIX_AGENT_INTERNAL_ERR_VENDOR_DATA_VALID)
+		return agent_err->agent_record.vendor_data[0] & 0xFFFF;
+	else
+		return 0;
+}
+
+struct cper_ccix_agent_err_compact {
+	__u32	validation_bits;
+};
+
 /* Reset to default packing */
 #pragma pack()
 
@@ -835,6 +859,11 @@ void cper_ccix_link_err_pack(const struct cper_sec_ccix_link_error *link_record,
 const char *cper_ccix_link_err_unpack(struct trace_seq *p,
 				      struct cper_ccix_link_err_compact *clink_err);
 
+void cper_ccix_agent_err_pack(const struct cper_sec_ccix_agent_err *agent_record,
+			      struct cper_ccix_agent_err_compact *cagent_err,
+			      const u16 vendor_data_len,
+			      u8 *vendor_data);
+
 struct acpi_hest_generic_data;
 int cper_print_ccix_per(const char *pfx,
 			struct acpi_hest_generic_data *gdata);
include/ras/ras_event.h +64 -0

70 lines not on this page · raw message

Signature · 1 line
2.20.1
#7 lore raw
In reply to Jonathan Cameron

Jonathan,

On Tue, 20 Aug 2019, Jonathan Cameron wrote:

Cc+ [email protected]

Quoted 5 lines

The following boilerplate is granting rights to the kernel. Note that I haven't applied the CCIX copyright notice anywhere in this series because we aren't quoting from the specification. That is much more likely to happen in documentation patches than in code.

Quoted 7 lines

Like anything else in this series it is open to comment.

This patch is being distributed by the CCIX Consortium, Inc. (CCIX) to you and other parties that are participating (the "participants") in the Linux kernel with the understanding that the participants will use CCIX's name and trademark only when this patch is used in association with the Linux kernel and associated user space.

The code is licensed under GPLV2, so what precludes any other GPLV2 project to import that code?

If there is a mentioning of CCIX Consortium in the imported code then you cannot impose that this needs to be removed because it ends up in something which is neither Linux kernel nor associated user space. And that's especially true when this ends up being a copyright notice.

Quoted 7 lines

CCIX is also distributing this patch to these participants with the understanding that if any portion of the CCIX specification will be used or referenced in the Linux kernel, the participants will not modify the cited portion of the CCIX specification and will give CCIX proper copyright attribution by including the following copyright notice with the cited part of the CCIX specification:
"© 2019 CCIX CONSORTIUM, INC. ALL RIGHTS RESERVED."

Just to prove the point.

Thanks,

tglx