Skip to contentSkip to conversation

arm64: perf_event: Add missing header needed for smp_processor_id()

PATCH In review Raphael Gault 3 participants 3 messages Aug 20, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: perf_event: Add missing header needed for smp_processor_id()

---
 arch/arm64/kernel/perf_event.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/kernel/perf_event.c +1 -0
index 96e90e270042..24575c0a0065 100644
@@ -19,6 +19,7 @@
 #include <linux/of.h>
 #include <linux/perf/arm_pmu.h>
 #include <linux/platform_device.h>
+#include <linux/smp.h>
 
 /* ARMv8 Cortex-A53 specific event types. */
 #define ARMV8_A53_PERFCTR_PREF_LINEFILL				0xC2
Signature · 1 line
2.17.1
maintainer
#1 lore raw

On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote:

It would be worth having a body for the commit message like:

| in perf_event.c we use smp_processor_id(), but we haven't included 
| <linux/smp.h> where it is defined, and rely on this being pulled in 
| via a transitive include. Let's make this more robust by including
| <linux.smp.h> explciitly.

... and with that, my Acked-by stands.

Thanks,
Mark.

Quoted 21 lines
---
 arch/arm64/kernel/perf_event.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/kernel/perf_event.c +1 -0
index 96e90e270042..24575c0a0065 100644
@@ -19,6 +19,7 @@
 #include <linux/of.h>
 #include <linux/perf/arm_pmu.h>
 #include <linux/platform_device.h>
+#include <linux/smp.h>
 
 /* ARMv8 Cortex-A53 specific event types. */
 #define ARMV8_A53_PERFCTR_PREF_LINEFILL				0xC2
Signature · 1 line
2.17.1
maintainer
#2 lore raw
Quoted 10 lines · Mark Rutland

On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote:

It would be worth having a body for the commit message like:

| in perf_event.c we use smp_processor_id(), but we haven't included 
| <linux/smp.h> where it is defined, and rely on this being pulled in 
| via a transitive include. Let's make this more robust by including
| <linux.smp.h> explciitly.

... and with that, my Acked-by stands.

Queued for 5.4. with typo fixed above.

Will