Skip to contentSkip to conversation

sdkext: use simpler kernel module for devtool test

PATCH Superseded Mark Asselstine 2 participants 3 messages Aug 20, 2019 – Aug 21, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sdkext: use simpler kernel module for devtool test

The current devtool test for the building of an out-of-tree kernel module uses something which requires several "high order" kconfigs to be set. This results in the test failing, not for expected reasons, but rather because it depends on specific kernel configuration.

You will get error messages such as

ERROR: "video_ioctl2" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko] undefined!
ERROR: "video_unregister_device" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-driver/v4l2loopback.ko] undefined!

Using a simpler hello-world kernel module example will only require that CONFIG_MODULE is enabled, thus avoiding a false positive.

---

Richard, it is unclear if I need to match this change in meta/lib/oeqa/manual/crops.json. Please let me know and I send a V2 which does this. I am not fond of pointing at my own github but it was the best option to ensure it will exist and not be messed with.

 meta/lib/oeqa/sdkext/cases/devtool.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/lib/oeqa/sdkext/cases/devtool.py +2 -2
index 5a02add764..fad98fbb36 100644
@@ -73,8 +73,8 @@ class DevtoolTest(OESDKExtTestCase):
             self._run('devtool reset %s' % recipe)
 
     def test_devtool_kernelmodule(self):
-        docfile = 'https://github.com/umlaeute/v4l2loopback.git'
-        recipe = 'v4l2loopback-driver'
+        docfile = 'https://github.com/masselstine/kernel-module-hello-world.git'
+        recipe = 'kernel-module-hello-world'
         self._run('devtool add %s %s' % (recipe, docfile) )
         try:
             self._run('devtool build %s' % recipe)
Signature · 1 line
2.21.0
#1 lore raw
Quoted 16 lines · Mark Asselstine

The current devtool test for the building of an out-of-tree kernel module uses something which requires several "high order" kconfigs to be set. This results in the test failing, not for expected reasons, but rather because it depends on specific kernel configuration.

You will get error messages such as

ERROR: "video_ioctl2" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
driver/v4l2loopback.ko]
undefined!
ERROR: "video_unregister_device" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-
driver/v4l2loopback.ko]
undefined!

Quoted 8 lines

Using a simpler hello-world kernel module example will only require that CONFIG_MODULE is enabled, thus avoiding a false positive.

---

Richard, it is unclear if I need to match this change in meta/lib/oeqa/manual/crops.json.

Those are manual tests for crops. They probably do also need this change as it would make them more reliable if/as anyone every automates them, or runs them manually.

Quoted 4 lines

Please let me know and I
send a V2 which does this. I am not fond of pointing at my own github but it was the best option to ensure it will exist and not be messed with.

The best option may be to put that repo onto git.yoctoproject.org?

Cheers,

Richard

#2 lore raw
Quoted 27 lines · On Wednesday, August 21, 2019 4:57:40 P.M. EDT Richard Purdie wrote:
Quoted 26 lines · Mark Asselstine

The current devtool test for the building of an out-of-tree kernel module uses something which requires several "high order" kconfigs to be set. This results in the test failing, not for expected reasons, but rather because it depends on specific kernel configuration.

You will get error messages such as

ERROR: "video_ioctl2" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-

driver/v4l2loopback.ko]

undefined!
ERROR: "video_unregister_device" [.../1.0-r5/testsdkext/workspace/sources/v4l2loopback-

driver/v4l2loopback.ko]

undefined!

Using a simpler hello-world kernel module example will only require that CONFIG_MODULE is enabled, thus avoiding a false positive.

---

Quoted 6 lines
Quoted 2 lines

Richard, it is unclear if I need to match this change in meta/lib/oeqa/manual/crops.json.

Those are manual tests for crops. They probably do also need this change as it would make them more reliable if/as anyone every automates them, or runs them manually.

I will affect the change there then too in the V2.

Quoted 8 lines
Quoted 6 lines

Please let me know and I

send a V2 which does this. I am not fond of pointing at my own github but it was the best option to ensure it will exist and not be messed with.

The best option may be to put that repo onto git.yoctoproject.org?

Not sure I get a vote but as far as the content goes I have no issue with it being elsewhere, like git.yoctoproject.org.

Mark

Quoted 4 lines

Cheers,

Richard