Skip to contentSkip to conversation

ocelot_ace: fix action of trap

PATCH Applied Yangbo Lu 2 participants 2 messages Aug 21, 2019 – Aug 22, 2019

Subsystems (3)
lore
Share & tools
lore

Yangbo Lu

author
#0 lore raw

PATCH v4 1/1 ocelot_ace: fix action of trap

The trap action should be copying the frame to CPU and dropping it for forwarding, but current setting was just copying frame to CPU.

Fixes b596229448dd ("net: mscc: ocelot: Add support for tcam")

---
Changes for v4:
- Added ACK and Fixes info in commit message.
Changes for v3:
- Set MASK_MODE to 1 for dropping forwarding.
- Dropped other patches of patch-set.
Changes for v2:
- None.

---
 drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mscc/ocelot_ace.c +1 -1
index 39aca1a..86fc6e6 100644
@@ -317,7 +317,7 @@ static void is2_action_set(struct vcap_data *data,
 		break;
 	case OCELOT_ACL_ACTION_TRAP:
 		VCAP_ACT_SET(PORT_MASK, 0x0);
-		VCAP_ACT_SET(MASK_MODE, 0x0);
+		VCAP_ACT_SET(MASK_MODE, 0x1);
 		VCAP_ACT_SET(POLICE_ENA, 0x0);
 		VCAP_ACT_SET(POLICE_IDX, 0x0);
 		VCAP_ACT_SET(CPU_QU_NUM, 0x0);
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: Yangbo Lu <[email protected]>
Date: Wed, 21 Aug 2019 09:59:12 +0800

Quoted 7 lines

The trap action should be copying the frame to CPU and dropping it for forwarding, but current setting was just copying frame to CPU.

Fixes b596229448dd ("net: mscc: ocelot: Add support for tcam")
Quoted 8 lines

---
Changes for v4:
- Added ACK and Fixes info in commit message.
Changes for v3:
- Set MASK_MODE to 1 for dropping forwarding.
- Dropped other patches of patch-set.
Changes for v2:
- None.

Applied.