Skip to contentSkip to conversation

ASoC: sun4i-i2s: incorrect regmap for A83t

PATCH In review [email protected] 3 participants 4 messages Aug 21, 2019 – Sep 2, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: sun4i-i2s: incorrect regmap for A83t

From: Marcus Cooper <[email protected]>

Fixes 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")
---
 sound/soc/sunxi/sun4i-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sunxi/sun4i-i2s.c +1 -1
index cbc6e59aa089..056a299c03fb 100644
@@ -1109,7 +1109,7 @@ static const struct sun4i_i2s_quirks sun6i_a31_i2s_quirks = {
 static const struct sun4i_i2s_quirks sun8i_a83t_i2s_quirks = {
 	.has_reset		= true,
 	.reg_offset_txdata	= SUN8I_I2S_FIFO_TX_REG,
-	.sun4i_i2s_regmap	= &sun4i_i2s_regmap_config,
+	.sun4i_i2s_regmap	= &sun8i_i2s_regmap_config,
 	.field_clkdiv_mclk_en	= REG_FIELD(SUN4I_I2S_CLK_DIV_REG, 8, 8),
 	.field_fmt_wss		= REG_FIELD(SUN4I_I2S_FMT0_REG, 0, 2),
 	.field_fmt_sr		= REG_FIELD(SUN4I_I2S_FMT0_REG, 4, 6),
Signature · 1 line
2.23.0
#1 lore raw

Hi Markus,

Quoted 4 lines · On Wed, Aug 21, 2019 at 06:23:20PM +0200, [email protected] wrote:

From: Marcus Cooper <[email protected]>

Fixes 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")

The patch is ok, but you should have a commit log here.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 9 lines · Mark Brown
Quoted 5 lines · On Wed, Aug 21, 2019 at 06:23:20PM +0200, [email protected] wrote:

From: Marcus Cooper <[email protected]>

Fixes 21faaea1343f ("ASoC: sun4i-i2s: Add support for A83T")

---

This doesn't apply against current code, please check and resend.

This patch is no longer valid and the fix has been done through the reverts, BR,
CK