Skip to contentSkip to conversation

media: rc: increase rc-mm tolerance and add debug message

PATCH New Sean Young 1 participant 1 message Aug 23, 2019

Subsystems (3)
lore
Share & tools
lore

Sean Young

author maintainer
#0 lore raw

PATCH 1/1 media: rc: increase rc-mm tolerance and add debug message

Decoding often fails on e.g. redrat3 devices. The dev_dbg() helps with debugging when decoding does fail.

Cc Patrick Lerda <[email protected]>
---
 drivers/media/rc/ir-rcmm-decoder.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/media/rc/ir-rcmm-decoder.c +4 -2
index 64fb65a9a19f..028df5cb1828 100644
@@ -79,7 +79,7 @@ static int ir_rcmm_decode(struct rc_dev *dev, struct ir_raw_event ev)
 		if (!ev.pulse)
 			break;
 
-		if (!eq_margin(ev.duration, RCMM_PREFIX_PULSE, RCMM_UNIT / 2))
+		if (!eq_margin(ev.duration, RCMM_PREFIX_PULSE, RCMM_UNIT))
 			break;
 
 		data->state = STATE_LOW;
@@ -91,7 +91,7 @@ static int ir_rcmm_decode(struct rc_dev *dev, struct ir_raw_event ev)
 		if (ev.pulse)
 			break;
 
-		if (!eq_margin(ev.duration, RCMM_PULSE_0, RCMM_UNIT / 2))
+		if (!eq_margin(ev.duration, RCMM_PULSE_0, RCMM_UNIT))
 			break;
 
 		data->state = STATE_BUMP;
@@ -164,6 +164,8 @@ static int ir_rcmm_decode(struct rc_dev *dev, struct ir_raw_event ev)
 		break;
 	}
 
+	dev_dbg(&dev->dev, "RC-MM decode failed at count %d state %d (%uus %s)\n",
+		data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse));
 	data->state = STATE_INACTIVE;
 	return -EINVAL;
 }
Signature · 1 line
2.21.0