spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*
Subsystems (7)
v2 cover spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*
This patch series introduces new SPL and TPL specific Kconfig entries for DM_SPI* options. Such change allows using the spi driver in SPL/TPL or U-Boot proper.
First two patches - related to ls10{42}* NXP soc fix some issues with defining the DM_SPI* defines in <board>.h file instead of Kconfig.
This series doesn't introduce build breaks, but board maintainers are kindly asked to check if their boards still boots.
Changes in v2:
- Resend patches with some not yet in mainline code removed as suggested by Adam Ford
Lukasz Majewski (4):
kconfig: doc: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL
spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a)
spi: Move DM_SPI_FLASH and SPI_FLASH_DATAFLASH to Kconfig (for
ls1021aXXX)
spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
arch/arm/Kconfig | 23 +++++++++++++++++++++-- board/l+g/vinco/vinco.c | 4 ++-- cmd/sf.c | 4 ++-- cmd/spi.c | 6 +++--- common/spl/Kconfig | 28 ++++++++++++++++++++++++++++ configs/am57xx_evm_defconfig | 2 ++ configs/am57xx_hs_evm_defconfig | 2 ++ configs/am57xx_hs_evm_usb_defconfig | 2 ++ configs/axm_defconfig | 2 ++ configs/chromebook_link64_defconfig | 2 ++ configs/chromebook_samus_tpl_defconfig | 4 ++++ configs/dra7xx_evm_defconfig | 2 ++ configs/dra7xx_hs_evm_defconfig | 2 ++ configs/dra7xx_hs_evm_usb_defconfig | 2 ++ configs/j721e_evm_a72_defconfig | 2 ++ configs/j721e_evm_r5_defconfig | 2 ++ configs/ls1021aiot_qspi_defconfig | 2 ++ configs/ls1021aiot_sdcard_defconfig | 2 ++ configs/ls1021aqds_qspi_defconfig | 1 + configs/ls1021aqds_sdcard_qspi_defconfig | 1 + configs/ls1021atwr_qspi_defconfig | 1 + configs/sama5d2_xplained_spiflash_defconfig | 2 ++ configs/sama5d3xek_spiflash_defconfig | 7 ++++--- configs/sama5d4_xplained_spiflash_defconfig | 2 ++ configs/sama5d4ek_spiflash_defconfig | 2 ++ configs/stm32mp15_basic_defconfig | 2 ++ configs/taurus_defconfig | 2 ++ drivers/mtd/spi/Makefile | 4 ++-- drivers/mtd/spi/sf_probe.c | 8 ++++---- drivers/net/fm/fm.c | 4 ++-- drivers/spi/Makefile | 2 +- drivers/spi/atmel_spi.c | 4 ++-- drivers/spi/davinci_spi.c | 6 +++--- drivers/spi/fsl_dspi.c | 5 +++-- drivers/spi/kirkwood_spi.c | 2 +- drivers/spi/mxc_spi.c | 6 +++--- drivers/spi/omap3_spi.c | 4 ++-- drivers/spi/sh_qspi.c | 4 ++-- env/sf.c | 2 +- include/configs/ls1021aiot.h | 6 ------ include/configs/ls1021aqds.h | 8 -------- include/configs/ls1021atwr.h | 5 ----- include/configs/ls1043a_common.h | 2 -- include/linux/kconfig.h | 2 ++ include/spi.h | 8 ++++---- include/spi_flash.h | 2 +- test/dm/spi.c | 2 +- 47 files changed, 135 insertions(+), 64 deletions(-)
Signature · 1 line
2.11.0
PATCH v2 1/4 kconfig: doc: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL
This patch adds some commit info for CONFIG_IS_ENABLED(FOO) when used in TPL context.
---
Changes in v2: None
include/linux/kconfig.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/kconfig.h +2 -0
@@ -75,6 +75,7 @@* CONFIG_VAL(FOO) evaluates to the value of * CONFIG_FOO if CONFIG_SPL_BUILD is undefined, * CONFIG_SPL_FOO if CONFIG_SPL_BUILD is defined. +* CONFIG_TPL_FOO if CONFIG_TPL_BUILD is defined. */ #define CONFIG_VAL (option) config_val(option)
@@ -82,6 +83,7 @@* CONFIG_IS_ENABLED(FOO) evaluates to * 1 if CONFIG_SPL_BUILD is undefined and CONFIG_FOO is set to 'y' or 'm', * 1 if CONFIG_SPL_BUILD is defined and CONFIG_SPL_FOO is set to 'y' or 'm', +* 1 if CONFIG_TPL_BUILD is defined and CONFIG_TPL_FOO is set to 'y' or 'm', * 0 otherwise. */ #define CONFIG_IS_ENABLED (option) \
Signature · 1 line
2.11.0
PATCH v2 2/4 spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a)
In reply to Lukasz MajewskiThis patch fixes issue with defining the DM_SPI_FLASH in the configs/include/<board.h> instead of enabling this option in Kconfig.
The problem is that CONFIG_IS_ENABLED(DM_SPI_FLASH) shows false as there is no DM_SPI_FLASH=y in .config (but the define is set in u-boot.cfg).
As a result conversion of DM_SPI_FLASH to using CONFIG_IS_ENABLED() is not working properly.
---
Changes in v2: None
arch/arm/Kconfig | 4 ++++ include/configs/ls1043a_common.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/Kconfig +4 -0
@@ -1395,6 +1395,8 @@ config TARGET_LS1043AQDS select BOARD_LATE_INIT select SUPPORT_SPL select FSL_DDR_INTERACTIVE if !SPL + select FSL_DSPI if !SPL + select DM_SPI_FLASH if FSL_DSPI imply SCSI imply SCSI_AHCI help
@@ -1409,6 +1411,8 @@ config TARGET_LS1043ARDB select BOARD_EARLY_INIT_F select BOARD_LATE_INIT select SUPPORT_SPL + select FSL_DSPI if !SPL + select DM_SPI_FLASH if FSL_DSPI help Support for Freescale LS1043ARDB platform.
include/configs/ls1043a_common.h +0 -2
@@ -165,9 +165,7 @@/* DSPI */ #ifndef SPL_NO_DSPI -#define CONFIG_FSL_DSPI #ifdef CONFIG_FSL_DSPI -#define CONFIG_DM_SPI_FLASH #define CONFIG_SPI_FLASH_STMICRO /* cs0 */ #define CONFIG_SPI_FLASH_SST /* cs1 */ #define CONFIG_SPI_FLASH_EON /* cs2 */
Signature · 1 line
2.11.0
PATCH v2 3/4 spi: Move DM_SPI_FLASH and SPI_FLASH_DATAFLASH to Kconfig (for ls1021aXXX)
In reply to Lukasz MajewskiThis patch moves the CONFIG_DM_SPI_FLASH and CONFIG_SPI_FLASH_DATAFLASH to be defined in Kconfig, not in board specific header file (include/configs/<board>.h).
Before this change the CONFIG_DM_SPI_FLASH was not set in .config (so it was not possible to use CONFIG_IS_ENABLED(DM_SPI_FLASH) in SPI DM/DTS converted drivers), but it was set in u-boot.cfg file.
---
Changes in v2: None
arch/arm/Kconfig | 6 ++++-- include/configs/ls1021aiot.h | 6 ------ include/configs/ls1021aqds.h | 8 -------- include/configs/ls1021atwr.h | 5 ----- 4 files changed, 4 insertions(+), 21 deletions(-)
arch/arm/Kconfig +4 -2
@@ -1341,6 +1341,8 @@ config TARGET_LS1021AQDS select SUPPORT_SPL select SYS_FSL_DDR select FSL_DDR_INTERACTIVE + select DM_SPI_FLASH if FSL_DSPI || FSL_QSPI + select SPI_FLASH_DATAFLASH if FSL_DSPI || FSL_QSPI imply SCSI config TARGET_LS1021ATWR
@@ -1354,6 +1356,7 @@ config TARGET_LS1021ATWR select CPU_V7_HAS_VIRT select LS1_DEEP_SLEEP select SUPPORT_SPL + select DM_SPI_FLASH if FSL_DSPI || FSL_QSPI imply SCSI config TARGET_LS1021ATSN
@@ -1378,6 +1381,7 @@ config TARGET_LS1021AIOT select CPU_V7_HAS_NONSEC select CPU_V7_HAS_VIRT select SUPPORT_SPL + select DM_SPI_FLASH if FSL_DSPI || FSL_QSPI imply SCSI help Support for Freescale LS1021AIOT platform.
@@ -1811,5 +1815,3 @@ config SPL_LDSCRIPT default "arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds" if (ARCH_MX23 || ARCH_MX28) && !SPL_FRAMEWORK default "arch/arm/cpu/arm1136/u-boot-spl.lds" if CPU_ARM1136 default "arch/arm/cpu/armv8/u-boot-spl.lds" if ARM64 - -
include/configs/ls1021aiot.h +0 -6
@@ -139,12 +139,6 @@#define CONFIG_SPI_FLASH_SPANSION #endif -/* DM SPI */ -#if defined(CONFIG_FSL_DSPI ) || defined(CONFIG_FSL_QSPI ) -#define CONFIG_CMD_SF -#define CONFIG_DM_SPI_FLASH -#endif -/* * eTSEC */
include/configs/ls1021aqds.h +0 -8
@@ -363,14 +363,6 @@ unsigned long get_board_ddr_clk(void);#define QSPI0_AMBA_BASE 0x40000000#define FSL_QSPI_FLASH_SIZE (1 << 24)#define FSL_QSPI_FLASH_NUM 2 - -/* DSPI */ - -/* DM SPI */ -#if defined(CONFIG_FSL_DSPI ) || defined(CONFIG_FSL_QSPI ) -#define CONFIG_DM_SPI_FLASH -#define CONFIG_SPI_FLASH_DATAFLASH -#endif #endif /*
include/configs/ls1021atwr.h +0 -5
@@ -238,11 +238,6 @@/* DSPI */ #endif -/* DM SPI */ -#if defined(CONFIG_FSL_DSPI ) || defined(CONFIG_FSL_QSPI ) -#define CONFIG_DM_SPI_FLASH -#endif -/* * Video */
Signature · 1 line
2.11.0
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
In reply to Lukasz MajewskiThis change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the DM_SPI support in SPL and TPL via Kconfig option.
Before this change it was necessary to use:
/* SPI Flash Configs */
#if defined(CONFIG_SPL_BUILD)
#undef CONFIG_DM_SPI
#undef CONFIG_DM_SPI_FLASH
#undef CONFIG_SPI_FLASH_MTD
#endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to Kconfig.
The goal of this patch:
Provide distinction for DM_SPI support in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to use DM_SPI, but SPL must still support non DM driver.
Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in Kconfig (also if SPL version of the driver supports OF_PLATDATA).
In the end of the day one would have to support following use cases (in single driver file - e.g. mxs_spi.c):
- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS and SPL_OF_PLATDATA (when one have constrained environment with no fitImage and OF_LIBFDT support).
Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
This patch converts #ifdef CONFIG_DM_SPI* to #if CONFIG_IS_ENABLED(DM_SPI) and provides corresponding defines in Kconfig.
---
Changes in v2:
- Resend patches with some not yet in mainline code removed as suggested by Adam Ford
===================================
BIG FAT NOTE (REQUEST FOR TESTING):
===================================
The adjustments were done only to make the buildman / travis-CI build clean.
Board maintainers are kindly ask to check if there are no failures on boards booting (or unintentional increase of binary size).
Note:
=====
Some boards require adjustments in ./configs/<board>_defconfig (like Siemens). Other boards require modification in arch/arm/Kconfig (like MVEBU) Yet another ones - like ones from Samsung - doesn't use SPL at all. There are also boards - like i.MX{25678} - which (till now) doesn't use SPI drivers supporting DM in their SPL.
Applied on top of -master branch:
'commit feb5a02f869d ("Merge branch 'master' of git://git.denx.de/u-boot-sh")'
Travis-CI (clean build):
https://travis-ci.org/lmajewski/u-boot-dfu/builds/570594278
--- arch/arm/Kconfig | 13 +++++++++++++ board/l+g/vinco/vinco.c | 4 ++-- cmd/sf.c | 4 ++-- cmd/spi.c | 6 +++--- common/spl/Kconfig | 28 ++++++++++++++++++++++++++++ configs/am57xx_evm_defconfig | 2 ++ configs/am57xx_hs_evm_defconfig | 2 ++ configs/am57xx_hs_evm_usb_defconfig | 2 ++ configs/axm_defconfig | 2 ++ configs/chromebook_link64_defconfig | 2 ++ configs/chromebook_samus_tpl_defconfig | 4 ++++ configs/dra7xx_evm_defconfig | 2 ++ configs/dra7xx_hs_evm_defconfig | 2 ++ configs/dra7xx_hs_evm_usb_defconfig | 2 ++ configs/j721e_evm_a72_defconfig | 2 ++ configs/j721e_evm_r5_defconfig | 2 ++ configs/ls1021aiot_qspi_defconfig | 2 ++ configs/ls1021aiot_sdcard_defconfig | 2 ++ configs/ls1021aqds_qspi_defconfig | 1 + configs/ls1021aqds_sdcard_qspi_defconfig | 1 + configs/ls1021atwr_qspi_defconfig | 1 + configs/sama5d2_xplained_spiflash_defconfig | 2 ++ configs/sama5d3xek_spiflash_defconfig | 7 ++++--- configs/sama5d4_xplained_spiflash_defconfig | 2 ++ configs/sama5d4ek_spiflash_defconfig | 2 ++ configs/stm32mp15_basic_defconfig | 2 ++ configs/taurus_defconfig | 2 ++ drivers/mtd/spi/Makefile | 4 ++-- drivers/mtd/spi/sf_probe.c | 8 ++++---- drivers/net/fm/fm.c | 4 ++-- drivers/spi/Makefile | 2 +- drivers/spi/atmel_spi.c | 4 ++-- drivers/spi/davinci_spi.c | 6 +++--- drivers/spi/fsl_dspi.c | 5 +++-- drivers/spi/kirkwood_spi.c | 2 +- drivers/spi/mxc_spi.c | 6 +++--- drivers/spi/omap3_spi.c | 4 ++-- drivers/spi/sh_qspi.c | 4 ++-- env/sf.c | 2 +- include/spi.h | 8 ++++---- include/spi_flash.h | 2 +- test/dm/spi.c | 2 +- 42 files changed, 125 insertions(+), 41 deletions(-)
arch/arm/Kconfig +13 -0
@@ -503,6 +503,8 @@ config ARCH_MVEBU select DM_SERIAL select DM_SPI select DM_SPI_FLASH + select SPL_DM_SPI if SPL + select SPL_DM_SPI_FLASH if SPL select OF_CONTROL select OF_SEPARATE select SPI
@@ -911,6 +913,8 @@ config ARCH_SOCFPGA imply FAT_WRITE imply SPL imply SPL_DM + imply SPL_DM_SPI + imply SPL_DM_SPI_FLASH imply SPL_LIBDISK_SUPPORT imply SPL_MMC_SUPPORT imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
@@ -999,6 +1003,8 @@ config ARCH_ZYNQ select SPL_BOARD_INIT if SPL select SPL_CLK if SPL select SPL_DM if SPL + select SPL_DM_SPI if SPL + select SPL_DM_SPI_FLASH if SPL select SPL_OF_CONTROL if SPL select SPL_SEPARATE_BSS if SPL select SUPPORT_SPL
@@ -1035,6 +1041,8 @@ config ARCH_ZYNQMP select OF_CONTROL select SPL_BOARD_INIT if SPL select SPL_CLK if SPL + select SPL_DM_SPI if SPI + select SPL_DM_SPI_FLASH if SPL_DM_SPI select SPL_SEPARATE_BSS if SPL select SUPPORT_SPL imply BOARD_LATE_INIT
@@ -1429,6 +1437,7 @@ config TARGET_LS1046AQDS select BOARD_EARLY_INIT_F select BOARD_LATE_INIT select DM_SPI_FLASH if DM_SPI + select SPL_DM_SPI select SUPPORT_SPL select FSL_DDR_BIST if !SPL select FSL_DDR_INTERACTIVE if !SPL
@@ -1449,6 +1458,7 @@ config TARGET_LS1046ARDB select BOARD_EARLY_INIT_F select BOARD_LATE_INIT select DM_SPI_FLASH if DM_SPI + select SPL_DM_SPI select POWER_MC34VR500 select SUPPORT_SPL select FSL_DDR_BIST
@@ -1469,6 +1479,7 @@ config TARGET_LS1046AFRWY select BOARD_EARLY_INIT_F select BOARD_LATE_INIT select DM_SPI_FLASH if DM_SPI + select SPL_DM_SPI imply SCSI help Support for Freescale LS1046AFRWY platform.
@@ -1580,6 +1591,8 @@ config ARCH_ROCKCHIP select OF_CONTROL select SPI select SPL_DM if SPL + select SPL_DM_SPI if SPL + select SPL_DM_SPI_FLASH if SPL select SPL_SYS_MALLOC_SIMPLE if SPL select SYS_MALLOC_F select SYS_THUMB_BUILD if !ARM64
board/l+g/vinco/vinco.c +2 -2
@@ -33,7 +33,7 @@DECLARE_GLOBAL_DATA_PTR ;/* FIXME gpio code here need to handle through DM_GPIO */ -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )int spi_cs_is_valid (unsigned int bus,unsigned int cs) {return bus ==0 && cs ==0 ;
@@ -166,7 +166,7 @@ int board_init(void)/* adress of boot parameters */ gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )vinco_spi0_hw_init ();#endif
cmd/sf.c +2 -2
@@ -85,7 +85,7 @@ static int do_spi_flash_probe(int argc, char * const argv[])unsigned int speed =CONFIG_SF_DEFAULT_SPEED ;unsigned int mode =CONFIG_SF_DEFAULT_MODE ;char *endp; -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )struct udevice *new, *bus_dev;int ret;#else
@@ -118,7 +118,7 @@ static int do_spi_flash_probe(int argc, char * const argv[])return -1 ; } -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )/* Remove the old device, otherwise probe will just be a nop */ ret =spi_find_bus_and_cs (bus, cs, &bus_dev, &new);if (!ret) {
cmd/spi.c +3 -3
@@ -37,7 +37,7 @@ static int do_spi_xfer(int bus, int cs)struct spi_slave *slave;int ret =0 ; -#ifdef CONFIG_DM_SPI +#if CONFIG_IS_ENABLED (DM_SPI )char name[30 ], *str;struct udevice *dev;
@@ -62,7 +62,7 @@ static int do_spi_xfer(int bus, int cs) goto done; ret =spi_xfer (slave, bitlen, dout, din,SPI_XFER_BEGIN |SPI_XFER_END ); -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )/* We don't get an error code in this case */ if (ret) ret = -EIO ;
@@ -78,7 +78,7 @@ static int do_spi_xfer(int bus, int cs) } done:spi_release_bus (slave); -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )spi_free_slave (slave);#endif
common/spl/Kconfig +28 -0
@@ -649,6 +649,19 @@ config SPL_UBI Enable support for loading payloads from UBI. See README.ubispl for more info. +if SPL_DM +config SPL_DM_SPI + bool "Support SPI DM drivers in SPL" + help + Enable support for SPI DM drivers in SPL. + +config SPL_DM_SPI_FLASH + bool "Support SPI DM FLASH drivers in SPL" + help + Enable support for SPI DM flash drivers in SPL. + +endif + if SPL_UBI config SPL_UBI_LOAD_BY_VOLNAME bool "Support loading volumes by name"
@@ -973,6 +986,11 @@ config SPL_SPI_FLASH_SFDP_SUPPORT SPI NOR flashes using Serial Flash Discoverable Parameters (SFDP) tables as per JESD216 standard in SPL. +config SPL_SPI_FLASH_MTD + bool "Support for SPI flash MTD drivers in SPL" + help + Enable support for SPI flash MTD drivers in SPL. + config SPL_SPI_LOAD bool "Support loading from SPI flash" help
@@ -1340,6 +1358,16 @@ config TPL_SPI_SUPPORT Enable support for using SPI in TPL. See SPL_SPI_SUPPORT for details. +config TPL_DM_SPI + bool "Support SPI DM drivers in TPL" + help + Enable support for SPI DM drivers in TPL. + +config TPL_DM_SPI_FLASH + bool "Support SPI DM FLASH drivers in TPL" + help + Enable support for SPI DM flash drivers in TPL. + config TPL_YMODEM_SUPPORT bool "Support loading using Ymodem" depends on TPL_SERIAL_SUPPORT
configs/am57xx_evm_defconfig +2 -0
@@ -64,6 +64,7 @@ CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_OMAP_HS=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -83,6 +84,7 @@ CONFIG_DM_SCSI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_USB=y CONFIG_DM_USB=y
configs/am57xx_hs_evm_defconfig +2 -0
@@ -62,6 +62,7 @@ CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_OMAP_HS=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -81,6 +82,7 @@ CONFIG_DM_SCSI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_USB=y CONFIG_DM_USB=y
configs/am57xx_hs_evm_usb_defconfig +2 -0
@@ -68,6 +68,7 @@ CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_OMAP_HS=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -88,6 +89,7 @@ CONFIG_DM_REGULATOR_PALMAS=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_USB=y CONFIG_DM_USB=y
configs/axm_defconfig +2 -0
@@ -60,6 +60,8 @@ CONFIG_CLK_AT91=y # CONFIG_MMC is not set CONFIG_NAND=y CONFIG_NAND_ATMEL=y +CONFIG_SPL_DM_SPI=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_STMICRO=y
configs/chromebook_link64_defconfig +2 -0
@@ -27,6 +27,8 @@ CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_CPU_SUPPORT=y CONFIG_SPL_ENV_SUPPORT=y CONFIG_SPL_I2C_SUPPORT=y +CONFIG_SPL_DM_SPI=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPL_NET_SUPPORT=y CONFIG_SPL_PCI=y CONFIG_SPL_PCH_SUPPORT=y
configs/chromebook_samus_tpl_defconfig +4 -0
@@ -27,11 +27,15 @@ CONFIG_BLOBLIST_ADDR=0xff7c0000 CONFIG_HANDOFF=y CONFIG_SPL_TEXT_BASE=0xffe70000 CONFIG_SPL_SEPARATE_BSS=y +CONFIG_SPL_DM_SPI=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPL_NET_SUPPORT=y CONFIG_SPL_PCI=y CONFIG_SPL_PCH_SUPPORT=y CONFIG_TPL_PCI=y CONFIG_TPL_PCH_SUPPORT=y +CONFIG_TPL_DM_SPI=y +CONFIG_TPL_DM_SPI_FLASH=y CONFIG_HUSH_PARSER=y CONFIG_CMD_CPU=y # CONFIG_CMD_FLASH is not set
configs/dra7xx_evm_defconfig +2 -0
@@ -74,6 +74,7 @@ CONFIG_MMC_OMAP_HS=y CONFIG_NAND=y CONFIG_SYS_NAND_BUSWIDTH_16BIT=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -95,6 +96,7 @@ CONFIG_DM_SCSI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_TIMER=y CONFIG_OMAP_TIMER=y
configs/dra7xx_hs_evm_defconfig +2 -0
@@ -77,6 +77,7 @@ CONFIG_MMC_OMAP_HS=y CONFIG_NAND=y CONFIG_SYS_NAND_BUSWIDTH_16BIT=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -98,6 +99,7 @@ CONFIG_DM_SCSI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_TIMER=y CONFIG_OMAP_TIMER=y
configs/dra7xx_hs_evm_usb_defconfig +2 -0
@@ -77,6 +77,7 @@ CONFIG_MMC_HS200_SUPPORT=y CONFIG_SPL_MMC_HS200_SUPPORT=y CONFIG_MMC_OMAP_HS=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SF_DEFAULT_SPEED=76800000
@@ -99,6 +100,7 @@ CONFIG_DM_SCSI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TI_QSPI=y CONFIG_TIMER=y CONFIG_OMAP_TIMER=y
configs/j721e_evm_a72_defconfig +2 -0
@@ -62,6 +62,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_AM654=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PINCTRL=y
@@ -76,6 +77,7 @@ CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_CADENCE_QSPI=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y
configs/j721e_evm_r5_defconfig +2 -0
@@ -67,6 +67,7 @@ CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_AM654=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PINCTRL=y
@@ -83,6 +84,7 @@ CONFIG_RESET_TI_SCI=y CONFIG_DM_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_CADENCE_QSPI=y CONFIG_SYSRESET=y CONFIG_SPL_SYSRESET=y
configs/ls1021aiot_qspi_defconfig +2 -0
@@ -12,6 +12,7 @@ CONFIG_CMD_DHCP=y CONFIG_CMD_PING=y CONFIG_CMD_EXT2=y CONFIG_CMD_FAT=y +CONFIG_CMD_SF=y CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="ls1021a-iot-duart" CONFIG_ENV_IS_IN_SPI_FLASH=y
@@ -35,6 +36,7 @@ CONFIG_DM_SCSI=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_FSL_DSPI=y CONFIG_FSL_QSPI=y CONFIG_USB=y
configs/ls1021aiot_sdcard_defconfig +2 -0
@@ -17,6 +17,7 @@ CONFIG_CMD_DHCP=y CONFIG_CMD_PING=y CONFIG_CMD_EXT2=y CONFIG_CMD_FAT=y +CONFIG_CMD_SF=y # CONFIG_SPL_EFI_PARTITION is not set CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="ls1021a-iot-duart"
@@ -41,6 +42,7 @@ CONFIG_DM_SCSI=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_FSL_DSPI=y CONFIG_FSL_QSPI=y CONFIG_USB=y
configs/ls1021aqds_qspi_defconfig +1 -0
@@ -54,6 +54,7 @@ CONFIG_DM_SCSI=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_FSL_DSPI=y CONFIG_FSL_QSPI=y CONFIG_USB=y
configs/ls1021aqds_sdcard_qspi_defconfig +1 -0
@@ -66,6 +66,7 @@ CONFIG_DM_SCSI=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPIy=y CONFIG_FSL_DSPI=y CONFIG_FSL_QSPI=y CONFIG_USB=y
configs/ls1021atwr_qspi_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_DM_SCSI=y CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPI_DM_SPI=y CONFIG_FSL_DSPI=y CONFIG_FSL_QSPI=y CONFIG_USB=y
configs/sama5d2_xplained_spiflash_defconfig +2 -0
@@ -63,6 +63,8 @@ CONFIG_I2C_EEPROM=y CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_ATMEL=y +CONFIG_SPL_DM_SPI=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_SPEED=30000000
configs/sama5d3xek_spiflash_defconfig +4 -3
@@ -6,10 +6,11 @@ CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_SYS_MALLOC_F_LEN=0x2000 -CONFIG_SPL_SERIAL_SUPPORT=y -CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_ENV_SIZE=0x2000 +CONFIG_ENV_SECT_SIZE=0x1000 CONFIG_ENV_OFFSET=0x6000 +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_NR_DRAM_BANKS=1 CONFIG_SPL=y CONFIG_DEBUG_UART_BOARD_INIT=y
@@ -26,6 +27,7 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk mtdparts=atmel_nand:256k(bootstrap)ro,768k(uboot)ro,256K(env_redundant),256k(env),512k(dtb),6M(kernel)ro,-(rootfs) rootfstype=ubifs ubi.mtd=6 root=ubi0:rootfs" # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_SPL_TEXT_BASE=0x300000 +CONFIG_SPL_DM_SPI=y CONFIG_SPL_SPI_LOAD=y CONFIG_HUSH_PARSER=y CONFIG_CMD_BOOTZ=y
@@ -46,7 +48,6 @@ CONFIG_SPL_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="sama5d36ek" CONFIG_OF_SPL_REMOVE_PROPS="interrupts interrupt-parent dmas dma-names" CONFIG_ENV_IS_IN_SPI_FLASH=y -CONFIG_ENV_SECT_SIZE=0x1000 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_DM=y CONFIG_SPL_DM=y
configs/sama5d4_xplained_spiflash_defconfig +2 -0
@@ -63,6 +63,7 @@ CONFIG_GENERIC_ATMEL_MCI=y CONFIG_NAND=y CONFIG_NAND_ATMEL=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_SPEED=30000000 CONFIG_SPI_FLASH_ATMEL=y
@@ -77,6 +78,7 @@ CONFIG_DEBUG_UART_ANNOUNCE=y CONFIG_ATMEL_USART=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TIMER=y CONFIG_SPL_TIMER=y CONFIG_ATMEL_PIT_TIMER=y
configs/sama5d4ek_spiflash_defconfig +2 -0
@@ -60,6 +60,7 @@ CONFIG_GENERIC_ATMEL_MCI=y CONFIG_NAND=y CONFIG_NAND_ATMEL=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SF_DEFAULT_SPEED=30000000 CONFIG_SPI_FLASH_ATMEL=y
@@ -74,6 +75,7 @@ CONFIG_DEBUG_UART_ANNOUNCE=y CONFIG_ATMEL_USART=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_TIMER=y CONFIG_SPL_TIMER=y CONFIG_ATMEL_PIT_TIMER=y
configs/stm32mp15_basic_defconfig +2 -0
@@ -79,6 +79,7 @@ CONFIG_MTD=y CONFIG_NAND=y CONFIG_NAND_STM32_FMC2=y CONFIG_DM_SPI_FLASH=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_BAR=y CONFIG_SPI_FLASH_MACRONIX=y
@@ -108,6 +109,7 @@ CONFIG_SERIAL_RX_BUFFER=y CONFIG_STM32_SERIAL=y CONFIG_SPI=y CONFIG_DM_SPI=y +CONFIG_SPL_DM_SPI=y CONFIG_STM32_QSPI=y CONFIG_STM32_SPI=y CONFIG_USB=y
configs/taurus_defconfig +2 -0
@@ -68,6 +68,8 @@ CONFIG_DFU_NAND=y # CONFIG_MMC is not set CONFIG_NAND=y CONFIG_NAND_ATMEL=y +CONFIG_SPL_DM_SPI=y +CONFIG_SPL_DM_SPI_FLASH=y CONFIG_DM_SPI_FLASH=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_STMICRO=y
drivers/mtd/spi/Makefile +2 -2
@@ -3,7 +3,7 @@ # (C) Copyright 2006 # Wolfgang Denk, DENX Software Engineering, wd at denx.de. -obj-$(CONFIG_DM_SPI_FLASH) += sf-uclass.o +obj-$(CONFIG_$(SPL_TPL_)DM_SPI_FLASH) += sf-uclass.o spi-nor-y := sf_probe.o spi-nor-ids.o ifdef CONFIG_SPL_BUILD
@@ -19,5 +19,5 @@ endif obj-$(CONFIG_SPI_FLASH) += spi-nor.o obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o sf.o -obj-$(CONFIG_SPI_FLASH_MTD) += sf_mtd.o +obj-$(CONFIG_$(SPL_TPL_)SPI_FLASH_MTD) += sf_mtd.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o
drivers/mtd/spi/sf_probe.c +4 -4
@@ -44,7 +44,7 @@ static int spi_flash_probe_slave(struct spi_flash *flash)if (ret) goto err_read_id; -#ifdef CONFIG_SPI_FLASH_MTD +#if CONFIG_IS_ENABLED (SPI_FLASH_MTD ) ret =spi_flash_mtd_register (flash);#endif
@@ -53,7 +53,7 @@ err_read_id:return ret; } -#ifndef CONFIG_DM_SPI_FLASH +#if !CONFIG_IS_ENABLED (DM_SPI_FLASH )struct spi_flash *spi_flash_probe (unsigned int busnum,unsigned int cs,unsigned int max_hz,unsigned int spi_mode) {
@@ -83,7 +83,7 @@ struct spi_flash *spi_flash_probe(unsigned int busnum, unsigned int cs,void spi_flash_free (struct spi_flash *flash) { -#ifdef CONFIG_SPI_FLASH_MTD +#if CONFIG_IS_ENABLED (SPI_FLASH_MTD )spi_flash_mtd_unregister ();#endif spi_free_slave (flash->spi);
@@ -152,7 +152,7 @@ static int spi_flash_std_probe(struct udevice *dev)static int spi_flash_std_remove (struct udevice *dev) { -#ifdef CONFIG_SPI_FLASH_MTD +#if CONFIG_IS_ENABLED (SPI_FLASH_MTD )spi_flash_mtd_unregister ();#endif return 0 ;
drivers/net/fm/fm.c +2 -2
@@ -377,7 +377,7 @@ int fm_init_common(int index, struct ccsr_fman *reg) addr =malloc (CONFIG_SYS_QE_FMAN_FW_LENGTH );int ret =0 ; -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )struct udevice *new;/* speed and mode will be read from DT */
@@ -464,7 +464,7 @@ int fm_init_common(int index, struct ccsr_fman *reg)void *addr =malloc (CONFIG_SYS_QE_FMAN_FW_LENGTH );int ret =0 ; -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )struct udevice *new;/* speed and mode will be read from DT */
drivers/spi/Makefile +1 -1
@@ -4,7 +4,7 @@ # Wolfgang Denk, DENX Software Engineering, wd at denx.de. # There are many options which enable SPI, so make this library available -ifdef CONFIG_DM_SPI +ifdef CONFIG_$(SPL_TPL_)DM_SPI obj-y += spi-uclass.o obj-$(CONFIG_SANDBOX) += spi-emul-uclass.o obj-$(CONFIG_SOFT_SPI) += soft_spi.o
drivers/spi/atmel_spi.c +2 -2
@@ -14,7 +14,7 @@#include <asm/arch/clk.h> #include <asm/arch/hardware.h> -#ifdef CONFIG_DM_SPI +#if CONFIG_IS_ENABLED (DM_SPI )#include <asm/arch/at91_spi.h> #endif #ifdef CONFIG_DM_GPIO
@@ -23,7 +23,7 @@#include "atmel_spi.h" -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )static int spi_has_wdrbt (struct atmel_spi_slave *slave) {
drivers/spi/davinci_spi.c +3 -3
@@ -52,7 +52,7 @@/* SPIDEF */ #define SPIDEF_CSDEF0_MASK BIT(0) -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )#define SPI0_BUS 0#define SPI0_BASE CONFIG_SYS_SPI_BASE/*
@@ -119,7 +119,7 @@ struct davinci_spi_regs {/* davinci spi slave */ struct davinci_spi_slave { -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )struct spi_slave slave;#endif struct davinci_spi_regs *regs;
@@ -343,7 +343,7 @@ out:return 0 ; } -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )static inline struct davinci_spi_slave *to_davinci_spi (struct spi_slave *slave) {
drivers/spi/fsl_dspi.c +3 -2
@@ -97,7 +97,7 @@ struct fsl_dspi_priv {struct dspi *regs; }; -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED(DM_SPI) struct fsl_dspi { struct spi_slave slave; struct fsl_dspi_priv priv;
@@ -411,7 +411,8 @@ static int fsl_dspi_cfg_speed(struct fsl_dspi_priv *priv, uint speed)return 0 ; } -#ifndef CONFIG_DM_SPI + +#if !CONFIG_IS_ENABLED (DM_SPI )int spi_cs_is_valid (unsigned int bus,unsigned int cs) {if (((cs >=0 ) && (cs <8 )) && ((bus >=0 ) && (bus <8 )))
drivers/spi/kirkwood_spi.c +1 -1
@@ -93,7 +93,7 @@ static int _spi_xfer(struct kwspi_registers *reg, unsigned int bitlen,return 0 ; } -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )static struct kwspi_registers *spireg = (struct kwspi_registers *)MVEBU_SPI_BASE ;
drivers/spi/mxc_spi.c +3 -3
@@ -63,7 +63,7 @@ static inline struct mxc_spi_slave *to_mxc_spi_slave(struct spi_slave *slave)static void mxc_spi_cs_activate (struct mxc_spi_slave *mxcs) { -#if defined(CONFIG_DM_SPI ) +#if CONFIG_IS_ENABLED (DM_SPI )struct udevice *dev = mxcs->dev;struct dm_spi_slave_platdata *slave_plat =dev_get_parent_platdata (dev);
@@ -81,7 +81,7 @@ static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs)static void mxc_spi_cs_deactivate (struct mxc_spi_slave *mxcs) { -#if defined(CONFIG_DM_SPI ) +#if CONFIG_IS_ENABLED (DM_SPI )struct udevice *dev = mxcs->dev;struct dm_spi_slave_platdata *slave_plat =dev_get_parent_platdata (dev);
@@ -411,7 +411,7 @@ static int mxc_spi_claim_bus_internal(struct mxc_spi_slave *mxcs, int cs)return 0 ; } -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )int spi_xfer (struct spi_slave *slave,unsigned int bitlen,const void *dout,void *din,unsigned long flags) {
drivers/spi/omap3_spi.c +2 -2
@@ -108,7 +108,7 @@ struct mcspi { };struct omap3_spi_priv { -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )struct spi_slave slave;#endif struct mcspi *regs;
@@ -454,7 +454,7 @@ static void _omap3_spi_claim_bus(struct omap3_spi_priv *priv)writel (conf, &priv->regs->modulctrl); } -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )static inline struct omap3_spi_priv *to_omap3_spi (struct spi_slave *slave) {
drivers/spi/sh_qspi.c +2 -2
@@ -67,7 +67,7 @@ struct sh_qspi_regs { };struct sh_qspi_slave { -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )struct spi_slave slave;#endif struct sh_qspi_regs *regs;
@@ -222,7 +222,7 @@ static int sh_qspi_xfer_common(struct sh_qspi_slave *ss, unsigned int bitlen,return ret; } -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )static inline struct sh_qspi_slave *to_sh_qspi (struct spi_slave *slave) { return container_of(slave, struct sh_qspi_slave, slave);
env/sf.c +1 -1
@@ -39,7 +39,7 @@ static struct spi_flash *env_flash;static int setup_flash_device (void ) { -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )struct udevice *new;int ret;
include/spi.h +4 -4
@@ -36,7 +36,7 @@#define SPI_DEFAULT_WORDLEN 8 -#ifdef CONFIG_DM_SPI +#if CONFIG_IS_ENABLED(DM_SPI) /* TODO(sjg at chromium.org): Remove this and use max_hz from struct spi_slave */ struct dm_spi_bus { uint max_hz;
@@ -95,7 +95,7 @@ struct dm_spi_slave_platdata {* @flags: Indication of SPI flags. */ struct spi_slave { -#ifdef CONFIG_DM_SPI +#if CONFIG_IS_ENABLED (DM_SPI )struct udevice *dev;/* struct spi_slave is dev->parentdata */ uint max_hz;uint speed;
@@ -261,7 +261,7 @@ void spi_flash_copy_mmap(void *data, void *offset, size_t len);*/ int spi_cs_is_valid (unsigned int bus,unsigned int cs); -#ifndef CONFIG_DM_SPI +#if !CONFIG_IS_ENABLED (DM_SPI )/** * Activate a SPI chipselect. * This function is provided by the board code when using a driver
@@ -311,7 +311,7 @@ static inline int spi_w8r8(struct spi_slave *slave, unsigned char byte)return ret <0 ? ret : din[1 ]; } -#ifdef CONFIG_DM_SPI +#if CONFIG_IS_ENABLED (DM_SPI )/** * struct spi_cs_info - Information about a bus chip select
include/spi_flash.h +1 -1
@@ -52,7 +52,7 @@ struct dm_spi_flash_ops {/* Access the serial operations for a device */ #define sf_get_ops (dev) ((struct dm_spi_flash_ops *)(dev)->driver->ops) -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )/** * spi_flash_read_dm() - Read data from SPI flash *
test/dm/spi.c +1 -1
@@ -117,7 +117,7 @@ static int dm_test_spi_xfer(struct unit_test_state *uts)* Since we are about to destroy all devices, we must tell sandbox * to forget the emulation device */ -#ifdef CONFIG_DM_SPI_FLASH +#if CONFIG_IS_ENABLED (DM_SPI_FLASH )sandbox_sf_unbind_emul (state_get_current (), busnum, cs);#endif
Signature · 1 line
2.11.0
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Quoted 37 lines · Lukasz Majewski
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).
Quoted 8 lines
Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evm
Sorry I didn't bisect down to which part of the series is doing this, but I see problems with:ls1046ardb_sdcard ls1046ardb_qspi_spl ls1043ardb_nand ls1046aqds_tfa ls1046aq ds_nand ls1046ardb_qspi ls1046aqds_sdcard_ifc ls1046aqds_SECURE_BOOT ls1046aqds_sdcard_qspi ls1 046aqds_qspi ls1043ardb_sdcard ls1043aqds_sdcard_ifc ls1046ardb_tfa ls1046ardb_tfa_SECURE_BOOT ls1043aqds_nand ls1046aqds_lpuart ls1046ardb_emmc ls1046aqds_tfa_SECURE_BOOT ls1046afrwy_tfa ls 1046aqds ls1043ardb_nand_SECURE_BOOT ls1046ardb_qspi_SECURE_BOOT ls1043aqds_sdcard_qspi
Some of which are dependency problems about SPL/SPL_DM. I also see:
aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0
[snip]
ls1043ardb_nand: all -9435 data -376 rodata -2331 text -6728
ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728
ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331 text -6728
ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728
ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728
ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728
ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728which I think means a few conversions weren't right.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190823/8cb17074/attachment.sig>
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Hi Tom,
Quoted 65 lines · Lukasz Majewski
Quoted 40 lines
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
Quoted 6 lines
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evmSorry I didn't bisect down to which part of the series is doing this, but I see problems with:
ls1046ardb_sdcardls1046ardb_qspi_splls1043ardb_nandls1046aqds_tfals1046aqds_nandls1046ardb_qspils1046aqds_sdcard_ifcls1046aqds_SECURE_BOOTls1046aqds_sdcard_qspils1 046aqds_qspils1043ardb_sdcardls1043aqds_sdcard_ifcls1046ardb_tfals1046ardb_tfa_SECURE_BOOTls1043aqds_nandls1046aqds_lpuartls1046ardb_emmcls1046aqds_tfa_SECURE_BOOTls1046afrwy_tfals 1046aqdsls1043ardb_nand_SECURE_BOOTls1046ardb_qspi_SECURE_BOOTls1043aqds_sdcard_qspiSome of which are dependency problems about SPL/SPL_DM. I also see:
aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0 [snip] ls1043ardb_nand: all -9435 data -376 rodata -2331 text -6728 ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728 ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331
Quoted 7 lines
text -6728
ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728which I think means a few conversions weren't right.
It looks like some parts of the SPL are not build ....
Is the delta of size available from travis-CI or from any other script (maybe there is some buildman switch)?
Quoted 1 line
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190823/04d43479/attachment.sig>
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Quoted 73 lines · Lukasz Majewski
Hi Tom,
Quoted 71 lines · Lukasz Majewski
Quoted 40 lines
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
Quoted 6 lines
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evmSorry I didn't bisect down to which part of the series is doing this, but I see problems with:
ls1046ardb_sdcardls1046ardb_qspi_splls1043ardb_nandls1046aqds_tfals1046aqds_nandls1046ardb_qspils1046aqds_sdcard_ifcls1046aqds_SECURE_BOOTls1046aqds_sdcard_qspils1 046aqds_qspils1043ardb_sdcardls1043aqds_sdcard_ifcls1046ardb_tfals1046ardb_tfa_SECURE_BOOTls1043aqds_nandls1046aqds_lpuartls1046ardb_emmcls1046aqds_tfa_SECURE_BOOTls1046afrwy_tfals 1046aqdsls1043ardb_nand_SECURE_BOOTls1046ardb_qspi_SECURE_BOOTls1043aqds_sdcard_qspiSome of which are dependency problems about SPL/SPL_DM. I also see:
aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0 [snip] ls1043ardb_nand: all -9435 data -376 rodata -2331 text -6728 ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728 ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331text -6728
ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728
Quoted 3 lines
Quoted 1 line
which I think means a few conversions weren't right.
It looks like some parts of the SPL are not build ....
Yes, there's some dependency problem Kconfig is spotting related to SPL/SPL_DM.
Quoted 2 lines
Is the delta of size available from travis-CI or from any other script (maybe there is some buildman switch)?
Yes, it's part of buildman. I do:
$ export SOURCE_DATE_EPOCH=`date +%s` $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. --force-build -CveE $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. -Ssdel
to get size changes between point A and point Z in a branch, and omit --step 0 when I need to see which patch in between them caused the size change.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190823/e282208e/attachment.sig>
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Hi Tom,
Quoted 87 lines · Lukasz Majewski
Quoted 75 lines
Hi Tom,
Quoted 73 lines · Lukasz Majewski
Quoted 41 lines
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
Quoted 6 lines
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evmSorry I didn't bisect down to which part of the series is doing this, but I see problems with:
ls1046ardb_sdcardls1046ardb_qspi_splls1043ardb_nandls1046aqds_tfals1046aqds_nandls1046ardb_qspils1046aqds_sdcard_ifcls1046aqds_SECURE_BOOTls1046aqds_sdcard_qspils1 046aqds_qspils1043ardb_sdcardls1043aqds_sdcard_ifcls1046ardb_tfals1046ardb_tfa_SECURE_BOOTls1043aqds_nandls1046aqds_lpuartls1046ardb_emmcls1046aqds_tfa_SECURE_BOOTls1046afrwy_tfals 1046aqdsls1043ardb_nand_SECURE_BOOTls1046ardb_qspi_SECURE_BOOTls1043aqds_sdcard_qspiSome of which are dependency problems about SPL/SPL_DM. I also
see: aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0 [snip]ls1043ardb_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331 text -6728ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728Quoted 3 lines
Quoted 1 line
which I think means a few conversions weren't right.
It looks like some parts of the SPL are not build ....
Yes, there's some dependency problem
Kconfigis spotting related to SPL/SPL_DM.Quoted 2 lines
Is the delta of size available from travis-CI or from any other script (maybe there is some buildman switch)?
Yes, it's part of buildman. I do:
Quoted 9 lines
$ export SOURCE_DATE_EPOCH=`date +%s` $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. --force-build -CveE $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. -Ssdelto get size changes between point A and point Z in a branch, and omit --step 0 when I need to see which patch in between them caused the size change.
I cannot reproduce your results on current master branch:
SHA1:d22c8be964a870f59d2fdab6c67cefa0c4799364
for this series applied.
echo $SOURCE_DATE_EPOCH
1567523778
./tools/buildman/buildman.py -b HEAD --count=3 ls1043 --output-dir=../BUILD/ --force-build -CveE
./tools/buildman/buildman.py -b HEAD --count=3 ls1043 --output-dir=../BUILD/ -Ssdel
Just gives me some warnings (without the size difference):
aarch64: w+ ls1043aqds_nand ls1043ardb_nand
ls1043aqds_sdcard_qspi ls1043aqds_sdcard_ifc
ls1043ardb_nand_SECURE_BOOT ls1043ardb_sdcard
ls1043ardb_sdcard_SECURE_BOOT +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) ===================== WARNING ====================== +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_SPI_FLASH. Please update +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_SPI_FLASH before the v2019.07 release. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) Failure to update by the deadline may result in board removal. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) See doc/driver-model/MIGRATION.txt for more info. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT)
====================================================
+(ls1043ardb_sdcard_SECURE_BOOT) This board does not use
CONFIG_DM_MMC. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the
board to use CONFIG_DM_MMC before the v2019.04 release.
+(ls1043ardb_sdcard_SECURE_BOOT) This board does not use
CONFIG_DM_USB. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the
board to use CONFIG_DM_USB before the v2019.07 release.
Am I doing something wrong? Or am I missing any extra switches for buildman?
And I don't know why the ' -b HEAD..HEAD~~~ ' option returns:
Range 'HEAD..HEAD~~~' has no commits , as I'm able to use HEAD with
-b switch and count=X ?
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/dc435ed5/attachment.sig>
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Quoted 140 lines · Lukasz Majewski
Hi Tom,
Quoted 87 lines · Lukasz Majewski
Quoted 75 lines
Hi Tom,
Quoted 73 lines · Lukasz Majewski
Quoted 41 lines
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
Quoted 6 lines
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evmSorry I didn't bisect down to which part of the series is doing this, but I see problems with:
ls1046ardb_sdcardls1046ardb_qspi_splls1043ardb_nandls1046aqds_tfals1046aqds_nandls1046ardb_qspils1046aqds_sdcard_ifcls1046aqds_SECURE_BOOTls1046aqds_sdcard_qspils1 046aqds_qspils1043ardb_sdcardls1043aqds_sdcard_ifcls1046ardb_tfals1046ardb_tfa_SECURE_BOOTls1043aqds_nandls1046aqds_lpuartls1046ardb_emmcls1046aqds_tfa_SECURE_BOOTls1046afrwy_tfals 1046aqdsls1043ardb_nand_SECURE_BOOTls1046ardb_qspi_SECURE_BOOTls1043aqds_sdcard_qspiSome of which are dependency problems about SPL/SPL_DM. I also
see: aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0 [snip]ls1043ardb_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331 text -6728ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728Quoted 3 lines
Quoted 1 line
which I think means a few conversions weren't right.
It looks like some parts of the SPL are not build ....
Yes, there's some dependency problem
Kconfigis spotting related to SPL/SPL_DM.Quoted 2 lines
Is the delta of size available from travis-CI or from any other script (maybe there is some buildman switch)?
Yes, it's part of buildman. I do:
Quoted 9 lines
$ export SOURCE_DATE_EPOCH=`date +%s` $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. --force-build -CveE $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. -Ssdelto get size changes between point A and point Z in a branch, and omit --step 0 when I need to see which patch in between them caused the size change.
I cannot reproduce your results on current master branch:
SHA1:d22c8be964a870f59d2fdab6c67cefa0c4799364for this series applied.
echo $SOURCE_DATE_EPOCH
1567523778
./tools/buildman/buildman.py-b HEAD --count=3 ls1043 --output-dir=../BUILD/ --force-build -CveE
./tools/buildman/buildman.py-b HEAD --count=3 ls1043 --output-dir=../BUILD/ -SsdelJust gives me some warnings (without the size difference):
aarch64: w+ ls1043aqds_nand ls1043ardb_nand ls1043aqds_sdcard_qspi ls1043aqds_sdcard_ifc ls1043ardb_nand_SECURE_BOOT ls1043ardb_sdcard ls1043ardb_sdcard_SECURE_BOOT +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) ===================== WARNING ====================== +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_SPI_FLASH. Please update +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_SPI_FLASH before the v2019.07 release. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) Failure to update by the deadline may result in board removal. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) See doc/driver-model/MIGRATION.txt for more info. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) ==================================================== +(ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_MMC. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_DM_MMC before the v2019.04 release. +(ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_USB. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_DM_USB before the v2019.07 release.
Quoted 8 lines
Am I doing something wrong? Or am I missing any extra switches for buildman?
And I don't know why the ' -b HEAD..HEAD~~~ ' option returns:
Range 'HEAD..HEAD~~~' has no commits , as I'm able to use HEAD with
-b switch and count=X ?
You should see output like (grabbing from a currently open log):
01: i2c: mxc: add CONFIG_CLK support
aarch64: w+ ls1043aqds_nand ls1043ardb_nand
...
17: Merge tag 'for-v2019.10-v2' of https://gitlab.denx.de/u-boot/custodians/u-boot-i2c
...
when it's run right and comparing points A and Z. As far as I can tell, it's really important for the upstream tracking part (as far as git branches goes) to be right, for this to work. So if you for example create a "SPI-conversion" branch off of master, and in turn master tracks origin/master, if you 'git merge SPI-conversion' into master then buildman --step 0 -b master does what I was talking about. Telling git "HEAD..HEAD~~~" is backwards? Play around with 'git log --oneline RANGE' to see what you need to say to get what you want.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/9d8819fb/attachment.sig>
PATCH v2 4/4 spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*
Hi Tom,
Quoted 163 lines · Lukasz Majewski
Quoted 146 lines
Hi Tom,
Quoted 93 lines · Lukasz Majewski
Quoted 81 lines
Hi Tom,
Quoted 79 lines
Quoted 44 lines · Lukasz Majewski
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the
DM_SPIsupport in SPL and TPL viaKconfigoption.Before this change it was necessary to use:
/* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endifin the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to
Kconfig.The goal of this patch:
Provide distinction for
DM_SPIsupport in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to useDM_SPI, but SPL must still support non DM driver.Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in
Kconfig(also if SPL version of the driver supportsOF_PLATDATA).In the end of the day one would have to support following use cases (in single driver file - e.g.
mxs_spi.c):- U-Boot proper driver supporting DT/DTS
- U-Boot proper driver without DT/DTS support (deprecated)
- SPL driver without DT/DTS support
- SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS)
- SPL driver with DT/DTS andSPL_OF_PLATDATA(when one have constrained environment with no fitImage andOF_LIBFDTsupport).Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL.
Quoted 6 lines
This patch converts #ifdef CONFIG_DM_SPI* to #if
CONFIG_IS_ENABLED(DM_SPI)and provides corresponding defines inKconfig.Signed-off-by Lukasz Majewski <[email protected]>Tested-by Adam Ford <[email protected]> #da850-evmSorry I didn't bisect down to which part of the series is doing this, but I see problems with:
ls1046ardb_sdcardls1046ardb_qspi_splls1043ardb_nandls1046aqds_tfals1046aqds_nandls1046ardb_qspils1046aqds_sdcard_ifcls1046aqds_SECURE_BOOTls1046aqds_sdcard_qspils1 046aqds_qspils1043ardb_sdcardls1043aqds_sdcard_ifcls1046ardb_tfals1046ardb_tfa_SECURE_BOOTls1043aqds_nandls1046aqds_lpuartls1046ardb_emmcls1046aqds_tfa_SECURE_BOOTls1046afrwy_tfals 1046aqdsls1043ardb_nand_SECURE_BOOTls1046ardb_qspi_SECURE_BOOTls1043aqds_sdcard_qspiSome of which are dependency problems about SPL/SPL_DM. I also see: aarch64: (for 225/225 boards) all -294.2 bss -0.0 data -11.7 rodata -72.5 spl/u-boot-spl:all -0.3 spl/u-boot-spl:text -0.3 text -210.0 [snip]
ls1043ardb_nand:
all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_ifc: all -9435 data -376 rodata -2331 text -6728ls1043aqds_nand: all -9435 data -376 rodata -2331 text -6728ls1043ardb_nand_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043ardb_sdcard_SECURE_BOOT: all -9435 data -376 rodata -2331 text -6728ls1043aqds_sdcard_qspi: all -9436 bss -8 data -376 rodata -2324 text -6728Quoted 3 lines
Quoted 1 line
which I think means a few conversions weren't right.
It looks like some parts of the SPL are not build ....
Yes, there's some dependency problem
Kconfigis spotting related to SPL/SPL_DM.Quoted 2 lines
Is the delta of size available from travis-CI or from any other script (maybe there is some buildman switch)?
Yes, it's part of buildman. I do:
Quoted 9 lines
$ export SOURCE_DATE_EPOCH=`date +%s` $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. --force-build -CveE $ ./tools/buildman/buildman -o /tmp/test --step 0 -b origin/master.. -Ssdelto get size changes between point A and point Z in a branch, and omit --step 0 when I need to see which patch in between them caused the size change.
I cannot reproduce your results on current master branch:
SHA1:d22c8be964a870f59d2fdab6c67cefa0c4799364for this series applied.
echo $SOURCE_DATE_EPOCH
1567523778
./tools/buildman/buildman.py-b HEAD --count=3 ls1043 --output-dir=../BUILD/ --force-build -CveE
./tools/buildman/buildman.py-b HEAD --count=3 ls1043 --output-dir=../BUILD/ -SsdelJust gives me some warnings (without the size difference):
aarch64: w+ ls1043aqds_nand ls1043ardb_nand ls1043aqds_sdcard_qspi ls1043aqds_sdcard_ifc ls1043ardb_nand_SECURE_BOOT ls1043ardb_sdcard ls1043ardb_sdcard_SECURE_BOOT +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) ===================== WARNING ====================== +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_SPI_FLASH. Please update +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_SPI_FLASH before the v2019.07 release. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) Failure to update by the deadline may result in board removal. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) See doc/driver-model/MIGRATION.txt for more info. +(ls1043aqds_nand,ls1043ardb_nand,ls1043ardb_nand_SECURE_BOOT,ls1043aqds_sdcard_ifc,ls1043aqds_sdcard_qspi,ls1043ardb_sdcard,ls1043ardb_sdcard_SECURE_BOOT) ==================================================== +(ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_MMC. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_DM_MMC before the v2019.04 release. +(ls1043ardb_sdcard_SECURE_BOOT) This board does not use CONFIG_DM_USB. Please update +(ls1043ardb_sdcard_SECURE_BOOT) the board to use CONFIG_DM_USB before the v2019.07 release.Quoted 8 lines
Am I doing something wrong? Or am I missing any extra switches for buildman?
And I don't know why the ' -b HEAD..HEAD~~~ ' option returns:
Range 'HEAD..HEAD~~~' has no commits , as I'm able to use HEAD
with -b switch and count=X ?You should see output like (grabbing from a currently open log):
01: i2c: mxc: addCONFIG_CLKsupport
aarch64: w+ls1043aqds_nandls1043ardb_nand
...
17: Merge tag 'for-v2019.10-v2' of
https://gitlab.denx.de/u-boot/custodians/u-boot-i2c ...
Quoted 10 lines
when it's run right and comparing points A and Z. As far as I can tell, it's really important for the upstream tracking part (as far as git branches goes) to be right, for this to work. So if you for example create a "SPI-conversion" branch off of master, and in turn master tracks origin/master, if you 'git merge SPI-conversion' into master then buildman --step 0 -b master does what I was talking about. Telling git "HEAD..HEAD~~~" is backwards? Play around with 'git log --oneline RANGE' to see what you need to say to get what you want.
Just for the record:
rm -rf ../BUILD./tools/buildman/buildman.py -b HEAD --count=4 ls1043 --output-dir=../BUILD/ --force-build -CveE
./tools/buildman/buildman.py -b HEAD --count=4 ls1043 --output-dir=../BUILD/ -Ssdel
And I can reproduce the errors.
(Fix is under testing now).
Thanks Tom for help with setting up the test setup.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190904/a84d641d/attachment.sig>