Add PDC Global and AOSS reset support
v2 cover Add PDC Global and AOSS reset support
This patch series adds PDC Global and AOSS reset support on SC7180 SoCs.
v2:
* Addressed Philipp's review comments
Sibi Sankar (2):
dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
dt-bindings: reset: pdc: Add PDC Global binding for SC7180 SoCs
Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH RESEND v2 1/2 dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Add SC7180 AOSS reset to the list of possible bindings.
--- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +2 -2
@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of: + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" - reg: Usage: required
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Philipp Zabel
maintainerRe: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Quoted 12 lines · Sibi Sankar
Add SC7180 AOSS reset to the list of possible bindings.
Signed-off-by Sibi Sankar <[email protected]>--- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +0
-0
Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt Required properties: · line 12
Quoted 7 lines
Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +2
-2@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of: + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
Should this emphasize that the common sdm845 compatible always has to be included?
+ Definition: must be:
+ "qcom,sdm845-aoss-cc" for SDM845 or
+ "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" for SC7180
or like the qcom,kpss-gcc bindings:
+ Definition: should be one of the following. The generic
compatible
+ "qcom,sdm845-aoss-cc" should also be
included.
+ "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
+
"qcom,sdm845-aoss-cc"
regards
Philipp
Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Hey Philipp,
Thanks for the review!
Quoted 24 lines · Philipp Zabel
Quoted 12 lines · Sibi Sankar
Add SC7180 AOSS reset to the list of possible bindings.
Signed-off-by Sibi Sankar <[email protected]>--- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +0
-0Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt Required properties: · line 12
Quoted 7 lines
Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +2
-2@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of: + "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"Should this emphasize that the common sdm845 compatible always has to be included?
Review
Quoted 2 lines
(quoted diff) +2
-0+ Definition: must be: + "qcom,sdm845-aoss-cc" for SDM845 or
can we drop the "or" since
we would need to keep adding
it in the future.
Review
Quoted 1 line
(quoted diff) +1
-0+ "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" for SC7180
I prefer ^^ approach for the
reasons stated below.
Review
Quoted 9 lines
or like the qcom,kpss-gcc bindings:
(quoted diff) +1
-0+ Definition: should be one of the following. The genericcompatible
(quoted diff) +1
-0+ "qcom,sdm845-aoss-cc" should also beincluded.
(quoted diff) +2
-0+ "qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" +
It is extremely unlikely that
future SoCs would maintain same
number of reset lines/offsets
due to the constant flux in
remote processors being added
to the SoCs. So a generic
compatible might not make sense
here.
Quoted 4 lines
"qcom,sdm845-aoss-cc"regards
Philipp
Signature · 3 lines
-- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
In reply to Sibi SankarQuoting Sibi Sankar (2019-08-24 08:24:10)
Quoted 5 lines
Add SC7180 AOSS reset to the list of possible bindings.
Signed-off-by Sibi Sankar <[email protected]>--- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++--
Can you convert this binding to YAML/JSON schema? Would help to describe the 'one of' requirement below in a more structured way.
Quoted 13 lines
1 file changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +1
-2@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of:
Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Hey Stephen,
Thanks for the review!
Quoted 9 lines · Stephen Boyd
Quoting Sibi Sankar (2019-08-24 08:24:10)
Quoted 5 lines
Add SC7180 AOSS reset to the list of possible bindings.
Signed-off-by Sibi Sankar <[email protected]>--- Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++--Can you convert this binding to YAML/JSON schema? Would help to describe the 'one of' requirement below in a more structured way.
yeah converting them shouldn't
take time but 'oneof' isn't the
requirement here. We want to
specify that sc7180 should
continue to use the sdm845
compatible since the offset/
num of reset are identical.
Quoted 14 lines
Quoted 14 lines
1 file changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt +1
-2@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-aoss-cc" + Definition: must be one of:
Signature · 3 lines
-- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH RESEND v2 2/2 dt-bindings: reset: pdc: Add PDC Global binding for SC7180 SoCs
In reply to Sibi SankarAdd SC7180 PDC global to the list of possible bindings.
--- Documentation/devicetree/bindings/reset/qcom,pdc-global.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/qcom,pdc-global.txt +2 -2
@@ -8,8 +8,8 @@ Required properties: - compatible: Usage: required Value type: <string> - Definition: must be: - "qcom,sdm845-pdc-global" + Definition: must be one of: + "qcom,sc7180-pdc-global", "qcom,sdm845-pdc-global" - reg: Usage: required
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project