Skip to contentSkip to conversation

PCI: mediatek: Remove surplus return from a void function

PATCH In review Krzysztof Wilczynski 2 participants 2 messages Aug 25, 2019 – Aug 27, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: mediatek: Remove surplus return from a void function

Remove unnecessary empty return statement at the
end of a void function mtk_pcie_intr_handler() in
the drivers/pci/controller/pcie-mediatek.c.

The surplus return statement was added as part of
the work in commit 42fe2f91b4eb ("PCI: mediatek:
Implement chained IRQ handling setup").

---
 drivers/pci/controller/pcie-mediatek.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-mediatek.c +0 -2
index 3eaa7081ab2a..626a7c352dfd 100644
@@ -635,8 +635,6 @@ static void mtk_pcie_intr_handler(struct irq_desc *desc)
 	}
 
 	chained_irq_exit(irqchip, desc);
-
-	return;
 }
 
 static int mtk_pcie_setup_irq(struct mtk_pcie_port *port,
Signature · 1 line
2.22.1
#1 lore raw
Quoted 9 lines · Krzysztof Wilczynski

Remove unnecessary empty return statement at the
end of a void function mtk_pcie_intr_handler() in
the drivers/pci/controller/pcie-mediatek.c.

The surplus return statement was added as part of
the work in commit 42fe2f91b4eb ("PCI: mediatek:
Implement chained IRQ handling setup").

I squashed this together with the other patch doing the same thing. If it causes any conflict with Lorenzo's branches, I'll resolve it when merging.

Quoted 20 lines
---
 drivers/pci/controller/pcie-mediatek.c | 2 --
 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-mediatek.c +0 -2
index 3eaa7081ab2a..626a7c352dfd 100644
@@ -635,8 +635,6 @@ static void mtk_pcie_intr_handler(struct irq_desc *desc)
 	}
 
 	chained_irq_exit(irqchip, desc);
-
-	return;
 }
 
 static int mtk_pcie_setup_irq(struct mtk_pcie_port *port,
Signature · 1 line
2.22.1