Skip to contentSkip to conversation

MAINTAINERS: fix style in KEYS-TRUSTED entry

PATCH RESEND In review Lukas Bulwahn 2 participants 3 messages Aug 25, 2019 – Sep 2, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 MAINTAINERS: fix style in KEYS-TRUSTED entry

Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as further maintainer to the KEYS-TRUSTED section entry.

In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: MAINTAINERS entries use one tab after TYPE:
#8581: FILE: MAINTAINERS:8581:
+M: Jarkko Sakkinen <[email protected]>

The issue was detected when writing a script that parses MAINTAINERS.

Fixes 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")

---
v1: https://lore.kernel.org/patchwork/patch/1040412/
- Joe Perches clarified that this is a style defect.

v2: applies cleanly to v5.1-rc4 and next-20190412

v2-resend: applies cleanly to v5.3-rc5 and next-20190823

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 43604d6ab96c..6cb9a4927da8 100644
@@ -8937,7 +8937,7 @@ F:	security/keys/encrypted-keys/
 
 KEYS-TRUSTED
 M:	James Bottomley <[email protected]>
-M:      Jarkko Sakkinen <[email protected]>
+M:	Jarkko Sakkinen <[email protected]>
 M:	Mimi Zohar <[email protected]>
 L:	[email protected]
 L:	[email protected]
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Lukas Bulwahn

Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as further maintainer to the KEYS-TRUSTED section entry.

In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:

Quoted 8 lines

WARNING: MAINTAINERS entries use one tab after TYPE:
#8581: FILE: MAINTAINERS:8581:
+M: Jarkko Sakkinen <[email protected]>

The issue was detected when writing a script that parses MAINTAINERS.

Fixes 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")

/Jarkko

#2 lore raw
Quoted 10 lines · Jarkko Sakkinen
Quoted 9 lines · Lukas Bulwahn

Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as further maintainer to the KEYS-TRUSTED section entry.

In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: MAINTAINERS entries use one tab after TYPE:
#8581: FILE: MAINTAINERS:8581:
+M: Jarkko Sakkinen <[email protected]>

Quoted 6 lines
Quoted 4 lines

The issue was detected when writing a script that parses MAINTAINERS.

Fixes 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")

Including to my v5.4 PR.

/Jarkko