Skip to contentSkip to conversation

csky: Fixup 610 vipt cache flush mechanism

PATCH Superseded [email protected] 2 participants 3 messages Aug 22, 2019 – Aug 26, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH v2 1/1 csky: Fixup 610 vipt cache flush mechanism

From: Guo Ren <[email protected]>

610 has vipt aliasing issue, so we need to finish the cache flush apis mentioned in cachetlb.rst to avoid data corruption.

Here is the list of modified apis in the patch:

 - flush_kernel_dcache_page      (new add)
 - flush_dcache_mmap_lock        (new add)
 - flush_dcache_mmap_unlock      (new add)
 - flush_kernel_vmap_range       (new add)
 - invalidate_kernel_vmap_range  (new add)
 - flush_anon_page               (new add)
 - flush_cache_range             (new add)
 - flush_cache_vmap              (flush all)
 - flush_cache_vunmap            (flush all)
 - flush_cache_mm                (only dcache flush)
 - flush_icache_page             (just nop)
 - copy_from_user_page           (remove no need flush)
 - copy_to_user_page             (remove no need flush)

Change to V2:
- Fixup compile error with xa_lock*(&mapping->i_pages)

Cc Arnd Bergmann <[email protected]>
Cc Christoph Hellwig <[email protected]>
---
 arch/csky/abiv1/cacheflush.c         | 20 ++++++++++++++++++
 arch/csky/abiv1/inc/abi/cacheflush.h | 41 +++++++++++++++++++++++++-----------
 2 files changed, 49 insertions(+), 12 deletions(-)
arch/csky/abiv1/cacheflush.c +20 -0
index fee99fc..9f1fe80 100644
@@ -54,3 +54,23 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long addr,
 			icache_inv_all();
 	}
 }
+
+void flush_kernel_dcache_page(struct page *page)
+{
+	struct address_space *mapping;
+
+	mapping = page_mapping_file(page);
+
+	if (!mapping || mapping_mapped(mapping))
+		dcache_wbinv_all();
+}
+EXPORT_SYMBOL(flush_kernel_dcache_page);
+
+void flush_cache_range(struct vm_area_struct *vma, unsigned long start,
+	unsigned long end)
+{
+	dcache_wbinv_all();
+
+	if (vma->vm_flags & VM_EXEC)
+		icache_inv_all();
+}
arch/csky/abiv1/inc/abi/cacheflush.h +29 -12

74 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · On Thu, Aug 22, 2019 at 11:05:22AM +0800, [email protected] wrote:

From: Guo Ren <[email protected]>

610 has vipt aliasing issue, so we need to finish the cache flush apis mentioned in cachetlb.rst to avoid data corruption.

Here is the list of modified apis in the patch:

Looks sensible to me, although I can't really verify the details. You might also want to Cc linux-mm.

author maintainer
#2 lore raw

Thx Christoph,

Quoted 11 lines · Christoph Hellwig
Quoted 6 lines · On Thu, Aug 22, 2019 at 11:05:22AM +0800, [email protected] wrote:

From: Guo Ren <[email protected]>

610 has vipt aliasing issue, so we need to finish the cache flush apis mentioned in cachetlb.rst to avoid data corruption.

Here is the list of modified apis in the patch:

Looks sensible to me, although I can't really verify the details. You might also want to Cc linux-mm.

I'll re-send it to linux-mm.

Signature · 4 lines
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/