Skip to contentSkip to conversation

tests/kms_hdmi_inject: update comments mentionning disconnected connectors

PATCH In review Simon Ser 3 participants 3 messages Aug 26, 2019

lore
Share & tools
lore

Simon Ser

author
#0 lore raw

PATCH 1/1 tests/kms_hdmi_inject: update comments mentionning disconnected connectors

Comments say that a connector can only be forced if it's disconnected. This was a wrong assumption which has been fixed, but the comments went out of sync.

Fixes dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
Cc Ville Syrjälä <[email protected]>
---
 tests/kms_hdmi_inject.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
tests/kms_hdmi_inject.c +3 -5
index 521105062dad..d9ab4095b8c5 100644
@@ -34,9 +34,9 @@
 #define VDISPLAY_4K	2160
 
 IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
-		     "expected results by forcing a disconnected HDMI "
-		     "connector with a known EDID and checking that the "
-		     "metadata exposed to user space matches.");
+		     "expected results by forcing a HDMI connector "
+		     "with a known EDID and checking that the metadata "
+		     "exposed to user space matches.");
 
 /**
  * This collection of tests performs EDID and status injection tests. Injection
@@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
  * - 4K modes exposed via KMS
  * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
  *   entries in /proc/asound are verified.
- *
- * Injection is performed on a disconnected connector.
  */
 
 /** get_connector: get the first disconnected HDMI connector */

--
2.23.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Simon Ser

Comments say that a connector can only be forced if it's disconnected. This was a wrong assumption which has been fixed, but the comments went out of sync.

Fixes dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
Cc Ville Syrjälä <[email protected]>
Quoted 32 lines
---
 tests/kms_hdmi_inject.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
tests/kms_hdmi_inject.c +3 -6
index 521105062dad..d9ab4095b8c5 100644
@@ -34,9 +34,9 @@
 #define VDISPLAY_4K	2160
 
 IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
-		     "expected results by forcing a disconnected HDMI "
-		     "connector with a known EDID and checking that the "
-		     "metadata exposed to user space matches.");
+		     "expected results by forcing a HDMI connector "
+		     "with a known EDID and checking that the metadata "
+		     "exposed to user space matches.");
 
 /**
  * This collection of tests performs EDID and status injection tests. Injection
@@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
  * - 4K modes exposed via KMS
  * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
  *   entries in /proc/asound are verified.
- *
- * Injection is performed on a disconnected connector.
  */
 
 /** get_connector: get the first disconnected HDMI connector */
--

2.23.0

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_hdmi_inject: update comments mentionning disconnected connectors

In reply to Simon Ser
== Series Details ==

== Series Details ==

Series: tests/kms_hdmi_inject: update comments mentionning disconnected connectors
URL : https://patchwork.freedesktop.org/series/65795/
State : failure

== Summary ==

Series 65795 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev