Skip to contentSkip to conversation

selftests/bpf: remove wrong nhoff in flow dissector test

PATCH Applied Stanislav Fomichev 3 participants 3 messages Aug 26, 2019 – Aug 27, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: remove wrong nhoff in flow dissector test

.nhoff = 0 is (correctly) reset to ETH_HLEN on the next line so let's drop it.

---
 tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/flow_dissector.c +0 -1
index 6892b88ae065..d2f4a8262200 100644
@@ -344,7 +344,6 @@ struct test tests[] = {
 			.tcp.dest = 8080,
 		},
 		.keys = {
-			.nhoff = 0,
 			.nhoff = ETH_HLEN,
 			.thoff = ETH_HLEN + sizeof(struct iphdr) +
 				sizeof(struct iphdr),
Signature · 1 line
2.23.0.187.g17f5b7556c-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Stanislav Fomichev

.nhoff = 0 is (correctly) reset to ETH_HLEN on the next line so let's drop it.

Quoted 19 lines
---
 tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/flow_dissector.c +0 -2
index 6892b88ae065..d2f4a8262200 100644
@@ -344,7 +344,6 @@ struct test tests[] = {
                        .tcp.dest = 8080,
                },
                .keys = {
-                       .nhoff = 0,
                        .nhoff = ETH_HLEN,
                        .thoff = ETH_HLEN + sizeof(struct iphdr) +
                                sizeof(struct iphdr),
--

2.23.0.187.g17f5b7556c-goog