Skip to contentSkip to conversation

ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

PATCH New Sudeep Holla 5 participants 11 messages Aug 21, 2019 – Aug 27, 2019 Arm/versatile express platform

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
 configs/vexpress_aemv8a_juno_defconfig | 2 +-
 configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +1 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/vexpress_aemv8a_juno_defconfig +1 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
configs/vexpress_aemv8a_semi_defconfig +1 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1

To support KVM, we need to drop at EL2 and not EL1 before we boot Linux kernel. This causes issues on platform with VHE and secondaries booting at EL2 via TF-A PSCI CPU_ON call.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
Cc David Feng <[email protected]>
---
 include/configs/vexpress_aemv8a.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/vexpress_aemv8a.h +0 -1
index 89cd8b550ae6..974647055221 100644
@@ -11,7 +11,6 @@
 #ifndef CONFIG_SEMIHOSTING
 #error CONFIG_TARGET_VEXPRESS64_BASE_FVP requires CONFIG_SEMIHOSTING
 #endif
-#define CONFIG_ARMV8_SWITCH_TO_EL1
 #endif
 
 #define CONFIG_REMAKE_ELF
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1

Quoted 27 lines

Subject: [U-Boot] [PATCH] vexpress/aemv8a: drop
CONFIG_ARMV8_SWITCH_TO_EL1

To support KVM, we need to drop at EL2 and not EL1 before we boot Linux kernel. This causes issues on platform with VHE and secondaries booting at EL2 via TF-A PSCI CPU_ON call.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
Cc David Feng <[email protected]>
---
 include/configs/vexpress_aemv8a.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/vexpress_aemv8a.h +0 -0
index 89cd8b550ae6..974647055221 100644
@@ -11,7 +11,6 @@
 #ifndef CONFIG_SEMIHOSTING
 #error CONFIG_TARGET_VEXPRESS64_BASE_FVP requires

CONFIG_SEMIHOSTING #endif -#define CONFIG_ARMV8_SWITCH_TO_EL1 #endif

Quoted 1 line

#define CONFIG_REMAKE_ELF

Quoted 11 lines

--
2.17.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com %7C68ad94406f6942be9d5408d7265d3489%7C686ea1d3bc2b4c6fa92cd99c 5c301635%7C0%7C0%7C637020054108251189&amp;sdata=k%2B4Fod6oxv 01%2BrKzUmUCR8I5WSVXmiyptJ%2B%2FIzRmlYg%3D&amp;reserved=0

#3 lore raw

PATCH 1/1 vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1

In reply to Sudeep Holla
Quoted 10 lines · Sudeep Holla

To support KVM, we need to drop at EL2 and not EL1 before we boot Linux kernel. This causes issues on platform with VHE and secondaries booting at EL2 via TF-A PSCI CPU_ON call.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
Cc David Feng <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/f61a3f21/attachment.sig>
#4 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

In reply to Sudeep Holla
Quoted 62 lines

Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
configs/vexpress_aemv8a_juno_defconfig | 2 +-
configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +0 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000

debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_juno_defconfig +0 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw

rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_semi_defconfig +0 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
Quoted 6 lines

debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

Nitpick: this will be no early print when booting older version kernel.

Quoted 11 lines

--
2.17.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5 c301635%7C0%7C0%7C637020053985296717&amp;sdata=eTWujuzFpTwWil xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&amp;reserved=0

#5 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

Quoted 62 lines · Peng Fan
Quoted 62 lines

Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
configs/vexpress_aemv8a_juno_defconfig | 2 +-
configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +0 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000

debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_juno_defconfig +0 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw

rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_semi_defconfig +0 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
Quoted 9 lines
Quoted 6 lines

debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

Quoted 3 lines

Nitpick: this will be no early print when booting older version kernel.

Note also that the -dram platform is no longer used or tested. I'll send a patch to remove it.

Quoted 17 lines
Quoted 7 lines

--
2.17.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d

Quoted 4 lines

enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5 c301635%7C0%7C0%7C637020053985296717&amp;sdata=eTWujuzFpTwWil xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&amp;reserved=0

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#6 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

Quoted 73 lines · Ryan Harkin
Quoted 62 lines · Peng Fan
Quoted 62 lines

Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
configs/vexpress_aemv8a_juno_defconfig | 2 +-
configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +0 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000

debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_juno_defconfig +0 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw

rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_semi_defconfig +0 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
Quoted 9 lines
Quoted 6 lines

debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

Quoted 9 lines
Quoted 3 lines

Nitpick: this will be no early print when booting older version kernel.

Note also that the -dram platform is no longer used or tested. I'll send a patch to remove it.

Ah OK, I was about to try that on FVP but then saw -semihosting one. Thanks for the review. I assume you will post on top of my patch or do you need me to drop changes in -dram defconfig and post v2 ?

--
Regards,
Sudeep

#7 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

Quoted 82 lines · Sudeep Holla
Quoted 3 lines · Ryan Harkin
Quoted 1 line · Peng Fan
Quoted 1 line

Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace

earlyprintk

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with

earlycon

Quoted 73 lines
Quoted 58 lines
Quoted 58 lines

which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
configs/vexpress_aemv8a_juno_defconfig | 2 +-
configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +0 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000

debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_juno_defconfig +0 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw

rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_semi_defconfig +0 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
Quoted 9 lines
Quoted 6 lines

debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

Quoted 3 lines

Nitpick: this will be no early print when booting older version kernel.

Quoted 9 lines
Quoted 1 line

Note also that the -dram platform is no longer used or tested. I'll send

a

Quoted 2 lines

patch to remove it.

Ah OK, I was about to try that on FVP but then saw -semihosting one. Thanks for the review. I assume you will post on top of my patch or do you need me to drop changes in -dram defconfig and post v2 ?

It's OK, go ahead with your patch and I'll send mine after it's merged.

Quoted 5 lines

--
Regards,
Sudeep

#8 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

In reply to Peng Fan
Quoted 71 lines · Peng Fan
Quoted 62 lines

Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Cc Ryan Harkin <[email protected]>
Cc Liviu Dudau <[email protected]>
Cc Linus Walleij <[email protected]>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
configs/vexpress_aemv8a_juno_defconfig | 2 +-
configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
configs/vexpress_aemv8a_dram_defconfig +0 -1
index 2ff9e4b9f291..51860da387da 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000

debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_juno_defconfig +0 -1
index fd306f9f6bf0..0823d17c1158 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw

rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

configs/vexpress_aemv8a_semi_defconfig +0 -1
index bff52f703836..db5ad3dfa5a4 100644
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
Quoted 6 lines

debug user_debug=31 loglevel=9" +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
# CONFIG_USE_BOOTCOMMAND is not set
# CONFIG_DISPLAY_CPUINFO is not set
# CONFIG_DISPLAY_BOARDINFO is not set

Quoted 1 line

Nitpick: this will be no early print when booting older version kernel.

Indeed, thanks for the review.

--
Regards,
Sudeep

#10 lore raw

PATCH 1/1 ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

In reply to Sudeep Holla
Quoted 10 lines · Sudeep Holla

earlyprintk no longer works on arm64 platforms. Replace it with earlycon which works fine.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/d566c194/attachment.sig>