Skip to contentSkip to conversation

Kconfig: Varios: Fix more SPL, TPL dependencies

PATCH New Adam Ford 2 participants 2 messages Aug 24, 2019 – Aug 27, 2019

Subsystems (3)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 Kconfig: Varios: Fix more SPL, TPL dependencies

Several options are presenting themselves on a various boards where the options are clearly not used. (ie, SPL/TPL options when SPL or TPL are not defined)

This patch is not attempting to be a complete list of items, but more like low hanging fruit. In some instances, I wasn't sure of DM was required, so I simply made them SPL or TPL.

This patch attempts to reduce some of the menuconfig noise by defining dependencies so they don't appear when not used.

common/spl/Kconfig +1 -0
index 660aa66d84..5b70f1e4ff 100644
@@ -435,6 +435,7 @@ config SPL_HASH_SUPPORT
 
 config TPL_HASH_SUPPORT
 	bool "Support hashing drivers in TPL"
+	depends on TPL
 	select SHA1
 	select SHA256
 	help
drivers/clk/Kconfig +1 -0
index 82cd8f623c..95fe0aea2c 100644
@@ -48,6 +48,7 @@ config CLK_BOSTON
 
 config SPL_CLK_CCF
 	bool "SPL Common Clock Framework [CCF] support "
+	depends on SPL
 	help
 	  Enable this option if you want to (re-)use the Linux kernel's Common
 	  Clock Framework [CCF] code in U-Boot's SPL.
drivers/core/Kconfig +1 -1
index 2d195ae35e..3b95b5387b 100644
@@ -92,7 +92,7 @@ config DM_SEQ_ALIAS
 
 config SPL_DM_SEQ_ALIAS
 	bool "Support numbered aliases in device tree in SPL"
-	depends on DM
+	depends on SPL_DM
 	default n
 	help
 	  Most boards will have a '/aliases' node containing the path to
drivers/misc/Kconfig +2 -0
index cb8b5c04db..8037b6ee2d 100644
@@ -88,6 +88,7 @@ config CROS_EC
 
 config SPL_CROS_EC
 	bool "Enable Chrome OS EC in SPL"
+	depends on SPL
 	help
 	  Enable access to the Chrome OS EC in SPL. This is a separate
 	  microcontroller typically available on a SPI bus on Chromebooks. It
@@ -97,6 +98,7 @@ config SPL_CROS_EC
 
 config TPL_CROS_EC
 	bool "Enable Chrome OS EC in TPL"
+	depends on TPL
 	help
 	  Enable access to the Chrome OS EC in TPL. This is a separate
 	  microcontroller typically available on a SPI bus on Chromebooks. It
drivers/phy/Kconfig +1 -1
index 3942f035eb..02312273e2 100644
@@ -19,7 +19,7 @@ config PHY
 
 config SPL_PHY
 	bool "PHY Core in SPL"
-	depends on DM
+	depends on DM && SPL
 	help
 	  PHY support in SPL.
 
drivers/serial/Kconfig +2 -2
index 8a447fd6e3..ae2d819ba9 100644
@@ -45,7 +45,7 @@ config SERIAL_PRESENT
 
 config SPL_SERIAL_PRESENT
 	bool "Provide a serial driver in SPL"
-	depends on DM_SERIAL
+	depends on DM_SERIAL && SPL
 	default y
 	help
 	  In very space-constrained devices even the full UART driver is too
@@ -55,7 +55,7 @@ config SPL_SERIAL_PRESENT
 
 config TPL_SERIAL_PRESENT
 	bool "Provide a serial driver in TPL"
-	depends on DM_SERIAL
+	depends on DM_SERIAL && TPL
 	default y
 	help
 	  In very space-constrained devices even the full UART driver is too
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Kconfig: Varios: Fix more SPL, TPL dependencies

common/spl/Kconfig

Quoted 15 lines · Adam Ford

Several options are presenting themselves on a various boards where the options are clearly not used. (ie, SPL/TPL options when SPL or TPL are not defined)

This patch is not attempting to be a complete list of items, but more like low hanging fruit. In some instances, I wasn't sure of DM was required, so I simply made them SPL or TPL.

This patch attempts to reduce some of the menuconfig noise by defining dependencies so they don't appear when not used.

common/spl/Kconfig +0 -0
index 660aa66d84..5b70f1e4ff 100644

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/c44f9090/attachment.sig>