Skip to contentSkip to conversation

net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

PATCH Superseded [email protected] 3 participants 9 messages Aug 27, 2019 – Sep 5, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

From: Jiang JunyuX <[email protected]>

X552/557 devices do not enable the queue interrupt mapping, this patch fix the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1
#1 lore raw

Hi, Junyu
Please delete the 'From' line in the commit log. And double check your commit log before you send the patch out!!! And for the discarded the patch, need you set it to 'suspended' in patchwork. And you need to use v2 if you send it again.

Qiming

-----Original Message-----
From: Jiang, JunyuX
Sent: Tuesday, August 27, 2019 12:07 PM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Yang, Qiming <[email protected]>; Jiang, JunyuX <[email protected]>
Subject: [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

From: Jiang JunyuX <[email protected]>

X552/557 devices do not enable the queue interrupt mapping, this patch fix the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:

--
2.17.1

#2 lore raw

PATCH v2 1/1 net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

In reply to [email protected]

X552/557 devices do not enable the queue interrupt mapping, this patch fix the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1
#3 lore raw

Hi,

Quoted 2 lines · Jiang JunyuX

X552/557 devices do not enable the queue interrupt mapping, this patch fix the issue.

Could you elaborate more about the issue that this patch trying to solve?

Quoted 2 lines
Fixes d2e72774e58c ("ixgbe/base: support X550")

Please also cc [email protected] for a fix patch.

Thanks,
Xiaolong

Quoted 31 lines

---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1
#4 lore raw

Hi,

Quoted 1 line

Could you elaborate more about the issue that this patch trying to solve?

this issue is:start l3fwd-power with pf port0 bind to vfio-pci,there was no response when send packets to l3fwd-power in x552/x557.

Quoted 57 lines

-----Original Message-----
From: Ye, Xiaolong
Sent: Tuesday, August 27, 2019 4:08 PM
To: Jiang, JunyuX <[email protected]>
Cc: [email protected]
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

Hi,

Quoted 2 lines · Jiang JunyuX

X552/557 devices do not enable the queue interrupt mapping, this patch fix the issue.

Could you elaborate more about the issue that this patch trying to solve?

Quoted 2 lines
Fixes d2e72774e58c ("ixgbe/base: support X550")

Please also cc [email protected] for a fix patch.

Thanks,
Xiaolong

drivers/net/ixgbe/ixgbe_ethdev.c ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t

Quoted 12 lines

---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +0 -0
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t

direction,

Quoted 20 lines
drivers/net/ixgbe/ixgbe_ethdev.c +3 -2
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
--

2.17.1

#5 lore raw

PATCH v3 1/1 net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

In reply to Jiang JunyuX

Interrupt mode is not working on X552/557 devices because this devices do not enable the queue interrupt mapping, this patch fix the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1
#6 lore raw

PATCH v4 1/1 net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device

Interrupt mode is not working on X552/557 device because this device doesn't enable the queue interrupt mapping, this patch fixed the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1
Acked-by on v4 1/1
#7 lore raw

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device

Quoted 45 lines

-----Original Message-----
From: Jiang, JunyuX
Sent: Wednesday, September 4, 2019 11:32 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Yang, Qiming <[email protected]>; Jiang, JunyuX <[email protected]>; [email protected]
Subject: [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device

Interrupt mode is not working on X552/557 device because this device doesn't enable the queue interrupt mapping, this patch fixed the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +2 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
 direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
drivers/net/ixgbe/ixgbe_ethdev.c +1 -1
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
--
Quoted 1 line

2.17.1

Applied
#8 lore raw

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device

In reply to Jiang JunyuX
Quoted 37 lines · Jiang JunyuX

Interrupt mode is not working on X552/557 device because this device doesn't enable the queue interrupt mapping, this patch fixed the issue.

Fixes d2e72774e58c ("ixgbe/base: support X550")

---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +3 -1
index 03fc1f717..e36e1c58e 100644
@@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
 	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
 			(hw->mac.type == ixgbe_mac_X540) ||
-			(hw->mac.type == ixgbe_mac_X550)) {
+			(hw->mac.type == ixgbe_mac_X550) ||
+			(hw->mac.type == ixgbe_mac_X550EM_x)) {
 		if (direction == -1) {
 			/* other causes */
 			idx = ((queue & 1) * 8);
@@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
 		case ixgbe_mac_82599EB:
 		case ixgbe_mac_X540:
 		case ixgbe_mac_X550:
+		case ixgbe_mac_X550EM_x:
 			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
 			break;
 		default:
Signature · 1 line
2.17.1

Applied to dpdk-next-net-intel with Qiming's ack.