Skip to contentSkip to conversation

drm/msm: Remove Kconfig default

PATCH In review Jordan Crouse 3 participants 4 messages Aug 13, 2019 – Aug 27, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 drm/msm: Remove Kconfig default

Remove the default for CONFIG_DRM_MSM and let the user select the driver manually as one does.

Additionally select QCOM_COMMAND_DB for ARCH_QCOM targets to make sure it doesn't get missed when we need it for a6xx targets.

v2: Move from default 'm' to no default

---

 drivers/gpu/drm/msm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/Kconfig +1 -1
index 9c37e4d..e9160ce 100644
@@ -14,11 +14,11 @@ config DRM_MSM
 	select SHMEM
 	select TMPFS
 	select QCOM_SCM if ARCH_QCOM
+	select QCOM_COMMAND_DB if ARCH_QCOM
 	select WANT_DEV_COREDUMP
 	select SND_SOC_HDMI_CODEC if SND_SOC
 	select SYNC_FILE
 	select PM_OPP
-	default y
 	help
 	  DRM/KMS driver for MSM/snapdragon.
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 2/2 arm: Add DRM_MSM to defconfigs with ARCH_QCOM

Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all ARCH_QCOM enabled defconfigs to restore the previous expected build behavior.

---

 arch/arm/configs/multi_v7_defconfig | 1 +
 arch/arm/configs/qcom_defconfig     | 1 +
 arch/arm64/configs/defconfig        | 1 +
 3 files changed, 3 insertions(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index b0a0568..12dfdab 100644
@@ -635,6 +635,7 @@ CONFIG_DRM_ATMEL_HLCDC=m
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_RCAR_LVDS=y
 CONFIG_DRM_SUN4I=m
+CONFIG_DRM_MSM=m
 CONFIG_DRM_FSL_DCU=m
 CONFIG_DRM_TEGRA=y
 CONFIG_DRM_STM=m
arch/arm/configs/qcom_defconfig +1 -0
index 34433bf..02f1e7b 100644
@@ -147,6 +147,7 @@ CONFIG_REGULATOR_QCOM_SMD_RPM=y
 CONFIG_REGULATOR_QCOM_SPMI=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_DRM=y
+CONFIG_DRM_MSM=m
 CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_FB=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
arch/arm64/configs/defconfig +1 -0
index 1cd66cf..4fec7a9 100644
@@ -531,6 +531,7 @@ CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_SUN4I=m
 CONFIG_DRM_SUN8I_DW_HDMI=m
 CONFIG_DRM_SUN8I_MIXER=m
+CONFIG_DRM_MSM=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_SIMPLE=m
 CONFIG_DRM_SII902X=m
Signature · 1 line
2.7.4
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM

Quoted 5 lines · Jordan Crouse

Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all ARCH_QCOM enabled defconfigs to restore the previous expected build behavior.

I suppose Andy will pick this up?

Yours,
Linus Walleij

#3 lore raw

Re: [PATCH v2 2/2] arm: Add DRM_MSM to defconfigs with ARCH_QCOM

Quoted 6 lines · Linus Walleij
Quoted 4 lines · Jordan Crouse

Now that CONFIG_DRM_MSM is no longer default 'y' add it as a module to all ARCH_QCOM enabled defconfigs to restore the previous expected build behavior.

Quoted 6 lines
Quoted 1 line

I suppose Andy will pick this up?

Not sure why, but this patch isn't in any of my mailboxes. So thanks for the reminder, I've picked it from patchworks for 5.4.

Regards,
Bjorn