Skip to contentSkip to conversation

Only enable the halt poll control MSR if it is supported by the host

PATCH In review Mark Kanda 3 participants 4 messages Jul 17, 2019 – Sep 9, 2019

lore
Share & tools
lore

Mark Kanda

author
#0 lore raw

PATCH v2 1/1 Only enable the halt poll control MSR if it is supported by the host

The halt poll control MSR should only be enabled on hosts which support it.

Fixes ("kvm: i386: halt poll control MSR support")

---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)

---
 target/i386/cpu.c | 1 -
 1 file changed, 1 deletion(-)
target/i386/cpu.c +0 -1
index a8bafdb8b9..543bc25f64 100644
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
     { "kvm-asyncpf", "on" },
     { "kvm-steal-time", "on" },
     { "kvm-pv-eoi", "on" },
-    { "kvm-poll-control", "on" },
     { "kvmclock-stable-bit", "on" },
     { "x2apic", "on" },
     { "acpi", "off" },
Signature · 1 line
2.21.0
author
#1 lore raw

Gentle ping - I would like to confirm this patch is acceptable.

Thanks/regards,
-Mark

Quoted 26 lines · Mark Kanda

The halt poll control MSR should only be enabled on hosts which support it.

Fixes ("kvm: i386: halt poll control MSR support")

---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)

---
  target/i386/cpu.c | 1 -
  1 file changed, 1 deletion(-)
target/i386/cpu.c +0 -1
index a8bafdb8b9..543bc25f64 100644
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
      { "kvm-asyncpf", "on" },
      { "kvm-steal-time", "on" },
      { "kvm-pv-eoi", "on" },
-    { "kvm-poll-control", "on" },
      { "kvmclock-stable-bit", "on" },
      { "x2apic", "on" },
      { "acpi", "off" },
#2 lore raw
Quoted 4 lines · Mark Kanda

Gentle ping - I would like to confirm this patch is acceptable.

Thanks/regards,
-Mark

ACK

Quoted 28 lines · Mark Kanda
Quoted 26 lines

The halt poll control MSR should only be enabled on hosts which support it.

Fixes ("kvm: i386: halt poll control MSR support")

---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)

---
 target/i386/cpu.c | 1 -
 1 file changed, 1 deletion(-)
target/i386/cpu.c +0 -1
index a8bafdb8b9..543bc25f64 100644
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
     { "kvm-asyncpf", "on" },
     { "kvm-steal-time", "on" },
     { "kvm-pv-eoi", "on" },
-    { "kvm-poll-control", "on" },
     { "kvmclock-stable-bit", "on" },
     { "x2apic", "on" },
     { "acpi", "off" },
#3 lore raw
In reply to Mark Kanda
Quoted 1 line · Mark Kanda

Gentle ping - I would like to confirm this patch is acceptable.

Yes, it was squashed in Marcelo's patch (commit
d645e1328726b38b3c79525eb57842ce29c1df7c).

Paolo

Quoted 31 lines

Thanks/regards,
-Mark

Quoted 27 lines · Mark Kanda

The halt poll control MSR should only be enabled on hosts which support it.

Fixes ("kvm: i386: halt poll control MSR support")

---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
---
  target/i386/cpu.c | 1 -

  1 file changed, 1 deletion(-)
target/i386/cpu.c +0 -1
index a8bafdb8b9..543bc25f64 100644
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
       { "kvm-asyncpf", "on" },
       { "kvm-steal-time", "on" },
       { "kvm-pv-eoi", "on" },
-    { "kvm-poll-control", "on" },
       { "kvmclock-stable-bit", "on" },
       { "x2apic", "on" },
       { "acpi", "off" },