kfree_rcu() additions for -rcu
Subsystems (2)
cover kfree_rcu() additions for -rcu
Hi,
This is a series on top of the patch "rcu/tree: Add basic support for kfree_rcu() batching".
It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
Now that kfree_rcu() is handled separately from call_rcu(), we also get rid of kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. This also results in a nice negative delta as well.
Joel Fernandes (Google) (5):
rcu/rcuperf: Add kfree_rcu() performance Tests rcu/tree: Add multiple in-flight batches of kfree_rcu work rcu/tree: Add support for debug_objects debugging for kfree_rcu()
rcu: Remove kfree_rcu() special casing and lazy handling
rcu: Remove kfree_call_rcu_nobatch()
Documentation/RCU/stallwarn.txt | 13 +- .../admin-guide/kernel-parameters.txt | 13 ++ include/linux/rcu_segcblist.h | 2 - include/linux/rcutiny.h | 5 - include/linux/rcutree.h | 1 - include/trace/events/rcu.h | 32 ++-- kernel/rcu/rcu.h | 27 --- kernel/rcu/rcu_segcblist.c | 25 +-- kernel/rcu/rcu_segcblist.h | 25 +-- kernel/rcu/rcuperf.c | 173 +++++++++++++++++- kernel/rcu/srcutree.c | 4 +- kernel/rcu/tiny.c | 29 ++- kernel/rcu/tree.c | 145 ++++++++++----- kernel/rcu/tree.h | 1 - kernel/rcu/tree_plugin.h | 42 +---- kernel/rcu/tree_stall.h | 6 +- 16 files changed, 337 insertions(+), 206 deletions(-)
--
2.23.0.187.g17f5b7556c-goog
Paul E. McKenney
maintainerQuoted 28 lines · Joel Fernandes (Google)
Hi,
This is a series on top of the patch "rcu/tree: Add basic support for
kfree_rcu()batching".It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
Now that
kfree_rcu()is handled separately fromcall_rcu(), we also get rid of kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. This also results in a nice negative delta as well.Joel Fernandes (Google) (5):
rcu/rcuperf: Addkfree_rcu()performance Tests rcu/tree: Add multiple in-flight batches ofkfree_rcuwork rcu/tree: Add support fordebug_objectsdebugging forkfree_rcu()
rcu: Removekfree_rcu()special casing and lazy handling
rcu: Removekfree_call_rcu_nobatch()Documentation/RCU/stallwarn.txt | 13 +- .../admin-guide/kernel-parameters.txt | 13 ++ include/linux/rcu_segcblist.h | 2 - include/linux/rcutiny.h | 5 - include/linux/rcutree.h | 1 - include/trace/events/rcu.h | 32 ++-- kernel/rcu/rcu.h | 27 --- kernel/rcu/rcu_segcblist.c | 25 +-- kernel/rcu/rcu_segcblist.h | 25 +--
Quoted 8 lines
kernel/rcu/rcuperf.c | 173 +++++++++++++++++- kernel/rcu/srcutree.c | 4 +- kernel/rcu/tiny.c | 29 ++- kernel/rcu/tree.c | 145 ++++++++++----- kernel/rcu/tree.h | 1 - kernel/rcu/tree_plugin.h | 42 +---- kernel/rcu/tree_stall.h | 6 +- 16 files changed, 337 insertions(+), 206 deletions(-)
Looks like a 131-line positive delta to me. ;-)
Thanx, Paul
Quoted 38 lines · Paul E. McKenney
Quoted 28 lines · Joel Fernandes (Google)
Hi,
This is a series on top of the patch "rcu/tree: Add basic support for
kfree_rcu()batching".It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
Now that
kfree_rcu()is handled separately fromcall_rcu(), we also get rid of kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. This also results in a nice negative delta as well.Joel Fernandes (Google) (5):
rcu/rcuperf: Addkfree_rcu()performance Tests rcu/tree: Add multiple in-flight batches ofkfree_rcuwork rcu/tree: Add support fordebug_objectsdebugging forkfree_rcu()
rcu: Removekfree_rcu()special casing and lazy handling
rcu: Removekfree_call_rcu_nobatch()Documentation/RCU/stallwarn.txt | 13 +- .../admin-guide/kernel-parameters.txt | 13 ++ include/linux/rcu_segcblist.h | 2 - include/linux/rcutiny.h | 5 - include/linux/rcutree.h | 1 - include/trace/events/rcu.h | 32 ++-- kernel/rcu/rcu.h | 27 --- kernel/rcu/rcu_segcblist.c | 25 +-- kernel/rcu/rcu_segcblist.h | 25 +--Quoted 8 lines
kernel/rcu/rcuperf.c | 173 +++++++++++++++++- kernel/rcu/srcutree.c | 4 +- kernel/rcu/tiny.c | 29 ++- kernel/rcu/tree.c | 145 ++++++++++----- kernel/rcu/tree.h | 1 - kernel/rcu/tree_plugin.h | 42 +---- kernel/rcu/tree_stall.h | 6 +- 16 files changed, 337 insertions(+), 206 deletions(-)
Quoted 1 line
Looks like a 131-line positive delta to me. ;-)
Not if you overlook the rcuperf changes which is just test code. :-D ;-)
thanks,
- Joel
Paul E. McKenney
maintainerQuoted 39 lines · Joel Fernandes
Quoted 38 lines · Paul E. McKenney
Quoted 36 lines · Joel Fernandes (Google)
Hi,
This is a series on top of the patch "rcu/tree: Add basic support for
kfree_rcu()batching".It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
Now that
kfree_rcu()is handled separately fromcall_rcu(), we also get rid of kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. This also results in a nice negative delta as well.Joel Fernandes (Google) (5):
rcu/rcuperf: Addkfree_rcu()performance Tests rcu/tree: Add multiple in-flight batches ofkfree_rcuwork rcu/tree: Add support fordebug_objectsdebugging forkfree_rcu()
rcu: Removekfree_rcu()special casing and lazy handling
rcu: Removekfree_call_rcu_nobatch()Documentation/RCU/stallwarn.txt | 13 +- .../admin-guide/kernel-parameters.txt | 13 ++ include/linux/rcu_segcblist.h | 2 - include/linux/rcutiny.h | 5 - include/linux/rcutree.h | 1 - include/trace/events/rcu.h | 32 ++-- kernel/rcu/rcu.h | 27 --- kernel/rcu/rcu_segcblist.c | 25 +-- kernel/rcu/rcu_segcblist.h | 25 +-- kernel/rcu/rcuperf.c | 173 +++++++++++++++++- kernel/rcu/srcutree.c | 4 +- kernel/rcu/tiny.c | 29 ++- kernel/rcu/tree.c | 145 ++++++++++----- kernel/rcu/tree.h | 1 - kernel/rcu/tree_plugin.h | 42 +---- kernel/rcu/tree_stall.h | 6 +- 16 files changed, 337 insertions(+), 206 deletions(-)
Quoted 3 lines
Quoted 1 line
Looks like a 131-line positive delta to me. ;-)
Not if you overlook the rcuperf changes which is just test code. :-D ;-)
Which suggests that you should move the "nice negative delta" comment to the commits that actually have nice negative deltas. ;-)
Thanx, Paul
Quoted 40 lines · Paul E. McKenney
Quoted 39 lines · Joel Fernandes
Quoted 38 lines · Paul E. McKenney
Quoted 36 lines · Joel Fernandes (Google)
Hi,
This is a series on top of the patch "rcu/tree: Add basic support for
kfree_rcu()batching".It adds performance tests, some clean ups and removal of "lazy" RCU callbacks.
Now that
kfree_rcu()is handled separately fromcall_rcu(), we also get rid of kfree "lazy" handling from tree RCU as suggested by Paul which will be unused. This also results in a nice negative delta as well.Joel Fernandes (Google) (5):
rcu/rcuperf: Addkfree_rcu()performance Tests rcu/tree: Add multiple in-flight batches ofkfree_rcuwork rcu/tree: Add support fordebug_objectsdebugging forkfree_rcu()
rcu: Removekfree_rcu()special casing and lazy handling
rcu: Removekfree_call_rcu_nobatch()Documentation/RCU/stallwarn.txt | 13 +- .../admin-guide/kernel-parameters.txt | 13 ++ include/linux/rcu_segcblist.h | 2 - include/linux/rcutiny.h | 5 - include/linux/rcutree.h | 1 - include/trace/events/rcu.h | 32 ++-- kernel/rcu/rcu.h | 27 --- kernel/rcu/rcu_segcblist.c | 25 +-- kernel/rcu/rcu_segcblist.h | 25 +-- kernel/rcu/rcuperf.c | 173 +++++++++++++++++- kernel/rcu/srcutree.c | 4 +- kernel/rcu/tiny.c | 29 ++- kernel/rcu/tree.c | 145 ++++++++++----- kernel/rcu/tree.h | 1 - kernel/rcu/tree_plugin.h | 42 +---- kernel/rcu/tree_stall.h | 6 +- 16 files changed, 337 insertions(+), 206 deletions(-)
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Looks like a 131-line positive delta to me. ;-)
Not if you overlook the rcuperf changes which is just test code. :-D ;-)
Which suggests that you should move the "nice negative delta" comment to the commits that actually have nice negative deltas. ;-)
Will do!
thanks,
- Joel