net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
Subsystems (5)
PATCH 1/1 net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
From: Chen-Yu Tsai <[email protected]>
The devicetree binding lists the phy phy as optional. As such, the driver should not bail out if it can't find a regulator. Instead it should just skip the remaining regulator related code and continue on normally.
Skip the remainder of phy_power_on() if a regulator supply isn't available. This also gets rid of the bogus return code.
---
On a separate note, maybe we should add this file to the Rockchip entry in MAINTAINERS?
--- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +2 -4
@@ -1194,10 +1194,8 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)int ret;struct device *dev = &bsp_priv->pdev->dev; -if (!ldo) { -dev_err (dev,"no regulator found\n" ); -return -1 ; - } +if (!ldo) +return 0 ;if (enable) { ret =regulator_enable (ldo);
Signature · 1 line
2.20.1
David Miller
maintainerFrom: Chen-Yu Tsai <[email protected]>
Date: Thu, 29 Aug 2019 11:17:24 +0800
Quoted 7 lines
From: Chen-Yu Tsai <[email protected]>
The devicetree binding lists the phy phy as optional. As such, the driver should not bail out if it can't find a regulator. Instead it should just skip the remaining regulator related code and continue on normally.
Quoted 5 lines
Skip the remainder of
phy_power_on()if a regulator supply isn't available. This also gets rid of the bogus return code.Fixes 2e12f536635f ("net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator")Signed-off-by Chen-Yu Tsai <[email protected]>
Applied and queued up for -stable.
Quoted 2 lines
On a separate note, maybe we should add this file to the Rockchip entry in
MAINTAINERS?
Yes, probably.
Thanks.