Skip to contentSkip to conversation

Remove broken defconfigs

PATCH New Thomas Petazzoni 2 participants 9 messages Aug 29, 2019 – Sep 1, 2019

lore
Share & tools
lore
#0 lore raw

cover Remove broken defconfigs

Hello,

This patch series removes a number of defconfigs which currently fail to build and have not been fixed. Since we're about to release 2019.08, we need to get rid of them.

- ts4800 doesn't build because the kernel is too old to build with gcc 8.x. The original submitter has not replied to the several pings, including to the patch proposing to add him as a contact for this defconfig in our DEVELOPERS file.

- all the other defconfigs do not build because ATF needs to build a piece of ARM32 bare-metal code, but since the system is ARM64, Buildroot only provides an ARM64 toolchain. The solution is to create a separate Buildroot package for an ARM32 bare-metal toolchain. This has been discussed on the list, but need some effort that does not fit before 2019.08 is released.

Best regards,

Thomas Petazzoni

Thomas Petazzoni (7):
configs/ts4800: remove defconfig
boot/ts4800-mrboot: remove package
configs/nanopc_t4: remove defconfig
configs/nanopi_neo4: remove defconfig
configs/nanopi_m4: remove defconfig
configs/pine64_rockpro64: remove defconfig
configs/radxa_rock_pi4: remove defconfig

 .gitlab-ci.yml                              |  6 ---
 Config.in.legacy                            |  8 +++
 DEVELOPERS                                  | 10 ----
 board/friendlyarm/nanopc-t4/extlinux.conf   |  4 --
 board/friendlyarm/nanopc-t4/genimage.cfg    | 22 ---------
 board/friendlyarm/nanopc-t4/post-build.sh   |  8 ---
 board/friendlyarm/nanopc-t4/readme.txt      | 49 -------------------
 board/friendlyarm/nanopi-m4/extlinux.conf   |  4 --
 board/friendlyarm/nanopi-m4/genimage.cfg    | 22 ---------
 board/friendlyarm/nanopi-m4/post-build.sh   |  8 ---
 board/friendlyarm/nanopi-m4/readme.txt      | 45 -----------------
 board/friendlyarm/nanopi-neo4/extlinux.conf |  4 --
 board/friendlyarm/nanopi-neo4/genimage.cfg  | 22 ---------
 board/friendlyarm/nanopi-neo4/post-build.sh |  9 ----
 board/friendlyarm/nanopi-neo4/readme.txt    | 53 --------------------
 board/pine64/rockpro64/extlinux.conf        |  4 --
 board/pine64/rockpro64/genimage.cfg         | 22 ---------
 board/pine64/rockpro64/post-build.sh        |  9 ----
 board/pine64/rockpro64/readme.txt           | 51 -------------------
 board/radxa/rock-pi4/extlinux.conf          |  4 --
 board/radxa/rock-pi4/genimage.cfg           | 22 ---------
 board/radxa/rock-pi4/post-build.sh          |  9 ----
 board/radxa/rock-pi4/readme.txt             | 51 -------------------
 board/technologic/ts4800/genimage.cfg       | 37 --------------
 board/technologic/ts4800/linux.fragment     |  3 --
 board/technologic/ts4800/post-image.sh      | 19 --------
 board/technologic/ts4800/readme.txt         | 50 -------------------
 boot/Config.in                              |  1 -
 boot/ts4800-mbrboot/Config.in               |  7 ---
 boot/ts4800-mbrboot/ts4800-mbrboot.hash     |  2 -
 boot/ts4800-mbrboot/ts4800-mbrboot.mk       | 21 --------
 configs/nanopc_t4_defconfig                 | 54 ---------------------
 configs/nanopi_m4_defconfig                 | 54 ---------------------
 configs/nanopi_neo4_defconfig               | 54 ---------------------
 configs/pine64_rockpro64_defconfig          | 54 ---------------------
 configs/radxa_rock_pi4_defconfig            | 54 ---------------------
 configs/ts4800_defconfig                    | 22 ---------
 37 files changed, 8 insertions(+), 870 deletions(-)
 delete mode 100644 board/friendlyarm/nanopc-t4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopc-t4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopc-t4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopc-t4/readme.txt
 delete mode 100644 board/friendlyarm/nanopi-m4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopi-m4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopi-m4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopi-m4/readme.txt
 delete mode 100644 board/friendlyarm/nanopi-neo4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopi-neo4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopi-neo4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopi-neo4/readme.txt
 delete mode 100644 board/pine64/rockpro64/extlinux.conf
 delete mode 100644 board/pine64/rockpro64/genimage.cfg
 delete mode 100755 board/pine64/rockpro64/post-build.sh
 delete mode 100644 board/pine64/rockpro64/readme.txt
 delete mode 100644 board/radxa/rock-pi4/extlinux.conf
 delete mode 100644 board/radxa/rock-pi4/genimage.cfg
 delete mode 100755 board/radxa/rock-pi4/post-build.sh
 delete mode 100644 board/radxa/rock-pi4/readme.txt
 delete mode 100644 board/technologic/ts4800/genimage.cfg
 delete mode 100644 board/technologic/ts4800/linux.fragment
 delete mode 100755 board/technologic/ts4800/post-image.sh
 delete mode 100644 board/technologic/ts4800/readme.txt
 delete mode 100644 boot/ts4800-mbrboot/Config.in
 delete mode 100644 boot/ts4800-mbrboot/ts4800-mbrboot.hash
 delete mode 100644 boot/ts4800-mbrboot/ts4800-mbrboot.mk
 delete mode 100644 configs/nanopc_t4_defconfig
 delete mode 100644 configs/nanopi_m4_defconfig
 delete mode 100644 configs/nanopi_neo4_defconfig
 delete mode 100644 configs/pine64_rockpro64_defconfig
 delete mode 100644 configs/radxa_rock_pi4_defconfig
 delete mode 100644 configs/ts4800_defconfig
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/7 configs/ts4800: remove defconfig

This defconfig has been failing to build since we switched the default gcc version to gcc 8.x, as the Linux kernel version is too old and doesn't contain the necessary fixes to build with gcc >= 8.x.

Despite several pings to the original submitter of the defconfig (which is not listed in MAINTAINERS), no fix has been sent, so it is time to drop this defconfig before the 2019.08 release.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489442

---
 .gitlab-ci.yml                          |  1 -
 board/technologic/ts4800/genimage.cfg   | 37 ------------------
 board/technologic/ts4800/linux.fragment |  3 --
 board/technologic/ts4800/post-image.sh  | 19 ----------
 board/technologic/ts4800/readme.txt     | 50 -------------------------
 configs/ts4800_defconfig                | 22 -----------
 6 files changed, 132 deletions(-)
 delete mode 100644 board/technologic/ts4800/genimage.cfg
 delete mode 100644 board/technologic/ts4800/linux.fragment
 delete mode 100755 board/technologic/ts4800/post-image.sh
 delete mode 100644 board/technologic/ts4800/readme.txt
 delete mode 100644 configs/ts4800_defconfig
.gitlab-ci.yml +0 -1
index 28824cc722..0024e33ae0 100644
@@ -318,7 +318,6 @@ solidrun_macchiatobin_marvell_defconfig: { extends: .defconfig }
 stm32f429_disco_defconfig: { extends: .defconfig }
 stm32f469_disco_defconfig: { extends: .defconfig }
 toradex_apalis_imx6_defconfig: { extends: .defconfig }
-ts4800_defconfig: { extends: .defconfig }
 ts4900_defconfig: { extends: .defconfig }
 ts5500_defconfig: { extends: .defconfig }
 ts7680_defconfig: { extends: .defconfig }
board/technologic/ts4800/genimage.cfg deleted +0 -37
deleted file mode 100644
index 2070cc5040..0000000000
@@ -1,37 +0,0 @@
-image boot.vfat {
-        vfat {
-                files = {
-                        "zImage",
-                        "imx51-ts4800.dtb"
-                }
-        }
-        size = 8M
-}
-
-image sdcard.img {
-        hdimage {
-        }
-
-        partition mbrboot {
-                in-partition-table = "no"
-                image = "mbrboot.bin"
-                offset = 0
-        }
-
-        partition uboot {
-                partition-type = 0xda
-                image = "u-boot.bin"
-                size = 256k
-        }
-
-        partition kernel {
-                partition-type = 0xC
-                image = "boot.vfat"
-        }
-
-        partition rootfs {
-                partition-type = 0x83
-                image = "rootfs.ext4"
-                size = 256M
-        }
-}
board/technologic/ts4800/linux.fragment deleted +0 -3
deleted file mode 100644
index 0451c86365..0000000000
@@ -1,3 +0,0 @@
-CONFIG_TOUCHSCREEN_TS4800=y
-CONFIG_TS4800_WATCHDOG=y
-CONFIG_TS4800_IRQ=y
board/technologic/ts4800/post-image.sh deleted +0 -19
deleted file mode 100755
index cc8e5da352..0000000000
@@ -1,19 +0,0 @@
-#!/bin/bash
-#
-# Copyright (C) 2015 Savoir-faire Linux
-# Post image generation script.
-
-BOARD_DIR="$(dirname $0)"
-GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg"
-GENIMAGE_TMP=${BUILD_DIR}/.genimage_tmp
-
-rm -rf ${GENIMAGE_TMP}
-
-${HOST_DIR}/bin/genimage \
-        --config ${GENIMAGE_CFG} \
-        --rootpath ${TARGET_DIR} \
-        --tmppath ${GENIMAGE_TMP} \
-        --inputpath $BINARIES_DIR \
-        --outputpath $BINARIES_DIR
-
-exit $?
board/technologic/ts4800/readme.txt deleted +0 -50

50 lines not on this page · raw message

configs/ts4800_defconfig deleted +0 -22
deleted file mode 100644
index 0999ebcad0..0000000000
@@ -1,22 +0,0 @@
-BR2_arm=y
-BR2_cortex_a8=y
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_6=y
-BR2_ROOTFS_POST_IMAGE_SCRIPT="board/technologic/ts4800/post-image.sh"
-BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.6.3"
-BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
-BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/technologic/ts4800/linux.fragment"
-BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx51-ts4800"
-BR2_PACKAGE_BUSYBOX_WATCHDOG=y
-BR2_TARGET_ROOTFS_EXT2=y
-BR2_TARGET_ROOTFS_EXT2_4=y
-BR2_TARGET_TS4800_MBRBOOT=y
-BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="ts4800"
-BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2016.07"
-BR2_PACKAGE_HOST_DOSFSTOOLS=y
-BR2_PACKAGE_HOST_GENIMAGE=y
-BR2_PACKAGE_HOST_MTOOLS=y
Signature · 1 line
2.21.0
#2 lore raw

PATCH 2/7 boot/ts4800-mrboot: remove package

In reply to Thomas Petazzoni

Since the ts4800_defconfig has been removed, the ts4800-mrboot package is no longer useful, therefore we drop it.

---
 Config.in.legacy                        |  8 ++++++++
 boot/Config.in                          |  1 -
 boot/ts4800-mbrboot/Config.in           |  7 -------
 boot/ts4800-mbrboot/ts4800-mbrboot.hash |  2 --
 boot/ts4800-mbrboot/ts4800-mbrboot.mk   | 21 ---------------------
 5 files changed, 8 insertions(+), 31 deletions(-)
 delete mode 100644 boot/ts4800-mbrboot/Config.in
 delete mode 100644 boot/ts4800-mbrboot/ts4800-mbrboot.hash
 delete mode 100644 boot/ts4800-mbrboot/ts4800-mbrboot.mk
Config.in.legacy +8 -0
index 190b98f5a5..83dce8b3c8 100644
@@ -146,6 +146,14 @@ endif
 
 comment "Legacy options removed in 2019.08"
 
+config BR2_TARGET_TS4800_MBRBOOT
+	bool "ts4800-mbrboot package was removed"
+	select BR2_LEGACY
+	help
+	  The defconfig for the TS4800 platform has been removed, so
+	  the ts4800-mbrboot package, containing the boot code for
+	  this specific platform has been removed as welL.
+
 config BR2_PACKAGE_LIBAMCODEC
 	bool "liamcodec package was removed"
 	select BR2_LEGACY
boot/Config.in +0 -1
index 97bd3de6e9..ac1a997f00 100644
@@ -19,7 +19,6 @@ source "boot/riscv-pk/Config.in"
 source "boot/s500-bootloader/Config.in"
 source "boot/shim/Config.in"
 source "boot/syslinux/Config.in"
-source "boot/ts4800-mbrboot/Config.in"
 source "boot/uboot/Config.in"
 source "boot/vexpress-firmware/Config.in"
 
boot/ts4800-mbrboot/Config.in deleted +0 -7
deleted file mode 100644
index 7ed0b21382..0000000000
@@ -1,7 +0,0 @@
-config BR2_TARGET_TS4800_MBRBOOT
-	bool "ts4800-mbrboot"
-	depends on BR2_ARM_CPU_ARMV7A
-	help
-	  First level bootloader for TS4800 board
-
-	  https://github.com/embeddedarm/ts4800-mbrboot
boot/ts4800-mbrboot/ts4800-mbrboot.hash deleted +0 -2
deleted file mode 100644
index 04e7072810..0000000000
@@ -1,2 +0,0 @@
-# Locally calculated
-sha256 617c70dcf50b7ad35ed3f40666ff2a9a654a5440b522ad73662abdf9f843cee9  ts4800-mbrboot-cf8f7072ed5a4a4e48fcb9841b2e31e519ec5dca.tar.gz
boot/ts4800-mbrboot/ts4800-mbrboot.mk deleted +0 -21
deleted file mode 100644
index 3dde6c6ab3..0000000000
@@ -1,21 +0,0 @@
-################################################################################
-#
-# ts4800-mbrboot
-#
-################################################################################
-
-TS4800_MBRBOOT_VERSION = cf8f7072ed5a4a4e48fcb9841b2e31e519ec5dca
-TS4800_MBRBOOT_SITE = $(call github,embeddedarm,ts4800-mbrboot,$(TS4800_MBRBOOT_VERSION))
-TS4800_MBRBOOT_LICENSE = BSD-2-Clause
-TS4800_MBRBOOT_LICENSE_FILES = LICENSE
-TS4800_MBRBOOT_INSTALL_IMAGES = YES
-
-define TS4800_MBRBOOT_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
-endef
-
-define TS4800_MBRBOOT_INSTALL_IMAGES_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/mbrboot.bin $(BINARIES_DIR)/mbrboot.bin
-endef
-
-$(eval $(generic-package))
Signature · 1 line
2.21.0
#3 lore raw

PATCH 3/7 configs/nanopc_t4: remove defconfig

In reply to Thomas Petazzoni

This defconfig tries to build an ARM Trusted Firmware version that needs an ARM32 toolchain, which is not available as the platform is an ARM64 one. The correct solution for this is to have a package in Buildroot for an ARM32 bare-metal toolchain, but this wasn't done in time for the 2019.08 release.

In order to not release 2019.08 with a broken defconfig, let's remove it. It can be re-added later once the ARM32 bare-metal toolchain problem has been resolved.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489325

---
 .gitlab-ci.yml                            |  1 -
 DEVELOPERS                                |  2 -
 board/friendlyarm/nanopc-t4/extlinux.conf |  4 --
 board/friendlyarm/nanopc-t4/genimage.cfg  | 22 ---------
 board/friendlyarm/nanopc-t4/post-build.sh |  8 ----
 board/friendlyarm/nanopc-t4/readme.txt    | 49 --------------------
 configs/nanopc_t4_defconfig               | 54 -----------------------
 7 files changed, 140 deletions(-)
 delete mode 100644 board/friendlyarm/nanopc-t4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopc-t4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopc-t4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopc-t4/readme.txt
 delete mode 100644 configs/nanopc_t4_defconfig
.gitlab-ci.yml +0 -1
index 0024e33ae0..9de3b2c927 100644
@@ -211,7 +211,6 @@ mx53loco_defconfig: { extends: .defconfig }
 mx6cubox_defconfig: { extends: .defconfig }
 mx6sx_udoo_neo_defconfig: { extends: .defconfig }
 mx6udoo_defconfig: { extends: .defconfig }
-nanopc_t4_defconfig: { extends: .defconfig }
 nanopi_m1_defconfig: { extends: .defconfig }
 nanopi_m1_plus_defconfig: { extends: .defconfig }
 nanopi_m4_defconfig: { extends: .defconfig }
DEVELOPERS +0 -2
index e50ac78ae7..93ae5c50fe 100644
@@ -2096,13 +2096,11 @@ F:	package/wolfssl/
 N:	Shyam Saini <[email protected]>
 F:	board/friendlyarm/nanopi-m4/
 F:	board/friendlyarm/nanopi-neo4/
-F:	board/friendlyarm/nanopc-t4/
 F:	board/olimex/a33_olinuxino/
 F:	board/pine64/rockpro64/
 F:	board/radxa/rock-pi4/
 F:	configs/nanopi_m4_defconfig
 F:	configs/nanopi_neo4_defconfig
-F:	configs/nanopc_t4_defconfig
 F:	configs/olimex_a33_olinuxino_defconfig
 F:	configs/pine64_rockpro64_defconfig
 F:	configs/radxa_rock_pi4_defconfig
board/friendlyarm/nanopc-t4/extlinux.conf deleted +0 -4
deleted file mode 100644
index b09c20db84..0000000000
@@ -1,4 +0,0 @@
-label NanoPc T4
-  kernel /boot/Image
-  devicetree /boot/rk3399-nanopc-t4.dtb
-  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p1 rootwait
board/friendlyarm/nanopc-t4/genimage.cfg deleted +0 -22
deleted file mode 100644
index 6404b0ad3b..0000000000
@@ -1,22 +0,0 @@
-image sdcard.img {
-	hdimage {
-	}
-
-	partition u-boot-spl-dtb {
-		in-partition-table = "no"
-		image = "u-boot-spl-dtb.img"
-		offset = 32K
-	}
-
-	partition u-boot-dtb {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 8M
-		size = 30M
-	}
-
-	partition rootfs {
-		partition-type = 0x83
-		image = "rootfs.ext4"
-	}
-}
board/friendlyarm/nanopc-t4/post-build.sh deleted +0 -8
deleted file mode 100755
index 9b0c4ecc83..0000000000
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-MKIMAGE=$HOST_DIR/bin/mkimage
-BOARD_DIR="$(dirname $0)"
-
-$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
-
-install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/friendlyarm/nanopc-t4/readme.txt deleted +0 -49

49 lines not on this page · raw message

configs/nanopc_t4_defconfig deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.21.0
#4 lore raw

PATCH 4/7 configs/nanopi_neo4: remove defconfig

In reply to Thomas Petazzoni

This defconfig tries to build an ARM Trusted Firmware version that needs an ARM32 toolchain, which is not available as the platform is an ARM64 one. The correct solution for this is to have a package in Buildroot for an ARM32 bare-metal toolchain, but this wasn't done in time for the 2019.08 release.

In order to not release 2019.08 with a broken defconfig, let's remove it. It can be re-added later once the ARM32 bare-metal toolchain problem has been resolved.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489329

---
 .gitlab-ci.yml                              |  1 -
 DEVELOPERS                                  |  2 -
 board/friendlyarm/nanopi-neo4/extlinux.conf |  4 --
 board/friendlyarm/nanopi-neo4/genimage.cfg  | 22 ---------
 board/friendlyarm/nanopi-neo4/post-build.sh |  9 ----
 board/friendlyarm/nanopi-neo4/readme.txt    | 53 --------------------
 configs/nanopi_neo4_defconfig               | 54 ---------------------
 7 files changed, 145 deletions(-)
 delete mode 100644 board/friendlyarm/nanopi-neo4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopi-neo4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopi-neo4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopi-neo4/readme.txt
 delete mode 100644 configs/nanopi_neo4_defconfig
.gitlab-ci.yml +0 -1
index 9de3b2c927..e6b37c43cf 100644
@@ -214,7 +214,6 @@ mx6udoo_defconfig: { extends: .defconfig }
 nanopi_m1_defconfig: { extends: .defconfig }
 nanopi_m1_plus_defconfig: { extends: .defconfig }
 nanopi_m4_defconfig: { extends: .defconfig }
-nanopi_neo4_defconfig: { extends: .defconfig }
 nanopi_neo_defconfig: { extends: .defconfig }
 nexbox_a95x_defconfig: { extends: .defconfig }
 nitrogen6sx_defconfig: { extends: .defconfig }
DEVELOPERS +0 -2
index 93ae5c50fe..731393a346 100644
@@ -2095,12 +2095,10 @@ F:	package/wolfssl/
 
 N:	Shyam Saini <[email protected]>
 F:	board/friendlyarm/nanopi-m4/
-F:	board/friendlyarm/nanopi-neo4/
 F:	board/olimex/a33_olinuxino/
 F:	board/pine64/rockpro64/
 F:	board/radxa/rock-pi4/
 F:	configs/nanopi_m4_defconfig
-F:	configs/nanopi_neo4_defconfig
 F:	configs/olimex_a33_olinuxino_defconfig
 F:	configs/pine64_rockpro64_defconfig
 F:	configs/radxa_rock_pi4_defconfig
board/friendlyarm/nanopi-neo4/extlinux.conf deleted +0 -4
deleted file mode 100644
index 91eef67fb9..0000000000
@@ -1,4 +0,0 @@
-label NanoPi Neo4 linux
-  kernel /boot/Image
-  devicetree /boot/rk3399-nanopi-neo4.dtb
-  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p1 rootwait
board/friendlyarm/nanopi-neo4/genimage.cfg deleted +0 -22
deleted file mode 100644
index b8c1cd5220..0000000000
@@ -1,22 +0,0 @@
-image sdcard.img {
-	hdimage {
-	}
-
-	partition u-boot-tpl-spl-dtb {
-		in-partition-table = "no"
-		image = "u-boot-tpl-spl-dtb.img"
-		offset = 32K
-	}
-
-	partition u-boot-dtb {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 8M
-		size = 30M
-	}
-
-	partition rootfs {
-		partition-type = 0x83
-		image = "rootfs.ext4"
-	}
-}
board/friendlyarm/nanopi-neo4/post-build.sh deleted +0 -9
deleted file mode 100755
index e852ba6adf..0000000000
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-MKIMAGE=$HOST_DIR/bin/mkimage
-BOARD_DIR="$(dirname $0)"
-
-$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-tpl-dtb.bin $BINARIES_DIR/u-boot-tpl-dtb.img
-cat $BINARIES_DIR/u-boot-tpl-dtb.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
-
-install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/friendlyarm/nanopi-neo4/readme.txt deleted +0 -53

53 lines not on this page · raw message

configs/nanopi_neo4_defconfig deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.21.0
#5 lore raw

PATCH 5/7 configs/nanopi_m4: remove defconfig

In reply to Thomas Petazzoni

This defconfig tries to build an ARM Trusted Firmware version that needs an ARM32 toolchain, which is not available as the platform is an ARM64 one. The correct solution for this is to have a package in Buildroot for an ARM32 bare-metal toolchain, but this wasn't done in time for the 2019.08 release.

In order to not release 2019.08 with a broken defconfig, let's remove it. It can be re-added later once the ARM32 bare-metal toolchain problem has been resolved.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489328

---
 .gitlab-ci.yml                            |  1 -
 DEVELOPERS                                |  2 -
 board/friendlyarm/nanopi-m4/extlinux.conf |  4 --
 board/friendlyarm/nanopi-m4/genimage.cfg  | 22 ---------
 board/friendlyarm/nanopi-m4/post-build.sh |  8 ----
 board/friendlyarm/nanopi-m4/readme.txt    | 45 -------------------
 configs/nanopi_m4_defconfig               | 54 -----------------------
 7 files changed, 136 deletions(-)
 delete mode 100644 board/friendlyarm/nanopi-m4/extlinux.conf
 delete mode 100644 board/friendlyarm/nanopi-m4/genimage.cfg
 delete mode 100755 board/friendlyarm/nanopi-m4/post-build.sh
 delete mode 100644 board/friendlyarm/nanopi-m4/readme.txt
 delete mode 100644 configs/nanopi_m4_defconfig
.gitlab-ci.yml +0 -1
index e6b37c43cf..311a3a742b 100644
@@ -213,7 +213,6 @@ mx6sx_udoo_neo_defconfig: { extends: .defconfig }
 mx6udoo_defconfig: { extends: .defconfig }
 nanopi_m1_defconfig: { extends: .defconfig }
 nanopi_m1_plus_defconfig: { extends: .defconfig }
-nanopi_m4_defconfig: { extends: .defconfig }
 nanopi_neo_defconfig: { extends: .defconfig }
 nexbox_a95x_defconfig: { extends: .defconfig }
 nitrogen6sx_defconfig: { extends: .defconfig }
DEVELOPERS +0 -2
index 731393a346..b12cb13ec9 100644
@@ -2094,11 +2094,9 @@ F:	package/ubus/
 F:	package/wolfssl/
 
 N:	Shyam Saini <[email protected]>
-F:	board/friendlyarm/nanopi-m4/
 F:	board/olimex/a33_olinuxino/
 F:	board/pine64/rockpro64/
 F:	board/radxa/rock-pi4/
-F:	configs/nanopi_m4_defconfig
 F:	configs/olimex_a33_olinuxino_defconfig
 F:	configs/pine64_rockpro64_defconfig
 F:	configs/radxa_rock_pi4_defconfig
board/friendlyarm/nanopi-m4/extlinux.conf deleted +0 -4
deleted file mode 100644
index e5861cdcbe..0000000000
@@ -1,4 +0,0 @@
-label NanoPi M4 5.1-rc1
-  kernel /boot/Image
-  devicetree /boot/rk3399-nanopi-m4.dtb
-  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk1p1 rootwait
board/friendlyarm/nanopi-m4/genimage.cfg deleted +0 -22
deleted file mode 100644
index 6404b0ad3b..0000000000
@@ -1,22 +0,0 @@
-image sdcard.img {
-	hdimage {
-	}
-
-	partition u-boot-spl-dtb {
-		in-partition-table = "no"
-		image = "u-boot-spl-dtb.img"
-		offset = 32K
-	}
-
-	partition u-boot-dtb {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 8M
-		size = 30M
-	}
-
-	partition rootfs {
-		partition-type = 0x83
-		image = "rootfs.ext4"
-	}
-}
board/friendlyarm/nanopi-m4/post-build.sh deleted +0 -8
deleted file mode 100755
index 9b0c4ecc83..0000000000
@@ -1,8 +0,0 @@
-#!/bin/sh
-
-MKIMAGE=$HOST_DIR/bin/mkimage
-BOARD_DIR="$(dirname $0)"
-
-$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
-
-install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/friendlyarm/nanopi-m4/readme.txt deleted +0 -45

45 lines not on this page · raw message

configs/nanopi_m4_defconfig deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.21.0
#6 lore raw

PATCH 6/7 configs/pine64_rockpro64: remove defconfig

In reply to Thomas Petazzoni

This defconfig tries to build an ARM Trusted Firmware version that needs an ARM32 toolchain, which is not available as the platform is an ARM64 one. The correct solution for this is to have a package in Buildroot for an ARM32 bare-metal toolchain, but this wasn't done in time for the 2019.08 release.

In order to not release 2019.08 with a broken defconfig, let's remove it. It can be re-added later once the ARM32 bare-metal toolchain problem has been resolved.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489367

---
 .gitlab-ci.yml                       |  1 -
 DEVELOPERS                           |  2 --
 board/pine64/rockpro64/extlinux.conf |  4 ---
 board/pine64/rockpro64/genimage.cfg  | 22 ------------
 board/pine64/rockpro64/post-build.sh |  9 -----
 board/pine64/rockpro64/readme.txt    | 51 --------------------------
 configs/pine64_rockpro64_defconfig   | 54 ----------------------------
 7 files changed, 143 deletions(-)
 delete mode 100644 board/pine64/rockpro64/extlinux.conf
 delete mode 100644 board/pine64/rockpro64/genimage.cfg
 delete mode 100755 board/pine64/rockpro64/post-build.sh
 delete mode 100644 board/pine64/rockpro64/readme.txt
 delete mode 100644 configs/pine64_rockpro64_defconfig
.gitlab-ci.yml +0 -1
index 311a3a742b..85dfe95376 100644
@@ -246,7 +246,6 @@ pandaboard_defconfig: { extends: .defconfig }
 pc_x86_64_bios_defconfig: { extends: .defconfig }
 pc_x86_64_efi_defconfig: { extends: .defconfig }
 pine64_defconfig: { extends: .defconfig }
-pine64_rockpro64_defconfig: { extends: .defconfig }
 pine64_sopine_defconfig: { extends: .defconfig }
 qemu_aarch64_virt_defconfig: { extends: .defconfig }
 qemu_arm_versatile_defconfig: { extends: .defconfig }
DEVELOPERS +0 -2
index b12cb13ec9..15994ceb2d 100644
@@ -2095,10 +2095,8 @@ F:	package/wolfssl/
 
 N:	Shyam Saini <[email protected]>
 F:	board/olimex/a33_olinuxino/
-F:	board/pine64/rockpro64/
 F:	board/radxa/rock-pi4/
 F:	configs/olimex_a33_olinuxino_defconfig
-F:	configs/pine64_rockpro64_defconfig
 F:	configs/radxa_rock_pi4_defconfig
 
 N:	Simon Dawson <[email protected]>
board/pine64/rockpro64/extlinux.conf deleted +0 -4
deleted file mode 100644
index ff196499b0..0000000000
@@ -1,4 +0,0 @@
-label RockPro64 linux
-  kernel /boot/Image
-  devicetree /boot/rk3399-rockpro64.dtb
-  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk0p1 rootwait
board/pine64/rockpro64/genimage.cfg deleted +0 -22
deleted file mode 100644
index b8c1cd5220..0000000000
@@ -1,22 +0,0 @@
-image sdcard.img {
-	hdimage {
-	}
-
-	partition u-boot-tpl-spl-dtb {
-		in-partition-table = "no"
-		image = "u-boot-tpl-spl-dtb.img"
-		offset = 32K
-	}
-
-	partition u-boot-dtb {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 8M
-		size = 30M
-	}
-
-	partition rootfs {
-		partition-type = 0x83
-		image = "rootfs.ext4"
-	}
-}
board/pine64/rockpro64/post-build.sh deleted +0 -9
deleted file mode 100755
index e852ba6adf..0000000000
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-MKIMAGE=$HOST_DIR/bin/mkimage
-BOARD_DIR="$(dirname $0)"
-
-$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-tpl-dtb.bin $BINARIES_DIR/u-boot-tpl-dtb.img
-cat $BINARIES_DIR/u-boot-tpl-dtb.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
-
-install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/pine64/rockpro64/readme.txt deleted +0 -51

51 lines not on this page · raw message

configs/pine64_rockpro64_defconfig deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.21.0
#7 lore raw

PATCH 7/7 configs/radxa_rock_pi4: remove defconfig

In reply to Thomas Petazzoni

This defconfig tries to build an ARM Trusted Firmware version that needs an ARM32 toolchain, which is not available as the platform is an ARM64 one. The correct solution for this is to have a package in Buildroot for an ARM32 bare-metal toolchain, but this wasn't done in time for the 2019.08 release.

In order to not release 2019.08 with a broken defconfig, let's remove it. It can be re-added later once the ARM32 bare-metal toolchain problem has been resolved.

Fixes:

https://gitlab.com/buildroot.org/buildroot/-/jobs/278489410

---
 .gitlab-ci.yml                     |  1 -
 DEVELOPERS                         |  2 --
 board/radxa/rock-pi4/extlinux.conf |  4 ---
 board/radxa/rock-pi4/genimage.cfg  | 22 ------------
 board/radxa/rock-pi4/post-build.sh |  9 -----
 board/radxa/rock-pi4/readme.txt    | 51 ----------------------------
 configs/radxa_rock_pi4_defconfig   | 54 ------------------------------
 7 files changed, 143 deletions(-)
 delete mode 100644 board/radxa/rock-pi4/extlinux.conf
 delete mode 100644 board/radxa/rock-pi4/genimage.cfg
 delete mode 100755 board/radxa/rock-pi4/post-build.sh
 delete mode 100644 board/radxa/rock-pi4/readme.txt
 delete mode 100644 configs/radxa_rock_pi4_defconfig
.gitlab-ci.yml +0 -1
index 85dfe95376..5d42d2a606 100644
@@ -286,7 +286,6 @@ qemu_x86_64_defconfig: { extends: .defconfig }
 qemu_x86_defconfig: { extends: .defconfig }
 qemu_xtensa_lx60_defconfig: { extends: .defconfig }
 qemu_xtensa_lx60_nommu_defconfig: { extends: .defconfig }
-radxa_rock_pi4_defconfig: { extends: .defconfig }
 raspberrypi0_defconfig: { extends: .defconfig }
 raspberrypi0w_defconfig: { extends: .defconfig }
 raspberrypi2_defconfig: { extends: .defconfig }
DEVELOPERS +0 -2
index 15994ceb2d..3df21a78e6 100644
@@ -2095,9 +2095,7 @@ F:	package/wolfssl/
 
 N:	Shyam Saini <[email protected]>
 F:	board/olimex/a33_olinuxino/
-F:	board/radxa/rock-pi4/
 F:	configs/olimex_a33_olinuxino_defconfig
-F:	configs/radxa_rock_pi4_defconfig
 
 N:	Simon Dawson <[email protected]>
 F:	boot/at91bootstrap3/
board/radxa/rock-pi4/extlinux.conf deleted +0 -4
deleted file mode 100644
index f939cf5c56..0000000000
@@ -1,4 +0,0 @@
-label Radxa Rock pi4 linux
-  kernel /boot/Image
-  devicetree /boot/rk3399-rock-pi-4.dtb
-  append earlycon=uart8250,mmio32,0xff1a0000 root=/dev/mmcblk0p1 rootwait
board/radxa/rock-pi4/genimage.cfg deleted +0 -22
deleted file mode 100644
index b8c1cd5220..0000000000
@@ -1,22 +0,0 @@
-image sdcard.img {
-	hdimage {
-	}
-
-	partition u-boot-tpl-spl-dtb {
-		in-partition-table = "no"
-		image = "u-boot-tpl-spl-dtb.img"
-		offset = 32K
-	}
-
-	partition u-boot-dtb {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 8M
-		size = 30M
-	}
-
-	partition rootfs {
-		partition-type = 0x83
-		image = "rootfs.ext4"
-	}
-}
board/radxa/rock-pi4/post-build.sh deleted +0 -9
deleted file mode 100755
index e852ba6adf..0000000000
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-MKIMAGE=$HOST_DIR/bin/mkimage
-BOARD_DIR="$(dirname $0)"
-
-$MKIMAGE -n rk3399 -T rksd -d $BINARIES_DIR/u-boot-tpl-dtb.bin $BINARIES_DIR/u-boot-tpl-dtb.img
-cat $BINARIES_DIR/u-boot-tpl-dtb.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
-
-install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/radxa/rock-pi4/readme.txt deleted +0 -51

51 lines not on this page · raw message

configs/radxa_rock_pi4_defconfig deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.21.0
#8 lore raw

cover Remove broken defconfigs

In reply to Thomas Petazzoni
Quoted 23 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,
This patch series removes a number of defconfigs which currently fail to build and have not been fixed. Since we're about to release 2019.08, we need to get rid of them.

- ts4800 doesn't build because the kernel is too old to build with gcc 8.x. The original submitter has not replied to the several pings, including to the patch proposing to add him as a contact for this defconfig in our DEVELOPERS file.

- all the other defconfigs do not build because ATF needs to build a piece of ARM32 bare-metal code, but since the system is ARM64, Buildroot only provides an ARM64 toolchain. The solution is to create a separate Buildroot package for an ARM32 bare-metal toolchain. This has been discussed on the list, but need some effort that does not fit before 2019.08 is released.

Best regards,

Thomas Petazzoni

Quoted 8 lines

Thomas Petazzoni (7):
configs/ts4800: remove defconfig
boot/ts4800-mrboot: remove package
configs/nanopc_t4: remove defconfig
configs/nanopi_neo4: remove defconfig
configs/nanopi_m4: remove defconfig
configs/pine64_rockpro64: remove defconfig
configs/radxa_rock_pi4: remove defconfig

Committed all 7, thanks.

Signature · 1 line
Bye, Peter Korsgaard