Skip to contentSkip to conversation

(no subject)

U-Boot Thomas Schaefer 2 participants 4 messages Aug 29, 2019

lore
Share & tools
lore
#0 lore raw

Hi all,

I want to introduce a small patch that fixes v 2019.07 bootloader crash during USB scan on our i.MX7 based custom board (see explanation in the patch comment).

Could you please review and add to next u-boot release?

Best regards,
Thomas

#1 lore raw

Hi Thomas,

Quoted 9 lines · Thomas Schaefer
 arch/arm/dts/imx7d.dtsi | 2 +-
 arch/arm/dts/imx7s.dtsi | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx7d.dtsi +0 -0
index 30b058934b..2c33aa876f 100644

arch/arm/dts/imx7d.dtsi line 104

Quoted 5 lines
arch/arm/dts/imx7d.dtsi +1 -1
@@ -101,7 +101,7 @@
 &aips3 {
        usbotg2: usb at 30b20000 {
                compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
-               reg = <0x30b20000 0x200>;
+               reg = <0x30b20000 0x10000>;

Yes, I have just checked the reference manual and 0x10000 size is correct.

Could you please send a patch to fix it in the kernel dts?

Then, after it gets fixed in the kernel we can simply import it to U-Boot.

Thanks

#2 lore raw

Hi Fabio,

Quoted 21 lines

Hi Thomas,

Quoted 9 lines · Thomas Schaefer
 arch/arm/dts/imx7d.dtsi | 2 +-
 arch/arm/dts/imx7s.dtsi | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx7d.dtsi index renamed from arch/arm/dts/imx7d.dtsi +0 -0

30b058934b..2c33aa876f 100644

arch/arm/dts/imx7d.dtsi line 104

Quoted 5 lines
arch/arm/dts/imx7d.dtsi +1 -1
@@ -101,7 +101,7 @@
 &aips3 {
        usbotg2: usb at 30b20000 {
                compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
-               reg = <0x30b20000 0x200>;
+               reg = <0x30b20000 0x10000>;

Yes, I have just checked the reference manual and 0x10000 size is correct.

Quoted 5 lines

Could you please send a patch to fix it in the kernel dts?

Then, after it gets fixed in the kernel we can simply import it to U-Boot.

Thanks

does this mean that these dts files are directly imported from linux tree without modification?

I have cloned https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git . Is this the right repository to use for the patch?

I found you and Shawn Guo in the imx maintainers list (among others). Should I send the patch directly to you, and also to linux-arm-kernel at lists.infradead.org list?

Best regards,
Thomas

#3 lore raw

Hi Thomas,

Quoted 2 lines · Thomas Schaefer

does this mean that these dts files are directly imported from linux tree without modification?

Yes, this is our goal.

Quoted 2 lines

I have cloned https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git . Is this the right repository to use for the patch?

Yes, you can generate your patch against this tree.

Quoted 2 lines

I found you and Shawn Guo in the imx maintainers list (among others). Should I send the patch directly to you, and also to linux-arm-kernel at lists.infradead.org list?

Please send it via git send-email to all i.MX kernel folks and the linux-arm-kernel list.

Thanks