f2fs: fix flushing node pages when checkpoint is disabled
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: fix flushing node pages when checkpoint is disabled
This patch fixes skipping node page writes when checkpoint is disabled. In this period, we can't rely on checkpoint to flush node pages.
Fixes fd8c8caf7e7c ("f2fs: let checkpoint flush dnode page of regular")
Fixes 4354994f097d ("f2fs: checkpoint disabling")
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/node.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
fs/f2fs/node.c +4 -2
@@ -1524,7 +1524,8 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,if (unlikely (is_sbi_flag_set (sbi,SBI_POR_DOING ))) goto redirty_out; -if (wbc->sync_mode ==WB_SYNC_NONE && +if (!is_sbi_flag_set (sbi,SBI_CP_DISABLED ) && + wbc->sync_mode ==WB_SYNC_NONE &&IS_DNODE (page) &&is_cold_node (page)) goto redirty_out;
@@ -1909,7 +1910,8 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, }if (step <2 ) { -if (wbc->sync_mode ==WB_SYNC_NONE && step ==1 ) +if (!is_sbi_flag_set (sbi,SBI_CP_DISABLED ) && + wbc->sync_mode ==WB_SYNC_NONE && step ==1 ) goto out; step++; goto next_step;
Signature · 1 line
2.19.0.605.g01d371f741-goog
Quoted 6 lines · Jaegeuk Kim
This patch fixes skipping node page writes when checkpoint is disabled. In this period, we can't rely on checkpoint to flush node pages.
Fixes fd8c8caf7e7c ("f2fs: let checkpoint flush dnode page of regular")Fixes 4354994f097d ("f2fs: checkpoint disabling")Signed-off-by Jaegeuk Kim <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel