rpmsg: glink: Use struct_size() helper
Subsystems (2)
PATCH 1/1 rpmsg: glink: Use struct_size() helper
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct {
...
struct intent_pair intents[];
} __packed * msg;Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.
So, replace the following form:
sizeof(*msg) + sizeof(struct intent_pair) * count
with:
struct_size(msg, intents, count)
This code was detected with the help of Coccinelle.
--- drivers/rpmsg/qcom_glink_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rpmsg/qcom_glink_native.c +1 -1
@@ -892,7 +892,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,struct intent_pair intents[]; }__packed * msg; -const size_t msglen =sizeof (*msg) +sizeof (struct intent_pair ) * count; +const size_t msglen =struct_size (msg, intents, count);int ret;int i;unsigned long flags;
Signature · 1 line
2.23.0
Bjorn Andersson
AppliedQuoted 16 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct { ... struct intent_pair intents[]; } __packed * msg;Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.So, replace the following form:
sizeof(*msg)+sizeof(struct intent_pair)* count
Quoted 7 lines
with:
struct_size(msg, intents, count)This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks!
Quoted 20 lines
--- drivers/rpmsg/qcom_glink_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rpmsg/qcom_glink_native.c +1
-1@@ -892,7 +892,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,struct intent_pair intents[]; }__packed * msg; -const size_t msglen =sizeof (*msg) +sizeof (struct intent_pair ) * count; +const size_t msglen =struct_size (msg, intents, count);int ret;int i;unsigned long flags;Signature · 1 line
2.23.0
Quoted 20 lines · Bjorn Andersson
Quoted 18 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct { ... struct intent_pair intents[]; } __packed * msg;Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.So, replace the following form:
sizeof(*msg)+sizeof(struct intent_pair)* countwith:
Quoted 8 lines
Quoted 5 lines
struct_size(msg, intents, count)This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Applied, thanks!
Awesome. :)
Thanks!
--
Gustavo