overlayfs: filter of trusted xattr results in audit.
Subsystems (3)
PATCH 1/1 overlayfs: filter of trusted xattr results in audit.
When filtering xattr list for reading, presence of trusted xattr results in a security audit log. However, if there is other content no errno will be set, and if there isn't, the errno will be -ENODATA and not -EPERM as is usually associated with a lack of capability. The check does not block the request to list the xattrs present.
Switch to ns_capable_noaudit to reflect a more appropriate check.
Signed-off-by Mark Salyzyn <[email protected]>
Cc [email protected] # 4.4, 4.9, 4.14 & 4.19
--- fs/overlayfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/overlayfs/inode.c +2 -1
@@ -383,7 +383,8 @@ static bool ovl_can_list(const char *s)return true;/* Never list trusted.overlay, list other trusted for superuser only */ -return !ovl_is_private_xattr (s) &&capable (CAP_SYS_ADMIN ); +return !ovl_is_private_xattr (s) && +ns_capable_noaudit (&init_user_ns,CAP_SYS_ADMIN ); }ssize_t ovl_listxattr (struct dentry *dentry,char *list,size_t size)
Signature · 1 line
2.23.0.187.g17f5b7556c-goog