runtest/syscalls: add set_mempolicy*
PATCH 1/2 runtest/syscalls: add set_mempolicy*
Since commit 55ee8a5ad ("syscalls: Add set_mempolicy numa tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.
--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)
runtest/syscalls +5 -0
@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01 +set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02
Signature · 1 line
2.18.1
PATCH 2/2 runtest/numa: add migrate_pages*
Since migrate_pages must depend on numa, add it into runtest/numa.
--- runtest/numa | 4 ++++ 1 file changed, 4 insertions(+)
runtest/numa +4 -0
@@ -12,6 +12,10 @@ move_pages10 move_pages10 move_pages11 move_pages11 move_pages12 move_pages12 +migrate_pages01 migrate_pages01 +migrate_pages02 migrate_pages02 +migrate_pages03 migrate_pages03 + set_mempolicy01 set_mempolicy01 set_mempolicy02 set_mempolicy02 set_mempolicy03 set_mempolicy03
Signature · 1 line
2.18.1
PATCH 2/2 runtest/numa: add migrate_pages*
Hi Xu,
Quoted 4 lines
Since
migrate_pagesmust depend on numa, add it into runtest/numa.Signed-off-by Yang Xu <[email protected]>
Thanks for the patch, merged.
Kind regards,
Petr
PATCH 2/2 runtest/numa: add migrate_pages*
Quoted 6 lines · Petr Vorel
Hi Xu,
Quoted 3 lines
Since
migrate_pagesmust depend on numa, add it into runtest/numa.Signed-off-by Yang Xu<[email protected]>Thanks for the patch, merged.
Hi Petr,
Why don't sort numa tests alphabetically as my replied?
Best Regards,
Xiao Yang
Quoted 3 lines
Kind regards,
Petr
PATCH 2/2 runtest/numa: add migrate_pages*
Hi Yang,
Quoted 10 lines · Petr Vorel
Quoted 6 lines
Hi Xu,
Quoted 3 lines
Since
migrate_pagesmust depend on numa, add it into runtest/numa.Signed-off-by Yang Xu<[email protected]>Thanks for the patch, merged.
Hi Petr,
Why don't sort numa tests alphabetically as my replied?
I'm sorry. I overlooked it as you put your commend to 1st commit (this is a second commit). Feel free to fix it or I'll do it later today.
BTW I suggest also sort alphabetically Numa-testcases numa01.sh and rename it to numa_testcases numa01.sh
Kind regards,
Petr
PATCH 2/2 runtest/numa: add migrate_pages*
In reply to Xiao YangHi Yang,
Quoted 3 lines
Hi Petr,
Why don't sort numa tests alphabetically as my replied?
Fix merged. Thanks for reporting it.
Kind regards,
Petr
PATCH 1/2 runtest/syscalls: add set_mempolicy*
In reply to Yang XuHi,
This patch set looks good to me.
Just one comment, migrate_pages should be added before move_pages in alphabetical order.
Best Regards,
Xiao Yang
Quoted 25 lines · Yang Xu
Since commit
55ee8a5ad("syscalls: Addset_mempolicynuma tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.Signed-off-by Yang Xu<[email protected]>--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)runtest/syscalls +5
-0@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01 +set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02
PATCH 1/2 runtest/syscalls: add set_mempolicy*
In reply to Yang XuHi,
Quoted 5 lines
Since commit
55ee8a5ad("syscalls: Addset_mempolicynuma tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.Signed-off-by Yang Xu <[email protected]>
Quoted 9 lines
--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)runtest/syscalls +0
-0
runtest/syscalls setitimer01 setitimer01 · line 1186
Quoted 10 lines
runtest/syscalls +5
-0@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01 +set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02
Wouldn't be better to move all NUMA tests out of syscalls? Syscalls are big already.
BTW I'm looking forward to the new testrunner [1][2], which also solve problem of runtest files :)
Kind regards,
Petr
[1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
[2] https://github.com/metan-ucw/ltp/tree/master/docparse
PATCH 1/2 runtest/syscalls: add set_mempolicy*
Quoted 18 lines · Petr Vorel
Hi,
Quoted 4 lines
Since commit
55ee8a5ad("syscalls: Addset_mempolicynuma tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.Signed-off-by Yang Xu<[email protected]>Reviewed-by Petr Vorel<[email protected]>Quoted 11 lines
--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)runtest/syscalls +1
-0@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01
Quoted 8 lines
runtest/syscalls setitimer01 setitimer01 · line 1186
Quoted 6 lines
runtest/syscalls +4
-0+set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02Wouldn't be better to move all NUMA tests out of syscalls? Syscalls are big already.
Hi Petr,
all NUMA tests actually verify the functionality of syscalls(move_pages(2), set_mempolicy(2), etc) so I think that they can be added into syscalls group.
PS: If someone want to run syscalls from LTP as many as possible, they just need to run syscalls group directly.
Best Regards,
Xiao Yang
Quoted 12 lines
BTW I'm looking forward to the new testrunner [1][2], which also solve problem of runtest files :)
Kind regards,
Petr[1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
[2] https://github.com/metan-ucw/ltp/tree/master/docparse.
PATCH 1/2 runtest/syscalls: add set_mempolicy*
Quoted 26 lines · Xiao Yang
Quoted 17 lines · Petr Vorel
Hi,
Quoted 4 lines
Since commit
55ee8a5ad("syscalls: Addset_mempolicynuma tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.Signed-off-by Yang Xu<[email protected]>Reviewed-by Petr Vorel<[email protected]>Quoted 11 lines
--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)runtest/syscalls +1
-0@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01Quoted 8 lines
runtest/syscalls setitimer01 setitimer01 · line 1186
Quoted 6 lines
runtest/syscalls +4
-0+set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02Wouldn't be better to move all NUMA tests out of syscalls? Syscalls are big already.
Quoted 6 lines
Hi Petr,
all NUMA tests actually verify the functionality ofsyscalls(move_pages(2), set_mempolicy(2), etc)
so I think that they can be added into syscalls group.
PS: If someone want to run syscalls from LTP as many as possible, they just need to run syscalls group directly.
+1 , set_mempolicy syscall should belong to numa and syscall group.
Quoted 4 lines
Best Regards,
Xiao YangQuoted 2 lines
BTW I'm looking forward to the new testrunner [1][2], which also solve problem of runtest files :)
Hi Petr
For new testrunner, I think it is a good improvement to save test time by parallel running case. I am also looking forward to it.
Quoted 6 lines
Quoted 5 lines
Kind regards,
Petr
[1] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
[2] https://github.com/metan-ucw/ltp/tree/master/docparse
..
PATCH 1/2 runtest/syscalls: add set_mempolicy*
Hi,
Quoted 3 lines
Quoted 2 lines
PS: If someone want to run syscalls from LTP as many as possible, they just need to run syscalls group directly.
+1 ,
set_mempolicysyscall should belong to numa and syscall group.
OK, merged. + I sorted them properly, with other set_* tests in that commit.
Kind regards,
Petr
PATCH 1/2 runtest/syscalls: add set_mempolicy*
In reply to Xiao YangHi Yang,
Quoted 27 lines · Petr Vorel
Quoted 18 lines
Hi,
Quoted 4 lines
Since commit
55ee8a5ad("syscalls: Addset_mempolicynuma tests"), these cases have been added into runtests/numa, but forget to add it in runtest/syscalls.Signed-off-by Yang Xu<[email protected]>Reviewed-by Petr Vorel<[email protected]>Quoted 11 lines
--- runtest/syscalls | 5 +++++ 1 file changed, 5 insertions(+)runtest/syscalls +1
-0@@ -1177,6 +1177,11 @@ setitimer01 setitimer01 setitimer02 setitimer02 setitimer03 setitimer03 +set_mempolicy01 set_mempolicy01Quoted 8 lines
runtest/syscalls setitimer01 setitimer01 · line 1186
Quoted 6 lines
runtest/syscalls +4
-0+set_mempolicy02 set_mempolicy02 +set_mempolicy03 set_mempolicy03 +set_mempolicy04 set_mempolicy04 + setns01 setns01 setns02 setns02Wouldn't be better to move all NUMA tests out of syscalls? Syscalls are big already.
Quoted 8 lines
Hi Petr,
all NUMA tests actually verify the functionality of
syscalls(move_pages(2), set_mempolicy(2), etc)
so I think that they can be added into syscalls group.PS: If someone want to run syscalls from LTP as many as possible, they just need to run syscalls group directly.
OK, ack.
PS: I'd prefer syscalls to be just includes of other runtests (otherwise we keep forgetting to add testcases), but that won't happen until docparse & new runner are released.
Kind regards,
Petr