tests/kms_plane_lowres: Skip if no suitable mode is possible
PATCH 1/1 tests/kms_plane_lowres: Skip if no suitable mode is possible
When choosing a low resolution mode to switch to, we search the connector's mode list for a mode that's small enough that a plane positioned in the bottom left corner of the screen in the original mode will be fully offscreen in the new, smaller mode. However if no suitable modes are found in the modelist, we blindly fall back to a 10x7 mode without actually checking that the canary plane will now be offscreen. If, for example, the original mode was 13x7, then switching to 10x7 will leave the plane visible onscreen, causing the test to fail.
Before falling back to a 10x7 mode, check whether that's actually small enough. If it isn't just skip this subtest.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105581
--- tests/kms_plane_lowres.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tests/kms_plane_lowres.c +3 -1
@@ -59,8 +59,10 @@ get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) } } -if (!found) +if (!found) { +igt_skip_on (limit <=768 );return *igt_std_1024_mode_get (); + }return mode; }
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_lowres: Skip if no suitable mode is possible
== Series Details ==
== Series Details ==
Series: tests/kms_plane_lowres: Skip if no suitable mode is possible
URL : https://patchwork.freedesktop.org/series/65485/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6747 -> IGTPW_3369
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/65485/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3369 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@basic-read-no-prefault:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/fi-icl-u3/igt@[email protected]
* igt@gem_sync@basic-store-each:
- fi-cfl-8109u: [PASS][3] -> [INCOMPLETE][4] ([fdo#111427])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/fi-cfl-8109u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/fi-cfl-8109u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][5] -> [DMESG-WARN][6] ([fdo#102614])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/fi-hsw-peppy/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/fi-hsw-peppy/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111427]: https://bugs.freedesktop.org/show_bug.cgi?id=111427
Participating hosts (56 -> 47)
------------------------------
Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5146 -> IGTPW_3369
CI-20190529: 20190529
CI_DRM_6747: 49217109fcf691448235d332cbf9f4aa37fc026d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3369: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/
IGT_5146: 357dbe1869d88a2f08bcee4eebceff4ee9014424 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_lowres: Skip if no suitable mode is possible
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: tests/kms_plane_lowres: Skip if no suitable mode is possible
URL : https://patchwork.freedesktop.org/series/65485/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6747_full -> IGTPW_3369_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/65485/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3369_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-other-bsd1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +15 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb2/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-glk: [PASS][5] -> [INCOMPLETE][6] ([fdo#103359] / [k.org#198133])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-glk7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-glk8/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-apl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-apl6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-apl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-apl2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][11] -> [INCOMPLETE][12] ([fdo#105411])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-snb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109642] / [fdo#111068])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb5/igt@[email protected]
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@kms_psr@psr2_dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb7/igt@kms_psr@psr2_dpms.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-glk3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-glk1/igt@[email protected]
* igt@perf@short-reads:
- shard-glk: [PASS][21] -> [FAIL][22] ([fdo#103183])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-glk6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-glk6/igt@[email protected]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-hsw: [PASS][23] -> [FAIL][24] ([fdo#105010])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-hsw1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-hsw1/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][25] ([fdo#110854]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@deep-bsd:
- shard-iclb: [SKIP][27] ([fdo#111325]) -> [PASS][28] +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb5/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-apl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-apl8/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-iclb: [INCOMPLETE][31] ([fdo#107713] / [fdo#108840]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb4/igt@[email protected]
* igt@i915_pm_rps@min-max-config-loaded:
- shard-iclb: [FAIL][33] ([fdo#111409]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb8/igt@[email protected]
* igt@kms_atomic@plane_overlay_legacy:
- shard-snb: [SKIP][35] ([fdo#109271]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-snb5/igt@kms_atomic@plane_overlay_legacy.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-snb7/igt@kms_atomic@plane_overlay_legacy.html
* igt@kms_cursor_legacy@pipe-c-single-move:
- shard-apl: [INCOMPLETE][37] ([fdo#103927]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-apl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-apl3/igt@[email protected]
* igt@kms_flip@plain-flip-ts-check:
- shard-kbl: [DMESG-WARN][39] ([fdo#103558] / [fdo#105602]) -> [PASS][40] +17 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-kbl1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +5 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@prime_busy@wait-after-bsd2:
- shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +15 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@gem_mocs_settings@mocs-rc6-bsd2:
- shard-iclb: [SKIP][49] ([fdo#109276]) -> [FAIL][50] ([fdo#111330])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb4/igt@[email protected]
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][51] ([fdo#111330]) -> [SKIP][52] ([fdo#109276]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-iclb2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-iclb7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][53] ([fdo#105363]) -> [FAIL][54] ([fdo#102887])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-glk6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-glk4/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-farfromfence:
- shard-kbl: [SKIP][55] ([fdo#105602] / [fdo#109271]) -> [SKIP][56] ([fdo#109271]) +13 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-kbl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-kbl6/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-f:
- shard-kbl: [SKIP][57] ([fdo#105602] / [fdo#109271] / [fdo#109278]) -> [SKIP][58] ([fdo#109271] / [fdo#109278]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-kbl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-kbl: [DMESG-FAIL][59] ([fdo#103558] / [fdo#105602] / [fdo#108145]) -> [FAIL][60] ([fdo#108145]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6747/shard-kbl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/shard-kbl7/igt@[email protected]
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111409]: https://bugs.freedesktop.org/show_bug.cgi?id=111409
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5146 -> IGTPW_3369
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_6747: 49217109fcf691448235d332cbf9f4aa37fc026d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3369: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/
IGT_5146: 357dbe1869d88a2f08bcee4eebceff4ee9014424 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3369/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 23 lines · Matt Roper
When choosing a low resolution mode to switch to, we search the connector's mode list for a mode that's small enough that a plane positioned in the bottom left corner of the screen in the original mode will be fully offscreen in the new, smaller mode. However if no suitable modes are found in the modelist, we blindly fall back to a 10x7 mode without actually checking that the canary plane will now be offscreen. If, for example, the original mode was 13x7, then switching to 10x7 will leave the plane visible onscreen, causing the test to fail.
Before falling back to a 10x7 mode, check whether that's actually small enough. If it isn't just skip this subtest.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105581
Signed-off-by Matt Roper <[email protected]>--- tests/kms_plane_lowres.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)tests/kms_plane_lowres.c +0
-0
tests/kms_plane_lowres.c get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) · line 63
Quoted 6 lines
tests/kms_plane_lowres.c +2
-1@@ -59,8 +59,10 @@ get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) } } -if (!found) +if (!found) { +igt_skip_on (limit <=768 );
Instead of hardcoding 768, can we use 1024 - SIZE? This would make it clearer where this value comes from.
tests/kms_plane_lowres.c get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) · line 68
Quoted 5 lines
tests/kms_plane_lowres.c +1
-0return *igt_std_1024_mode_get (); + }return mode; }
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v2 1/1 tests/kms_plane_lowres: Skip if no suitable mode is possible
When choosing a low resolution mode to switch to, we search the connector's mode list for a mode that's small enough that a plane positioned in the bottom left corner of the screen in the original mode will be fully offscreen in the new, smaller mode. However if no suitable modes are found in the modelist, we blindly fall back to a 10x7 mode without actually checking that the canary plane will now be offscreen. If, for example, the original mode was 13x7, then switching to 10x7 will leave the plane visible onscreen, causing the test to fail.
Before falling back to a 10x7 mode, check whether that's actually small enough. If it isn't just skip this subtest.
v2: Restructure the skip condition to make it more obvious why this size
limitation is important. (Simon)
Cc: Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105581
--- tests/kms_plane_lowres.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
tests/kms_plane_lowres.c +5 -1
@@ -59,8 +59,12 @@ get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) } } -if (!found) +if (!found) { +igt_require_f (mode_default->vdisplay -SIZE >768 , +"Current mode not tall enough; plane would still be onscreen after switch to 10x7.\n" ); +return *igt_std_1024_mode_get (); + }return mode; }
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 12 lines · Matt Roper
When choosing a low resolution mode to switch to, we search the connector's mode list for a mode that's small enough that a plane positioned in the bottom left corner of the screen in the original mode will be fully offscreen in the new, smaller mode. However if no suitable modes are found in the modelist, we blindly fall back to a 10x7 mode without actually checking that the canary plane will now be offscreen. If, for example, the original mode was 13x7, then switching to 10x7 will leave the plane visible onscreen, causing the test to fail.
Before falling back to a 10x7 mode, check whether that's actually small enough. If it isn't just skip this subtest.
Quoted 6 lines
v2: Restructure the skip condition to make it more obvious why this size
limitation is important. (Simon)Cc: Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105581Signed-off-by Matt Roper <[email protected]>
Thanks!
Quoted 12 lines
--- tests/kms_plane_lowres.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)tests/kms_plane_lowres.c +0
-0@@ -59,8 +59,12 @@ get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) } }
tests/kms_plane_lowres.c get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) · line 70
Quoted 10 lines
tests/kms_plane_lowres.c +5
-1-if (!found) +if (!found) { +igt_require_f (mode_default->vdisplay -SIZE >768 , +"Current mode not tall enough; plane would still be onscreen after switch to 10x7.\n" ); +return *igt_std_1024_mode_get (); + }return mode; }
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 16 lines · Simon
Quoted 15 lines · Matt Roper
When choosing a low resolution mode to switch to, we search the connector's mode list for a mode that's small enough that a plane positioned in the bottom left corner of the screen in the original mode will be fully offscreen in the new, smaller mode. However if no suitable modes are found in the modelist, we blindly fall back to a 10x7 mode without actually checking that the canary plane will now be offscreen. If, for example, the original mode was 13x7, then switching to 10x7 will leave the plane visible onscreen, causing the test to fail.
Before falling back to a 10x7 mode, check whether that's actually small enough. If it isn't just skip this subtest.
v2: Restructure the skip condition to make it more obvious why this size
limitation is important. (Simon)
Quoted 7 lines
Quoted 3 lines
Cc: Simon Ser <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105581Signed-off-by Matt Roper <[email protected]>Thanks!
Reviewed-by Simon Ser <[email protected]>
Pushed, thanks for the review.
Matt
Quoted 23 lines
Quoted 23 lines
--- tests/kms_plane_lowres.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)tests/kms_plane_lowres.c +5
-1@@ -59,8 +59,12 @@ get_lowres_mode(int drmfd, igt_output_t *output, drmModeModeInfo *mode_default) } } -if (!found) +if (!found) { +igt_require_f (mode_default->vdisplay -SIZE >768 , +"Current mode not tall enough; plane would still be onscreen after switch to 10x7.\n" ); +return *igt_std_1024_mode_get (); + }return mode; }
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_lowres: Skip if no suitable mode is possible (rev2)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: tests/kms_plane_lowres: Skip if no suitable mode is possible (rev2)
URL : https://patchwork.freedesktop.org/series/65485/
State : success
== Summary ==
CI Bug Log - changes from IGT_5157 -> IGTPW_3399
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/65485/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_3399 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-blb-e6850/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#111108])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gtt:
- fi-glk-dsi: [PASS][5] -> [DMESG-WARN][6] ([fdo#110788])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-glk-dsi/igt@i915_selftest@live_gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-glk-dsi/igt@i915_selftest@live_gtt.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][7] -> [FAIL][8] ([fdo#110387])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-cml-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-cml-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live_active:
- fi-bsw-kefka: [DMESG-WARN][9] ([fdo#111373]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-bsw-kefka/igt@i915_selftest@live_active.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-bsw-kefka/igt@i915_selftest@live_active.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#111096]) -> [FAIL][12] ([fdo#111407])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/fi-kbl-7500u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387
[fdo#110788]: https://bugs.freedesktop.org/show_bug.cgi?id=110788
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
[fdo#111373]: https://bugs.freedesktop.org/show_bug.cgi?id=111373
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5157 -> IGTPW_3399
CI-20190529: 20190529
CI_DRM_6803: 85faeef20145630cff7aadaa516970babb67be01 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3399: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/
IGT_5157: 73d8d3ffccb6f0340e13bf006f56e3658673f345 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_lowres: Skip if no suitable mode is possible (rev2)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: tests/kms_plane_lowres: Skip if no suitable mode is possible (rev2)
URL : https://patchwork.freedesktop.org/series/65485/
State : success
== Summary ==
CI Bug Log - changes from IGT_5157_full -> IGTPW_3399_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/65485/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_3399_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@contexts:
- shard-hsw: [PASS][1] -> [TIMEOUT][2] ([fdo#111469])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-hsw8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-hsw6/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +11 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb6/igt@[email protected]
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#111325]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb4/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([fdo#108686])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-glk2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-glk2/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-apl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-apl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-apl: [PASS][11] -> [INCOMPLETE][12] ([fdo#103927]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-apl1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-apl5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][13] -> [FAIL][14] ([fdo#105363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-glk4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-glk5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb5/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103166])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb5/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-kbl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-kbl4/igt@[email protected]
* igt@perf_pmu@enable-race-bcs0:
- shard-iclb: [PASS][23] -> [INCOMPLETE][24] ([fdo#107713])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb3/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb7/igt@[email protected]
* igt@prime_busy@wait-hang-bsd1:
- shard-hsw: [PASS][25] -> [INCOMPLETE][26] ([fdo#103540]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-hsw1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-hsw2/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-iclb: [FAIL][27] ([fdo#109661]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb3/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-hsw: [FAIL][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-hsw4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-hsw1/igt@[email protected]
* igt@gem_exec_schedule@pi-ringfull-bsd:
- shard-iclb: [SKIP][31] ([fdo#111325]) -> [PASS][32] +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb8/igt@[email protected]
* igt@gem_exec_schedule@preempt-bsd1:
- shard-iclb: [SKIP][33] ([fdo#109276]) -> [PASS][34] +15 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb4/igt@[email protected]
* igt@gem_tiled_pread_pwrite:
- shard-glk: [INCOMPLETE][35] ([fdo#103359] / [k.org#198133]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-glk3/igt@gem_tiled_pread_pwrite.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-glk9/igt@gem_tiled_pread_pwrite.html
* igt@i915_pm_rpm@i2c:
- shard-hsw: [FAIL][37] ([fdo#104097]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-hsw5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-hsw1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-apl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-apl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][43] ([fdo#103166]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb6/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][47] ([fdo#108566]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5157/shard-apl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/shard-apl4/igt@[email protected]
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111469]: https://bugs.freedesktop.org/show_bug.cgi?id=111469
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5157 -> IGTPW_3399
CI-20190529: 20190529
CI_DRM_6803: 85faeef20145630cff7aadaa516970babb67be01 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3399: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/
IGT_5157: 73d8d3ffccb6f0340e13bf006f56e3658673f345 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3399/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev