Skip to contentSkip to conversation

xfs: Use WARN_ON_ONCE for bailout mount-operation

PATCH In review Austin Kim 2 participants 2 messages Aug 30, 2019 – Sep 6, 2019 XFS filesystem

lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH 1/1 xfs: Use WARN_ON_ONCE for bailout mount-operation

If the CONFIG_BUG is enabled, BUG is executed and then system is crashed. However, the bailout for mount is no longer proceeding.

Using WARN_ON_ONCE rather than BUG can prevent this situation.

---
 fs/xfs/xfs_mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
index 322da69..3ab2acf 100644
@@ -214,7 +214,7 @@ xfs_initialize_perag(
 
 		spin_lock(&mp->m_perag_lock);
 		if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
-			BUG();
+			WARN_ON_ONCE(1);
 			spin_unlock(&mp->m_perag_lock);
 			radix_tree_preload_end();
 			error = -EEXIST;
Signature · 1 line
2.6.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Austin Kim

If the CONFIG_BUG is enabled, BUG is executed and then system is crashed. However, the bailout for mount is no longer proceeding.

Using WARN_ON_ONCE rather than BUG can prevent this situation.

Looks ok,

--D

Quoted 20 lines
---
 fs/xfs/xfs_mount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
index 322da69..3ab2acf 100644
@@ -214,7 +214,7 @@ xfs_initialize_perag(
 
 		spin_lock(&mp->m_perag_lock);
 		if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
-			BUG();
+			WARN_ON_ONCE(1);
 			spin_unlock(&mp->m_perag_lock);
 			radix_tree_preload_end();
 			error = -EEXIST;
Signature · 1 line
2.6.2