xfs: fix the dax supported check in xfs_ioctl_setattr_dax_invalidate
PATCH 1/1 xfs: fix the dax supported check in xfs_ioctl_setattr_dax_invalidate
Setting the DAX flag on the directory of a file system that is not on a DAX capable device makes as little sense as setting it on a regular file on the same file system.
Signed-off-by Christoph Hellwig <[email protected]>
--- fs/xfs/xfs_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/xfs/xfs_ioctl.c +1 -2
@@ -1309,8 +1309,7 @@ xfs_ioctl_setattr_dax_invalidate(if (fa->fsx_xflags &FS_XFLAG_DAX ) {if (!(S_ISREG (inode->i_mode) ||S_ISDIR (inode->i_mode)))return -EINVAL ; -if (S_ISREG (inode->i_mode) && - !bdev_dax_supported (xfs_find_bdev_for_inode (VFS_I (ip)), +if (!bdev_dax_supported (xfs_find_bdev_for_inode (VFS_I (ip)), sb->s_blocksize))return -EINVAL ; }
Signature · 1 line
2.20.1
Quoted 5 lines · Christoph Hellwig
Setting the DAX flag on the directory of a file system that is not on a DAX capable device makes as little sense as setting it on a regular file on the same file system.
Signed-off-by Christoph Hellwig <[email protected]>
Weirdly, I never explicitly acknoweledged this...
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 21 lines
--- fs/xfs/xfs_ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/xfs/xfs_ioctl.c +1
-2@@ -1309,8 +1309,7 @@ xfs_ioctl_setattr_dax_invalidate(if (fa->fsx_xflags &FS_XFLAG_DAX ) {if (!(S_ISREG (inode->i_mode) ||S_ISDIR (inode->i_mode)))return -EINVAL ; -if (S_ISREG (inode->i_mode) && - !bdev_dax_supported (xfs_find_bdev_for_inode (VFS_I (ip)), +if (!bdev_dax_supported (xfs_find_bdev_for_inode (VFS_I (ip)), sb->s_blocksize))return -EINVAL ; }Signature · 1 line
2.20.1