staging: rts5208: Fix checkpath warning
PATCH v3 1/1 staging: rts5208: Fix checkpath warning
This patch fixes the following checkpath warning in the file drivers/staging/rts5208/rtsx_transport.c:546
WARNING: line over 80 characters
+ option = RTSX_SG_VALID | RTSX_SG_END |RTSX_SG_TRANS_DATA;
---
Changes in v3:
-Fixes the following error in da59abd45efc
Quoted 1 line
Quoted 1 line
drivers/staging//rts5208/rtsx_transport.c:548:4: error: expected
';' before 'rtsx_add_sg_tbl'
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
^~~~~~~~~~~~~~~drivers/staging/rts5208/rtsx_transport.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/rts5208/rtsx_transport.c +3 -4
@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,dev_dbg (rtsx_dev (chip),"DMA addr: 0x%x, Len: 0x%x\n" , (unsigned int )addr, len); - + + option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ;if (j == (sg_cnt -1 )) - option =RTSX_SG_VALID |RTSX_SG_END |RTSX_SG_TRANS_DATA ; -else - option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ; + option |=RTSX_SG_END ;rtsx_add_sg_tbl (chip, (u32 )addr, (u32 )len, option);
Signature · 1 line
2.7.4
Quoted 6 lines · P SAI PRASANTH
This patch fixes the following checkpath warning in the file
drivers/staging/rts5208/rtsx_transport.c:546WARNING: line over 80 characters
+ option =RTSX_SG_VALID|RTSX_SG_END|RTSX_SG_TRANS_DATA;
[]
drivers/staging/rts5208/rtsx_transport.c
Quoted 1 line
drivers/staging/rts5208/rtsx_transport.c +0
-0
[]
drivers/staging/rts5208/rtsx_transport.c static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card, · line 543
Quoted 6 lines
drivers/staging/rts5208/rtsx_transport.c +1
-1@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,dev_dbg (rtsx_dev (chip),"DMA addr: 0x%x, Len: 0x%x\n" , (unsigned int )addr, len); - +
This same line delete then insert the same blank line is very unusual.
What did you use to create this patch?
Quoted 9 lines
drivers/staging/rts5208/rtsx_transport.c +2
-3+ option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ;if (j == (sg_cnt -1 )) - option =RTSX_SG_VALID |RTSX_SG_END |RTSX_SG_TRANS_DATA ; -else - option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ; + option |=RTSX_SG_END ;rtsx_add_sg_tbl (chip, (u32 )addr, (u32 )len, option);
Quoted 29 lines · Joe Perches
Quoted 6 lines · P SAI PRASANTH
This patch fixes the following checkpath warning in the file
drivers/staging/rts5208/rtsx_transport.c:546WARNING: line over 80 characters
+ option =RTSX_SG_VALID|RTSX_SG_END|RTSX_SG_TRANS_DATA;[]
drivers/staging/rts5208/rtsx_transport.c
Quoted 1 line
drivers/staging/rts5208/rtsx_transport.c +0
-0[]
drivers/staging/rts5208/rtsx_transport.c static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card, · line 543
Quoted 6 lines
drivers/staging/rts5208/rtsx_transport.c +1
-1@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,dev_dbg (rtsx_dev (chip),"DMA addr: 0x%x, Len: 0x%x\n" , (unsigned int )addr, len); - +This same line delete then insert the same blank line is very unusual.
What did you use to create this patch?
Quoted 7 lines
drivers/staging/rts5208/rtsx_transport.c +2
-3+ option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ;if (j == (sg_cnt -1 )) - option =RTSX_SG_VALID |RTSX_SG_END |RTSX_SG_TRANS_DATA ; -else - option =RTSX_SG_VALID |RTSX_SG_TRANS_DATA ; + option |=RTSX_SG_END ;
Quoted 3 lines
drivers/staging/rts5208/rtsx_transport.c static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card, · line 549
Quoted 2 lines
drivers/staging/rts5208/rtsx_transport.c +0
-0rtsx_add_sg_tbl (chip, (u32 )addr, (u32 )len, option);
I have used vim for creating this patch. Upon checking, there is an extra tab on the new blankline which has been added. I'm sending an update immediately.