genirq: move debugfs option to kernel hacking
Subsystems (2)
PATCH 1/1 genirq: move debugfs option to kernel hacking
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu.
--- kernel/irq/Kconfig | 12 ------------ lib/Kconfig.debug | 11 +++++++++++ 2 files changed, 11 insertions(+), 12 deletions(-)
kernel/irq/Kconfig +0 -12
@@ -123,18 +123,6 @@ config SPARSE_IRQ out the interrupt descriptors in a more NUMA-friendly way. ) If you don't know what to do here, say N. - -config GENERIC_IRQ_DEBUGFS - bool "Expose irq internals in debugfs" - depends on DEBUG_FS - default n - ---help--- - - Exposes internal state information through debugfs. Mostly for - developers and debugging of hard to diagnose interrupt problems. - - If you don't know what to do here, say N. - endmenu config GENERIC_IRQ_MULTI_HANDLER
lib/Kconfig.debug +11 -0
@@ -2142,6 +2142,17 @@ config IO_STRICT_DEVMEM If in doubt, say Y. +config GENERIC_IRQ_DEBUGFS + bool "Expose irq internals to userspace via debugfs" + depends on DEBUG_FS + default n + ---help--- + + Exposes internal state information through debugfs. Mostly for + developers and debugging of hard to diagnose interrupt problems. + + If you don't know what to do here, say N. + source "arch/$(SRCARCH)/Kconfig.debug" endmenu # Kernel hacking
Signature · 1 line
2.20.1
Quoted 2 lines · Changbin Du
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu.
Why?
Kernel hacking is a inscrutable mess where you can waste a lot of time to find what you are looking for.
If I want to debug interrupts then having the option right there where all other interrupt related configuration is makes tons of sense.
I would be less opposed to this when the kernel hacking menu would be halfways well structured, but you just chose another random place for that option which is worse than what we have now.
Thanks,
tglx
Quoted 10 lines · Thomas Gleixner
Quoted 2 lines · Changbin Du
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu.
Why?
Kernel hacking is a inscrutable mess where you can waste a lot of time to find what you are looking for.
yes, the 'kernel hacking' menu has many items now and are not well structured. Let me see if it can be improved.
Quoted 7 lines
If I want to debug interrupts then having the option right there where all other interrupt related configuration is makes tons of sense.
I would be less opposed to this when the kernel hacking menu would be halfways well structured, but you just chose another random place for that option which is worse than what we have now.
We already have an irq debug option CONFIG_DEBUG_SHIRQ here. Maybe we can group them into a submenu.
Quoted 6 lines
Thanks,
tglx
Signature · 2 lines
Cheers, Changbin Du
Quoted 17 lines · On Sun, 1 Sep 2019 18:10:33 +0800 Changbin Du <[email protected]> wrote:
Quoted 10 lines · Thomas Gleixner
Quoted 2 lines · Changbin Du
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu.
Why?
Kernel hacking is a inscrutable mess where you can waste a lot of time to find what you are looking for.
yes, the 'kernel hacking' menu has many items now and are not well structured. Let me see if it can be improved.
Quoted 3 lines
If I want to debug interrupts then having the option right there where all other interrupt related configuration is makes tons of sense.
Quoted 6 lines
Quoted 4 lines
I would be less opposed to this when the kernel hacking menu would be halfways well structured, but you just chose another random place for that option which is worse than what we have now.
We already have an irq debug option
CONFIG_DEBUG_SHIRQhere. Maybe we can group them into a submenu.
DEBUG_SHIRQ is extremely different from GENERIC_IRQ_DEBUGFS. The former is a test option, verifying that endpoint drivers have a correct behaviour. The latter is a dump of the kernel internals, which is mostly for people dealing with the internals of the IRQ subsystem.
Preserving this distinction between the users of the IRQ API on one side and the debugging of the IRQ subsystem on the other is important. Moving these two things close together could make it even more confusing for the users (who usually do not need to mess with the IRQ subsystem's internals...).
Thanks,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Quoted 32 lines · Marc Zyngier
Quoted 17 lines · On Sun, 1 Sep 2019 18:10:33 +0800 Changbin Du <[email protected]> wrote:
Quoted 10 lines · Thomas Gleixner
Quoted 2 lines · Changbin Du
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu.
Why?
Kernel hacking is a inscrutable mess where you can waste a lot of time to find what you are looking for.
yes, the 'kernel hacking' menu has many items now and are not well structured. Let me see if it can be improved.
Quoted 3 lines
If I want to debug interrupts then having the option right there where all other interrupt related configuration is makes tons of sense.
Quoted 6 lines
Quoted 4 lines
I would be less opposed to this when the kernel hacking menu would be halfways well structured, but you just chose another random place for that option which is worse than what we have now.
We already have an irq debug option
CONFIG_DEBUG_SHIRQhere. Maybe we can group them into a submenu.
DEBUG_SHIRQis extremely different fromGENERIC_IRQ_DEBUGFS. The former is a test option, verifying that endpoint drivers have a correct behaviour. The latter is a dump of the kernel internals, which is mostly for people dealing with the internals of the IRQ subsystem.
Quoted 6 lines
Preserving this distinction between the users of the IRQ API on one side and the debugging of the IRQ subsystem on the other is important. Moving these two things close together could make it even more confusing for the users (who usually do not need to mess with the IRQ subsystem's internals...).
IMHO, these are two distinct irq *debug* options. If we prefer preserving current position, please skip this patch. Thanks.
Quoted 5 lines
Thanks,
M.Signature · 1 line
Without deviation from the norm, progress is not possible.
Signature · 2 lines
Cheers, Changbin Du