Skip to contentSkip to conversation

toolchain/external: copy libssp.so if SSP is enabled

PATCH New Yann Droneaud 3 participants 10 messages Sep 2, 2019 – Sep 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

Unlike libgcc_s.so, libssp.so is not copied on the target file system. As it's available at link time, allowing packages such as sox to be linked against the library.

As it's not copied, running programs linked against libssp.so lead to failure such as the following:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library must be copied to the target filesystem, like libgcc_s.so.

If BR2_SSP_NONE is set, there should be no need to copy it.

---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++
 1 file changed, 4 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +4 -0
index c3ddff263fe9..175a87756437 100644
@@ -114,6 +114,10 @@ endif
 
 TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.* libatomic.so.*
 
+ifneq ($(BR2_SSP_NONE),y)
+TOOLCHAIN_EXTERNAL_LIBS += libssp.so.*
+endif
+
 ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y)
 TOOLCHAIN_EXTERNAL_LIBS += libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/2 packages/sox: disable stack protector if SSP is not enabled

By default, sox link with libssp.so when available.

libssp.so is usually available within builtroot, as it's provided by almost, if not all, external cross toolchains.

Unfortunately, unlike libgcc_s.so, libssp.so is not copied on the target filesystem, so it's only available at link time and not at runtime, hence the following failures on target:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory

If BR2_SSP_NONE is set, libssp.so is not expected to be copied, so sox must not use it, and must be configured with --disable-stack-protector.

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library should be made available on target, so sox could use it.

---
 package/sox/sox.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/sox/sox.mk +4 -0
index 0b3dc136d815..a3d1089bf747 100644
@@ -13,6 +13,10 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPL-2.0+ (sox binary), LGPL-2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+ifeq ($(BR2_SSP_NONE),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif
+
 # MIPS Codescape toolchains don't support stack-smashing protection
 # despite of using glibc.
 ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
Signature · 1 line
2.21.0
#2 lore raw

PATCH 2/2 packages/sox: disable stack protector if SSP is not enabled

Hi Yann,

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit?:

Quoted 33 lines

By default, sox link with libssp.so when available.

libssp.so is usually available within builtroot, as it's provided by almost, if not all, external cross toolchains.

Unfortunately, unlike libgcc_s.so, libssp.so is not copied on the target filesystem, so it's only available at link time and not at runtime, hence the following failures on target:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory

If BR2_SSP_NONE is set, libssp.so is not expected to be copied, so sox must not use it, and must be configured with --disable-stack-protector.

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library should be made available on target, so sox could use it.

---
 package/sox/sox.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/sox/sox.mk +0 -0
index 0b3dc136d815..a3d1089bf747 100644

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \ · line 18

Quoted 6 lines
package/sox/sox.mk +3 -0
@@ -13,6 +13,10 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPL-2.0+ (sox binary), LGPL-2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+ifeq ($(BR2_SSP_NONE),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

It make sense to explicitly disable the ssp suppport when BR2_SSP_NONE even if the toolchain support it. But the commit log is about libssp.

From sox's config.log, you can notice the missing libssp library

checking whether libssp exists [..]/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-linux-gnu/8.3.0/../../../../aarch64-linux-gnu/bin/ld:
cannot find -lssp
collect2: error: ld returned 1 exit status

Then the successful ssp check:

checking whether stack-smashing protection is available
result: yes
checking whether stack-smashing protection is buggy
result: no
checking whether [..]host/bin/aarch64-linux-gnu-gcc accepts -fstack-protector [...]/host/bin/aarch64-linux-gnu-gcc -c -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fstack-protector -Werror
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5 configure:9519: $? = 0
configure:9528: result: yes

At the end of configuration report:
ssp_cv_cc=yes
ssp_cv_lib=no

Note, the SSP support is completely disabled when the toolchain doesn't support it. [1]

[1] https://git.buildroot.net/buildroot/tree/package/sox/sox.mk#n12

Best regards,
Romain

Quoted 5 lines
package/sox/sox.mk +1 -0
+
 # MIPS Codescape toolchains don't support stack-smashing protection
 # despite of using glibc.
 ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS)$(BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS),y)
#3 lore raw

PATCH 2/2 packages/sox: disable stack protector if SSP is not enabled

Hi,

Le samedi 07 septembre 2019 ? 15:38 +0200, Romain Naour a ?crit :

Quoted 75 lines

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit :

Quoted 38 lines

By default, sox link with libssp.so when available.

libssp.so is usually available within builtroot, as it's provided by almost, if not all, external cross toolchains.

Unfortunately, unlike libgcc_s.so, libssp.so is not copied on the target filesystem, so it's only available at link time and not at runtime, hence the following failures on target:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory

If BR2_SSP_NONE is set, libssp.so is not expected to be copied, so sox must not use it, and must be configured with --disable-stack- protector.

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so
provides __stack_chk_fail, and *_chk symbols, the library should be made
available on target, so sox could use it.

---
 package/sox/sox.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/sox/sox.mk +0 -0
index 0b3dc136d815..a3d1089bf747 100644

package/sox/sox.mk SOX_CONF_OPTS = --with-distro="Buildroot" -- · line 19

Quoted 7 lines
package/sox/sox.mk +3 -0
@@ -13,6 +13,10 @@ SOX_CONF_OPTS = --with-distro="Buildroot" --
 without-ffmpeg --disable-gomp \
 SOX_LICENSE = GPL-2.0+ (sox binary), LGPL-2.1+ (libraries)
 SOX_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL
 
+ifeq ($(BR2_SSP_NONE),y)
+SOX_CONF_OPTS += --disable-stack-protector
+endif

It make sense to explicitly disable the ssp suppport when BR2_SSP_NONE even if
the toolchain support it. But the commit log is about libssp.

From sox's config.log, you can notice the missing libssp library

checking whether libssp exists [..]/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-linux- gnu/8.3.0/../../../../aarch64-linux-gnu/bin/ld:
cannot find -lssp
collect2: error: ld returned 1 exit status

Then the successful ssp check:

checking whether stack-smashing protection is available
result: yes
checking whether stack-smashing protection is buggy
result: no
checking whether [..]host/bin/aarch64-linux-gnu-gcc accepts -fstack- protector
[...]/host/bin/aarch64-linux-gnu-gcc -c -D_LARGEFILE_SOURCE

(quoted diff) +0 -3
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os   -fstack-protector 
-Werror
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64

conftest.c >&5
configure:9519: $? = 0
configure:9528: result: yes

Quoted 4 lines

At the end of configuration report:
ssp_cv_cc=yes
ssp_cv_lib=no

But linaro aarch64 toolchain have the library.

Quoted 5 lines

Note, the SSP support is completely disabled when the toolchain doesn't support
it. [1]

[1] https://git.buildroot.net/buildroot/tree/package/sox/sox.mk#n12

And linaro aarch64 toolchain set BR2_TOOLCHAIN_HAS_SSP=y

Then sox's configure try to link with libssp explictely, even if not using -fstack-protection*.

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA
#4 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

In reply to Yann Droneaud

Hi Yann,

Thanks for your patch.

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit?:

Quoted 10 lines

Unlike libgcc_s.so, libssp.so is not copied on the target file system. As it's available at link time, allowing packages such as sox to be linked against the library.

As it's not copied, running programs linked against libssp.so lead to failure such as the following:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory
Quoted 8 lines
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot open shared object file: No such file or directory

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library must be copied to the target filesystem, like libgcc_s.so.

If BR2_SSP_NONE is set, there should be no need to copy it.

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP support. But there is no libssp.so in this toolchain.

Also, libssp from gcc is disabled in Buildroot for internal toolchain since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

In Buildroot, we are using libssp provided by the C library (glibc, musl, uClibc-ng) when available. We are not using libssp from gcc.

Can you describe your issue ? Are you using a custom external toolchain ?

Best regards,
Romain

Quoted 22 lines
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++
 1 file changed, 4 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +4 -0
index c3ddff263fe9..175a87756437 100644
@@ -114,6 +114,10 @@ endif
 
 TOOLCHAIN_EXTERNAL_LIBS += ld*.so* libgcc_s.so.* libatomic.so.*
 
+ifneq ($(BR2_SSP_NONE),y)
+TOOLCHAIN_EXTERNAL_LIBS += libssp.so.*
+endif
+
 ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y)
 TOOLCHAIN_EXTERNAL_LIBS += libc.so.* libcrypt.so.* libdl.so.* libm.so.* libnsl.so.* libresolv.so.* librt.so.* libutil.so.*
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
#5 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

Hello Romain,

Quoted 21 lines · On Sat, 7 Sep 2019 15:18:06 +0200 Romain Naour <[email protected]> wrote:

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y
BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP support. But there is no libssp.so in this toolchain.

Quoted 7 lines

Also, libssp from gcc is disabled in Buildroot for internal toolchain since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

In Buildroot, we are using libssp provided by the C library (glibc, musl, uClibc-ng) when available. We are not using libssp from gcc.

Can you describe your issue ? Are you using a custom external toolchain ?

Yes, I suspect Yann is using a custom external toolchain where the SSP runtime support is provided by gcc and not by the C library.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

Le samedi 07 septembre 2019 ? 21:23 +0200, Thomas Petazzoni a ?crit :

Quoted 35 lines

Hello Romain,

Quoted 30 lines · On Sat, 7 Sep 2019 15:18:06 +0200 Romain Naour <[email protected]> wrote:

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64- virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP support.
But there is no libssp.so in this toolchain.

Also, libssp from gcc is disabled in Buildroot for internal toolchain since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

In Buildroot, we are using libssp provided by the C library (glibc, musl, uClibc-ng) when available. We are not using libssp from gcc.

Quoted 7 lines
Quoted 2 lines

Can you describe your issue ? Are you using a custom external toolchain ?

Yes, I suspect Yann is using a custom external toolchain where the SSP
runtime support is provided by gcc and not by the C library.

I'm using linaro aarch64 ... but I remembered, incorrectly, having check for other aarch64 toolchain: the other external toolchain don't have libssp.

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA
#7 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

In reply to Romain Naour

Hi,

Le samedi 07 septembre 2019 ? 15:18 +0200, Romain Naour a ?crit :

Quoted 53 lines

Thanks for your patch.

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit :

Quoted 15 lines

Unlike libgcc_s.so, libssp.so is not copied on the target file system. As it's available at link time, allowing packages such as sox to be linked against the library.

As it's not copied, running programs linked against libssp.so lead to failure such as the following:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory
Quoted 5 lines

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library must be copied to the target filesystem, like libgcc_s.so.

If BR2_SSP_NONE is set, there should be no need to copy it.

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64- virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP support.
But there is no libssp.so in this toolchain.

Also, libssp from gcc is disabled in Buildroot for internal toolchain since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

Quoted 6 lines

In Buildroot, we are using libssp provided by the C library (glibc, musl, uClibc-ng) when available. We are not using libssp from gcc.

Can you describe your issue ? Are you using a custom external toolchain ?

I'm sorry I wasn't specific enough. I had the issue with linaro aarch64 external toolchain. (For some reason I don't recall, I thought this issue happen with other toolchain, but it's doesn't happen with ARM one as you demonstrated, nor with Codesourcery one).

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA
#8 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

Hi Yann,

Le 09/09/2019 ? 22:11, Yann Droneaud a ?crit?:

Quoted 60 lines

Hi,

Le samedi 07 septembre 2019 ? 15:18 +0200, Romain Naour a ?crit :

Quoted 56 lines

Thanks for your patch.

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit :

Quoted 15 lines

Unlike libgcc_s.so, libssp.so is not copied on the target file system. As it's available at link time, allowing packages such as sox to be linked against the library.

As it's not copied, running programs linked against libssp.so lead to failure such as the following:

  $ sox
  sox: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0: cannot
open shared object file: No such file or directory
Quoted 5 lines

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library must be copied to the target filesystem, like libgcc_s.so.

If BR2_SSP_NONE is set, there should be no need to copy it.

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64- virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP support.
But there is no libssp.so in this toolchain.

Also, libssp from gcc is disabled in Buildroot for internal toolchain since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

In Buildroot, we are using libssp provided by the C library (glibc, musl, uClibc-ng) when available. We are not using libssp from gcc.

Quoted 8 lines
Quoted 3 lines

Can you describe your issue ? Are you using a custom external toolchain ?

I'm sorry I wasn't specific enough. I had the issue with linaro aarch64 external toolchain. (For some reason I don't recall, I thought this issue happen with other toolchain, but it's doesn't happen with ARM one as you demonstrated, nor with Codesourcery one).

No problem at all!

Actually the toolchain have both ssp implementation: libssp from gcc and ssp from Glibc!

ssp_cv_cc=yes
ssp_cv_lib=yes

I did a second build and removed libssp* files after extracting the toolchain and sox is able to detect the ssp support from Glibc.

ssp_cv_cc=yes
ssp_cv_lib=no

Note: the ssp test from helpers.mk [1] only test without -lssp. You can find additional information here [2].

So, you can patch sox to prefer the libc's ssp implementation and/or remove those libssp libraries from a POST_EXTRACT_HOOKS in the toolchain-external-linaro-aarch64 package.

[1]
https://git.buildroot.net/buildroot/tree/toolchain/helpers.mk?id=03fb00f2175cdb4565e26fcb9b3da1c1059de1bd#n424
[2] https://patchwork.openembedded.org/patch/150197/

Best regards,
Romain

Quoted 3 lines

Regards.

#9 lore raw

PATCH 1/2 toolchain/external: copy libssp.so if SSP is enabled

Hi,

Le lundi 09 septembre 2019 ? 23:23 +0200, Romain Naour a ?crit :

Quoted 91 lines

Le 09/09/2019 ? 22:11, Yann Droneaud a ?crit :

Quoted 67 lines

Le samedi 07 septembre 2019 ? 15:18 +0200, Romain Naour a ?crit :

Quoted 56 lines

Thanks for your patch.

Le 02/09/2019 ? 08:37, Yann Droneaud a ?crit :

Quoted 17 lines

Unlike libgcc_s.so, libssp.so is not copied on the target file system. As it's available at link time, allowing packages such as sox to be linked against the library.

As it's not copied, running programs linked against libssp.so lead to failure such as the following:

  $ sox
  sox: error while loading shared libraries: libssp.so.0:
cannot
open shared object file: No such file or directory
  $ rec
  rec: error while loading shared libraries: libssp.so.0:
cannot
open shared object file: No such file or directory
Quoted 6 lines

If BR2_SSP_REGULAR, BR2_SSP_STRONG, or BR2_SSP_ALL is set, as libssp.so provides __stack_chk_fail, and *_chk symbols, the library must be copied to the target filesystem, like libgcc_s.so.

If BR2_SSP_NONE is set, there should be no need to copy it.

I'm unable to reproduce the issue with the following defconfig:

BR2_aarch64=y
BR2_SSP_ALL=y
BR2_TOOLCHAIN_EXTERNAL=y BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0" BR2_SYSTEM_DHCP="eth0"
BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16" BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64- virt/linux.config" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y BR2_PACKAGE_SOX=y
BR2_TARGET_ROOTFS_EXT2=y BR2_TARGET_ROOTFS_EXT2_4=y
# BR2_TARGET_ROOTFS_TAR is not set

This defconfig use the external toolchain from ARM that provide SSP
support.
But there is no libssp.so in this toolchain.

Also, libssp from gcc is disabled in Buildroot for internal toolchain
since a while:
https://git.buildroot.net/buildroot/commit/?id=3b712a3d891bf23055a587fc518f7cd2139a6a09

Quoted 8 lines

In Buildroot, we are using libssp provided by the C library (glibc,
musl, uClibc-ng) when available. We are not using libssp from gcc.

Can you describe your issue ? Are you using a custom external toolchain ?

Quoted 6 lines

I'm sorry I wasn't specific enough. I had the issue with linaro aarch64
external toolchain. (For some reason I don't recall, I thought this issue happen with other toolchain, but it's doesn't happen with ARM one
as you demonstrated, nor with Codesourcery one).

No problem at all!

Actually the toolchain have both ssp implementation: libssp from gcc and ssp
from Glibc!

ssp_cv_cc=yes
ssp_cv_lib=yes

I did a second build and removed libssp* files after extracting the toolchain
and sox is able to detect the ssp support from Glibc.

ssp_cv_cc=yes
ssp_cv_lib=no

Quoted 8 lines

Note: the ssp test from helpers.mk [1] only test without -lssp. You can find additional information here [2].

So, you can patch sox to prefer the libc's ssp implementation and/or remove
those libssp libraries from a POST_EXTRACT_HOOKS in the toolchain-external-linaro-aarch64 package.

Thanks for the analysis and suggestion.

Unfortunately I don't have incentive/will/time to address this issue anymore.

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA